Skip to content

virtio-console: notify about the terminal size

Szymon Lukasz qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest9 patches 8 repliesIn review
  2. v26 patches 8 repliesSuperseded
  3. v16 patches 1 replySuperseded

Changes in v3 from the cover letter

add resize messages over QMP, as suggested by Daniel

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9chardev: add cols, rows fieldschardev/char-fe.c include/chardev/char-fe.h include/chardev/char.h+24 -00 replies
2/9chardev: add CHR_EVENT_RESIZEbackends/cryptodev-vhost-user.c chardev/char.c hw/block/vhost-user-blk.c +10 more+16 -00 replies
3/9chardev: add qemu_chr_resize()chardev/char.c include/chardev/char.h+13 -00 replies
4/9char-mux: add support for the terminal sizechardev/char-mux.c+17 -10 replies
5/9main-loop: change the handling of SIGWINCHinclude/qemu/main-loop.h ui/curses.c util/main-loop.c+31 -50 replies
6/9char-stdio: add support for the terminal sizechardev/char-stdio.c+29 -00 replies
7/9qmp: add chardev-resize commandchardev/char.c qapi/char.json+39 -00 replies
8/9virtio-serial-bus: add terminal resize messageshw/char/trace-events hw/char/virtio-serial-bus.c hw/core/machine.c +1 more+47 -20 replies
9/9virtio-console: notify the guest about terminal resizeshw/char/virtio-console.c+58 -40 replies

Reviews trailers per patch

1 of 9 patches has a Reviewed-by or Acked-by.

PatchMichael S. Tsirkin
1/9
2/9
3/9
4/9
5/9
6/9
7/9
8/9R-b
9/9

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/9] virtio-console: notify about the terminal size

The goal of this series is to have a resizable terminal into a guest without having to set up networking and using, e.g. ssh.

The virtio spec allows a virtio-console device to notify the guest about terminal resizes in the host. Linux Kernel implements the driver part of the spec. This series implement the device part in QEMU.

This series adds support for a resizable terminal if a virtio console device is connected to the stdio backend.

This series also introduces resize messages that can be sent over QMP to notify QEMU about the size of the terminal connented to some chardev. In the libvirt setting, it will allow to implement a resizable terminal for virsh console and other libvirt clients.

v3:
add resize messages over QMP, as suggested by Daniel

v2:
fix adding a new virtio feature bit to the virtio console device

Szymon Lukasz (9):
chardev: add cols, rows fields
chardev: add CHR_EVENT_RESIZE
chardev: add qemu_chr_resize()
char-mux: add support for the terminal size
main-loop: change the handling of SIGWINCH
char-stdio: add support for the terminal size
qmp: add chardev-resize command
virtio-serial-bus: add terminal resize messages
virtio-console: notify the guest about terminal resizes

 backends/cryptodev-vhost-user.c   |  1 +
 chardev/char-fe.c                 | 13 +++++++
 chardev/char-mux.c                | 18 ++++++++-
 chardev/char-stdio.c              | 29 ++++++++++++++
 chardev/char.c                    | 26 +++++++++++++
 hw/block/vhost-user-blk.c         |  1 +
 hw/char/terminal3270.c            |  1 +
 hw/char/trace-events              |  1 +
 hw/char/virtio-console.c          | 63 +++++++++++++++++++++++++++++--
 hw/char/virtio-serial-bus.c       | 42 ++++++++++++++++++++-
 hw/core/machine.c                 |  1 +
 hw/ipmi/ipmi_bmc_extern.c         |  1 +
 hw/usb/ccid-card-passthru.c       |  1 +
 hw/usb/dev-serial.c               |  1 +
 hw/usb/redirect.c                 |  1 +
 include/chardev/char-fe.h         | 10 +++++
 include/chardev/char.h            |  7 ++++
 include/hw/virtio/virtio-serial.h |  5 +++
 include/qemu/main-loop.h          |  4 ++
 monitor/hmp.c                     |  1 +
 monitor/qmp.c                     |  1 +
 net/vhost-user.c                  |  1 +
 qapi/char.json                    | 25 ++++++++++++
 ui/curses.c                       | 11 +++---
 util/main-loop.c                  | 21 +++++++++++
 25 files changed, 274 insertions(+), 12 deletions(-)
Signature · 1 line
2.27.0