Skip to content

net: improve devres helpers

Bartosz Golaszewski linux-arm-kernel linux-devicetree linux-mediatek lkml netdev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest10 patches 11 repliesIn review
  2. v111 patches 5 repliesSuperseded

Changes in v2 from the cover letter

- drop the patch relaxing devm_register_netdev()
- require struct mii_bus to be managed in devm_mdiobus_register() and devm_of_mdiobus_register() but don't store that information in the structure itself: use devres_find() instead

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10net: ethernet: ixgbe: check the return value of ixgbe_mii_bus_init()drivers/net/ethernet/intel/ixgbe/ixgbe_main.c+5 -12 replies
2/10net: ethernet: ixgbe: don't call devm_mdiobus_free()drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c+3 -112 replies
3/10net: devres: rename the release callback of devm_register_netdev()net/devres.c+2 -21 reply
4/10Documentation: devres: add missing mdio helperDocumentation/driver-api/driver-model/devres.rst+1 -01 reply
5/10phy: un-inline devm_mdiobus_register()drivers/net/phy/Makefile drivers/net/phy/mdio_devres.c include/linux/phy.h+21 -141 reply
6/10phy: mdio: add kerneldoc for __devm_mdiobus_register()drivers/net/phy/mdio_devres.c+7 -01 reply
7/10net: phy: don't abuse devres in devm_mdiobus_register()Documentation/driver-api/driver-model/devres.rst drivers/net/ethernet/realtek/r8169_main.c drivers/net/phy/mdio_bus.c +2 more+82 -870 replies
8/10of: mdio: remove the 'extern' keyword from function declarationsinclude/linux/of_mdio.h+18 -191 reply
9/10of: mdio: provide devm_of_mdiobus_register()Documentation/driver-api/driver-model/devres.rst drivers/net/phy/Makefile drivers/net/phy/mdio_devres.c +1 more+44 -10 replies
10/10net: ethernet: mtk-star-emac: use devm_of_mdiobus_register()drivers/net/ethernet/mediatek/mtk_star_emac.c+1 -120 replies

Reviews trailers per patch

7 of 10 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchFlorian FainelliJeff KirsherJakub Kicinski
SeriesA-b
1/10R-b A-b
2/10R-b A-b
3/10R-b
4/10R-b
5/10R-b
6/10R-b
7/10
8/10R-b
9/10
10/10

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCH v2 00/10] net: improve devres helpers

From: Bartosz Golaszewski <[email protected]>

So it seems like there's no support for relaxing certain networking devres helpers to not require previously allocated structures to also be managed. However the way mdio devres variants are implemented is still wrong and I modified my series to address it while keeping the functions strict.

First two patches modify the ixgbe driver to get rid of the last user of devm_mdiobus_free().

Patches 3, 4, 5 and 6 are mostly cosmetic.

Patch 7 fixes the way devm_mdiobus_register() is implemented.

Patches 8 & 9 provide a managed variant of of_mdiobus_register() and last patch uses it in mtk-star-emac driver.

v1 -> v2:
- drop the patch relaxing devm_register_netdev()
- require struct mii_bus to be managed in devm_mdiobus_register() and devm_of_mdiobus_register() but don't store that information in the structure itself: use devres_find() instead

Bartosz Golaszewski (10):
net: ethernet: ixgbe: check the return value of ixgbe_mii_bus_init()
net: ethernet: ixgbe: don't call devm_mdiobus_free()
net: devres: rename the release callback of devm_register_netdev()
Documentation: devres: add missing mdio helper
phy: un-inline devm_mdiobus_register()
phy: mdio: add kerneldoc for __devm_mdiobus_register()
net: phy: don't abuse devres in devm_mdiobus_register()
of: mdio: remove the 'extern' keyword from function declarations
of: mdio: provide devm_of_mdiobus_register()
net: ethernet: mtk-star-emac: use devm_of_mdiobus_register()

 .../driver-api/driver-model/devres.rst        |   3 +-
 drivers/net/ethernet/intel/ixgbe/ixgbe_main.c |   6 +-
 drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c  |  14 +-
 drivers/net/ethernet/mediatek/mtk_star_emac.c |  13 +-
 drivers/net/ethernet/realtek/r8169_main.c     |   2 +-
 drivers/net/phy/Makefile                      |   2 +
 drivers/net/phy/mdio_bus.c                    |  73 ----------
 drivers/net/phy/mdio_devres.c                 | 133 ++++++++++++++++++
 include/linux/of_mdio.h                       |  40 +++---
 include/linux/phy.h                           |  21 +--
 net/devres.c                                  |   4 +-
 11 files changed, 174 insertions(+), 137 deletions(-)
 create mode 100644 drivers/net/phy/mdio_devres.c
Signature · 7 lines
2.26.1


_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek