Skip to content

wireguard fixes for 5.8-rc3

Jason A. Donenfeld netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2wireguard: noise: do not assign initiation time in if conditiondrivers/net/wireguard/noise.c+2 -20 replies
2/2wireguard: device: avoid circular netns referencesdrivers/net/wireguard/device.c drivers/net/wireguard/device.h drivers/net/wireguard/netlink.c +2 more+67 -464 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH net 0/2] wireguard fixes for 5.8-rc3

Hi Dave,

This series contains two fixes, one cosmetic and one quite important:

1) Avoid the if ((x = f()) == y) pattern, from Frank Werner-Krippendorf.

2) Mitigate a potential memory leak by creating circular netns references, while also making the netns semantics a bit more robust.

Patch (2) has a "Fixes:" line and should be backported to stable.

Thanks,
Jason

Frank Werner-Krippendorf (1):
wireguard: noise: do not assign initiation time in if condition

Jason A. Donenfeld (1):
wireguard: device: avoid circular netns references

 drivers/net/wireguard/device.c             | 58 ++++++++++------------
 drivers/net/wireguard/device.h             |  3 +-
 drivers/net/wireguard/netlink.c            | 14 ++++--
 drivers/net/wireguard/noise.c              |  4 +-
 drivers/net/wireguard/socket.c             | 25 +++++++---
 tools/testing/selftests/wireguard/netns.sh | 13 ++++-
 6 files changed, 69 insertions(+), 48 deletions(-)
Signature · 1 line
2.27.0