Skip to content

bugreport: report configs from safelist

Emily Shaffer git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2bugreport: generate config safelist based on docs.gitignore Documentation/asciidoc.conf Documentation/asciidoctor-extensions.rb +3 more+70 -282 replies
2/2bugreport: add config values from safelistDocumentation/git-bugreport.txt Makefile bugreport.c+31 -00 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by.

PatchMartin ÅgrenJohannes Schindelin
1/2Helped-by Helped-by
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] bugreport: report configs from safelist

Some configs are useful to know when trying to diagnose or reproduce an issue. However, other configs are sensitive and should not be shared with others. Finally, many tools which wrap or augment Git also use Git's config system, and so may store sensitive information which Git is not aware of. Therefore, it makes sense for git-bugreport to gather configs which Git developers have decided are safe and useful - a safelist - but no other configs which the user may have. This list of safe configs can be expanded over time and is generated from documentation.

This series is based on 'master' but was cherry-picked from quite some time ago, so it's possible there's some anachronism I missed reviewing it myself :)

- Emily

Emily Shaffer (2):
bugreport: generate config safelist based on docs
bugreport: add config values from safelist

 .gitignore                              |  1 +
 Documentation/asciidoc.conf             |  9 ++++
 Documentation/asciidoctor-extensions.rb |  7 ++++
 Documentation/config/sendemail.txt      | 56 ++++++++++++-------------
 Documentation/git-bugreport.txt         |  1 +
 Makefile                                |  9 ++++
 bugreport.c                             | 28 +++++++++++++
 generate-bugreport-config-safelist.sh   | 18 ++++++++
 8 files changed, 101 insertions(+), 28 deletions(-)
 create mode 100755 generate-bugreport-config-safelist.sh
Signature · 1 line
2.27.0.111.gc72c7da667-goog