Skip to content

Fixes for SJA1105 DSA tc-gate action

Vladimir Oltean netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4net: dsa: sja1105: move sja1105_compose_gating_subschedule at the topdrivers/net/dsa/sja1105/sja1105_vl.c+160 -1600 replies
2/4net: dsa: sja1105: unconditionally free old gating configdrivers/net/dsa/sja1105/sja1105_vl.c+2 -20 replies
3/4net: dsa: sja1105: recalculate gating subschedule after deleting tc-gate rulesdrivers/net/dsa/sja1105/sja1105_vl.c+8 -00 replies
4/4net: dsa: sja1105: fix tc-gate schedule with single elementdrivers/net/dsa/sja1105/sja1105_vl.c+1 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH net 0/4] Fixes for SJA1105 DSA tc-gate action

From: Vladimir Oltean <[email protected]>

This small series fixes 2 bugs in the tc-gate implementation:
1. The TAS state machine keeps getting rescheduled even after removing tc-gate actions on all ports.
2. tc-gate actions with only one gate control list entry are installed to hardware with an incorrect interval of zero, which makes the switch erroneously drop those packets (since the configuration is invalid).

To keep the code palatable, a forward-declaration was avoided by moving some code around in patch 1/4. I hope that isn't too much of an issue.

Vladimir Oltean (4):
net: dsa: sja1105: move sja1105_compose_gating_subschedule at the top
net: dsa: sja1105: unconditionally free old gating config
net: dsa: sja1105: recalculate gating subschedule after deleting
tc-gate rules
net: dsa: sja1105: fix tc-gate schedule with single element

 drivers/net/dsa/sja1105/sja1105_vl.c | 327 ++++++++++++++-------------
 1 file changed, 167 insertions(+), 160 deletions(-)
Signature · 1 line
2.25.1