Skip to content

HWPOISON: soft offline rework

[email protected] linux-arm-kernel linux-mm lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest12 patches 11 repliesIn review
  2. v516 patches 9 repliesSuperseded
  3. v315 patches 19 repliesSuperseded

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12mm,hwpoison: cleanup unused PageHuge() checkmm/memory-failure.c+1 -40 replies
2/12mm, hwpoison: remove recalculating hpagemm/memory-failure.c+1 -50 replies
3/12mm,hwpoison-inject: don't pin for hwpoison_filtermm/hwpoison-inject.c+5 -130 replies
4/12mm,hwpoison: Un-export get_hwpoison_page and make it staticinclude/linux/mm.h mm/memory-failure.c+1 -30 replies
5/12mm,hwpoison: Kill put_hwpoison_pageinclude/linux/mm.h mm/memory-failure.c+15 -160 replies
6/12mm,hwpoison: Unify THP handling for hard and soft offlinemm/memory-failure.c+22 -260 replies
7/12mm,hwpoison: Rework soft offline for free pagesinclude/linux/page-flags.h mm/memory-failure.c mm/page_alloc.c+81 -60 replies
8/12mm,hwpoison: Rework soft offline for in-use pagesinclude/linux/page-flags.h mm/memory-failure.c mm/migrate.c +1 more+19 -703 replies
9/12mm,hwpoison: Refactor soft_offline_huge_page and __soft_offline_pagemm/memory-failure.c+83 -1000 replies
10/12mm,hwpoison: Return 0 if the page is already poisoned in soft-offlinemm/madvise.c mm/memory-failure.c+2 -70 replies
11/12mm,hwpoison: introduce MF_MSG_UNSPLIT_THPinclude/linux/mm.h include/ras/ras_event.h mm/memory-failure.c+8 -10 replies
12/12mm,hwpoison: double-check page count in __get_any_page()mm/memory-failure.c+6 -01 reply

Reviews trailers per patch

3 of 12 patches have a Reviewed-by or Acked-by.

PatchMike KravetzOscar Salvador
1/12R-b
2/12R-b
3/12
4/12
5/12
6/12
7/12
8/12
9/12
10/12
11/12
12/12R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH v6 00/12] HWPOISON: soft offline rework

Hi,

This patchset is the latest version of soft offline rework patchset targetted for v5.9.

Since v5, I dropped some patches which tweak refcount handling in madvise_inject_error() to avoid the "unknown refcount page" error. I don't confirm the fix (that didn't reproduce with v5 in my environment), but this change surely call soft_offline_page() after holding refcount, so the error should not happen any more.

Dropped patches
- mm,madvise: call soft_offline_page() without MF_COUNT_INCREASED
- mm,madvise: Refactor madvise_inject_error
- mm,hwpoison: remove MF_COUNT_INCREASED
- mm,hwpoison: remove flag argument from soft offline functions

Thanks,
Naoya Horiguchi

Quoting cover letter of v5:
----
Main focus of this series is to stabilize soft offline. Historically soft offlined pages have suffered from racy conditions because PageHWPoison is used to a little too aggressively, which (directly or indirectly) invades other mm code which cares little about hwpoison. This results in unexpected behavior or kernel panic, which is very far from soft offline's "do not disturb userspace or other kernel component" policy.

Main point of this change set is to contain target page "via buddy allocator", where we first free the target page as we do for normal pages, and remove from buddy only when we confirm that it reaches free list. There is surely race window of page allocation, but that's fine because someone really want that page and the page is still working, so soft offline can happily give up.

v4 from Oscar tries to handle the race around reallocation, but that part seems still work in progress, so I decide to separate it for changes into v5.9. Thank you for your contribution, Oscar.

---
Previous versions:
v1: https://lore.kernel.org/linux-mm/[email protected]/
v2: https://lore.kernel.org/linux-mm/[email protected]/
v3: https://lore.kernel.org/linux-mm/[email protected]/
v4: https://lore.kernel.org/linux-mm/[email protected]/
v5: https://lore.kernel.org/linux-mm/[email protected]/T/#t
---
Summary:

Naoya Horiguchi (5):
mm,hwpoison: cleanup unused PageHuge() check mm, hwpoison: remove recalculating hpage mm,hwpoison-inject: don't pin for hwpoison_filter mm,hwpoison: introduce MF_MSG_UNSPLIT_THP mm,hwpoison: double-check page count in __get_any_page()

Oscar Salvador (7):
mm,hwpoison: Un-export get_hwpoison_page and make it static mm,hwpoison: Kill put_hwpoison_page
mm,hwpoison: Unify THP handling for hard and soft offline mm,hwpoison: Rework soft offline for free pages mm,hwpoison: Rework soft offline for in-use pages mm,hwpoison: Refactor soft_offline_huge_page and __soft_offline_page mm,hwpoison: Return 0 if the page is already poisoned in soft-offline

 include/linux/mm.h         |   3 +-
 include/linux/page-flags.h |   6 +-
 include/ras/ras_event.h    |   3 +
 mm/hwpoison-inject.c       |  18 +--
 mm/madvise.c               |   5 -
 mm/memory-failure.c        | 307 +++++++++++++++++++++------------------------
 mm/migrate.c               |  11 +-
 mm/page_alloc.c            |  60 +++++++--
 8 files changed, 203 insertions(+), 210 deletions(-)