Fix crash due to NBD export leak
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest2 patches 4 repliesIn review
- v25 patches 5 repliesSuperseded
- v14 patches 6 repliesSuperseded
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | nbd: make nbd_export_close_all() synchronousnbd/ | +8 | 0 replies | |
| 2/2 | iotests: test shutdown when bitmap is exported through NBDtests/ tests/ tests/ | +76 | 0 replies |
Reviews trailers per patch
All 2 patches have a Reviewed-by or Acked-by.
| Patch | Eric Blake |
|---|---|
| 1/2 | R-b |
| 2/2 | T-b R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v3 for-5.1 0/2] Fix crash due to NBD export leak
Hi all!
We've faced crash bug, which is reproducing on master branch as well. The case is described in 01, where fix is suggested.
New iotest in 02 crashes without that fix.
v3: resend for convenience, as all preparatory patches are merged. 01-02: add Eric's r-b and t-b marks
====
This is a crash-fix, so it would be good to fix in 5.1. Still neither Eric nor I are sure in patch 01: is AIO_WAIT_WHILE used correctly?
====
Side note: this AIO_WAIT_WHILE may be long, if nbd reconnect is enabled and connection failed recently. Still it's another story: I think we actually should disable reconnect in bdrv_close, before drain.
Vladimir Sementsov-Ogievskiy (2):
nbd: make nbd_export_close_all() synchronous
iotests: test shutdown when bitmap is exported through NBD
nbd/server.c | 8 +++++ tests/qemu-iotests/299 | 65 ++++++++++++++++++++++++++++++++++++++ tests/qemu-iotests/299.out | 10 ++++++ tests/qemu-iotests/group | 1 + 4 files changed, 84 insertions(+) create mode 100644 tests/qemu-iotests/299 create mode 100644 tests/qemu-iotests/299.out
Signature · 1 line
2.21.0