Skip to content

Drivers: hv: vmbus: vmbus_requestor data structure for VMBus hardening

Andres Beltran linux-hyperv linux-scsi lkml netdev 6 versions – Applied

Status from this message: Applied to hyperv-next. Thanks.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest3 patches 2 repliesApplied
  2. v53 patches 4 repliesSuperseded
  3. v43 patches 10 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v33 patches5 repliesSuperseded
v23 patches12 repliesSuperseded
v13 patches7 repliesSuperseded

Patches in v6 Applied

#Subject and filesSizeRepliesApplied
1/3Drivers: hv: vmbus: Add vmbus_requestor data structure for VMBus hardeningdrivers/hv/channel.c include/linux/hyperv.h+191 -02 replies
2/3scsi: storvsc: Use vmbus_requestor to generate transaction IDs for VMBus hardeningdrivers/scsi/storvsc_drv.c+74 -110 replies
3/3hv_netvsc: Use vmbus_requestor to generate transaction IDs for VMBus hardeningdrivers/net/hyperv/hyperv_net.h drivers/net/hyperv/netvsc.c drivers/net/hyperv/rndis_filter.c +1 more+80 -140 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchHaiyang ZhangAndrea ParriMichael KelleyMartin K. Petersen
1/3T-b R-b
2/3T-b R-b A-b
3/3R-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v6 thread

Cover letter [PATCH v6 0/3] Drivers: hv: vmbus: vmbus_requestor data structure for VMBus hardening

Currently, VMbus drivers use pointers into guest memory as request IDs for interactions with Hyper-V. To be more robust in the face of errors or malicious behavior from a compromised Hyper-V, avoid exposing guest memory addresses to Hyper-V. Also avoid Hyper-V giving back a bad request ID that is then treated as the address of a guest data structure with no validation. Instead, encapsulate these memory addresses and provide small integers as request IDs.

The first patch creates the definitions for the data structure, provides helper methods to generate new IDs and retrieve data, and allocates/frees the memory needed for vmbus_requestor.

The second and third patches make use of vmbus_requestor to send request IDs to Hyper-V in storvsc and netvsc respectively.

Thanks.
Andres Beltran

Cc James E.J. Bottomley <[email protected]>
Cc Martin K. Petersen <[email protected]>
Cc David S. Miller <[email protected]>

Andres Beltran (3):
Drivers: hv: vmbus: Add vmbus_requestor data structure for VMBus
hardening
scsi: storvsc: Use vmbus_requestor to generate transaction IDs for
VMBus hardening
hv_netvsc: Use vmbus_requestor to generate transaction IDs for VMBus
hardening

 drivers/hv/channel.c              | 170 ++++++++++++++++++++++++++++++
 drivers/net/hyperv/hyperv_net.h   |  13 +++
 drivers/net/hyperv/netvsc.c       |  79 +++++++++++---
 drivers/net/hyperv/rndis_filter.c |   1 +
 drivers/scsi/storvsc_drv.c        |  85 +++++++++++++--
 include/linux/hyperv.h            |  22 ++++
 6 files changed, 345 insertions(+), 25 deletions(-)
Signature · 1 line
2.25.1