Skip to content

net: phy: relax PHY and MDIO reset handling

Bartosz Golaszewski lkml netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 4 repliesIn review

Changes from the previous version from the cover letter

- order forward declarations in patch 4 alphabetically
- collect review tags

[1] https://lkml.org/lkml/2020/6/22/253

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6net: phy: arrange headers in mdio_bus.c alphabeticallydrivers/net/phy/mdio_bus.c+16 -160 replies
2/6net: phy: arrange headers in mdio_device.c alphabeticallydrivers/net/phy/mdio_device.c+1 -10 replies
3/6net: phy: arrange headers in phy_device.c alphabeticallydrivers/net/phy/phy_device.c+14 -140 replies
4/6net: mdio: add a forward declaration for reset_control to mdio.hinclude/linux/mdio.h+1 -01 reply
5/6net: phy: reset the PHY even if probe() is not implementeddrivers/net/phy/phy_device.c+12 -111 reply
6/6net: phy: mdio: reset MDIO devices even if probe() is not implementeddrivers/net/phy/mdio_device.c+6 -71 reply

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchAndrew LunnFlorian Fainelli
1/6R-b R-b
2/6R-b R-b
3/6R-b R-b
4/6R-b R-b
5/6R-b R-b
6/6R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/6] net: phy: relax PHY and MDIO reset handling

From: Bartosz Golaszewski <[email protected]>

Previously these patches were submitted as part of a larger series[1] but since the approach in it will have to be reworked I'm resending the ones that were non-controversial and have been reviewed for upstream.

Florian suggested a better solution for managing multiple resets. While I will definitely try to implement something at the driver model's bus level (together with regulator support), the 'resets' and 'reset-gpios' DT property is a stable ABI defined in mdio.yaml so improving its support is in order as we'll have to stick with it anyway. Current implementation contains an unnecessary limitation where drivers without probe() can't define resets.

Changes from the previous version:
- order forward declarations in patch 4 alphabetically
- collect review tags

[1] https://lkml.org/lkml/2020/6/22/253

Bartosz Golaszewski (6):
net: phy: arrange headers in mdio_bus.c alphabetically
net: phy: arrange headers in mdio_device.c alphabetically
net: phy: arrange headers in phy_device.c alphabetically
net: mdio: add a forward declaration for reset_control to mdio.h
net: phy: reset the PHY even if probe() is not implemented
net: phy: mdio: reset MDIO devices even if probe() is not implemented

 drivers/net/phy/mdio_bus.c    | 32 +++++++++++-----------
 drivers/net/phy/mdio_device.c | 15 +++++------
 drivers/net/phy/phy_device.c  | 51 ++++++++++++++++++-----------------
 include/linux/mdio.h          |  1 +
 4 files changed, 50 insertions(+), 49 deletions(-)
Signature · 1 line
2.26.1