Skip to content

serial: qcom_geni_serial: Use the FIFOs properly for console

Douglas Anderson linux-arm-msm linux-serial lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 9 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2serial: qcom_geni_serial: Make kgdb work even if UART isn't consoledrivers/tty/serial/qcom_geni_serial.c+55 -255 replies
2/2serial: qcom_geni_serial: Always use 4 bytes per TX FIFO worddrivers/tty/serial/qcom_geni_serial.c+37 -203 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchGreg Kroah-HartmanEvan Green
SeriesA-b
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] serial: qcom_geni_serial: Use the FIFOs properly for console

This series of two patches gets rid of some ugly hacks that were in the qcom_geni_serial driver around dealing with a port that was used for console output and dealing with a port that was being used for kgdb.

While the character reading/writing code is now slightly more complex, it's better to be consistently configuring the serial port the same way and doing so avoids some corner cases where the old hacks weren't always catching properly.

This change is slightly larger than it needs to be because I was trying not to use global variables in the read/write functions. Unfortunately the functions were sometimes called earlycon which didn't have any "private_data" pointer set. I've tried to do the minimal change here to have some shared "private_data" that's always present, but longer term it wouldn't hurt to see if we could unify more.

Greg / Andy / Bjorn:

This series of patches is atop the current Qualcomm tree to avoid conflicts. Assuming it looks OK, presumably the best way for it to land would be to get an Ack from Greg and then Bjorn or Andy could land it.

Douglas Anderson (2):
serial: qcom_geni_serial: Make kgdb work even if UART isn't console
serial: qcom_geni_serial: Always use 4 bytes per TX FIFO word

 drivers/tty/serial/qcom_geni_serial.c | 129 ++++++++++++++++++--------
 1 file changed, 88 insertions(+), 41 deletions(-)
Signature · 1 line
2.27.0.212.ge8ba1cc988-goog