tcp: improve delivered counts in SCM_TSTAMP_ACK
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest4 patches 2 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | tcp: stamp SCM_TSTAMP_ACK later in tcp_clean_rtx_queue()net/ | +2 | 1 reply | |
| 2/4 | tcp: add ece_ack flag to reno sack functionsnet/ | +12 | 0 replies | |
| 3/4 | tcp: count sacked packets in tcp_sacktag_statenet/ | +4 | 0 replies | |
| 4/4 | tcp: update delivered_ce with deliverednet/ | +21 | 0 replies |
Reviews trailers per patch
All 4 patches have a Reviewed-by or Acked-by.
| Patch | Eric Dumazet | Neal Cardwell | Soheil Hassas Yeganeh |
|---|---|---|---|
| 1/4 | A-b | A-b | A-b |
| 2/4 | A-b | A-b | A-b |
| 3/4 | A-b | A-b | A-b |
| 4/4 | A-b | A-b | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH net-next 0/4] tcp: improve delivered counts in SCM_TSTAMP_ACK
Currently delivered and delivered_ce in OPT_STATS of SCM_TSTAMP_ACK do not fully reflect the current ack being timestamped. Also they are not in sync as the delivered count includes packets being sacked and some of cumulatively acked but delivered_ce includes none.
This patch series updates tp->delivered and tp->delivered_ce together to keep them in sync. It also moves generating SCM_TSTAMP_ACK to later in tcp_clean_rtx_queue() to reflect packets being cumulatively acked up until the current skb for sack-enabled connections.
Yousuk Seung (4):
tcp: stamp SCM_TSTAMP_ACK later in tcp_clean_rtx_queue()
tcp: add ece_ack flag to reno sack functions
tcp: count sacked packets in tcp_sacktag_state
tcp: update delivered_ce with delivered
net/ipv4/tcp_input.c | 59 +++++++++++++++++++++++++++++--------------- 1 file changed, 39 insertions(+), 20 deletions(-)
Signature · 1 line
2.27.0.212.ge8ba1cc988-goog