RFC handle USB endpoint race condition
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest2 patches 12 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | Bluetooth: queue ACL packets if no handle is foundinclude/ net/ net/ | +88 | 7 replies | |
| 2/2 | Bluetooth: queue L2CAP conn req if encryption is neededinclude/ include/ net/ +1 more | +91 | 5 replies |
Reviews trailers per patch
All 2 patches have a Reviewed-by or Acked-by.
| Patch | Abhishek Pandit-Subedi |
|---|---|
| 1/2 | R-b |
| 2/2 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [RFC PATCH v1 0/2] handle USB endpoint race condition
From: Archie Pusaka <[email protected]>
On platforms with USB transport, events and data are transferred via different endpoints. This could potentially cause ordering problems, where the order of processed information is different than the actual order.
One such a case is we receive a ACL packet before receiving the connect complete event. This could be frequently observed on ChromeOS auto test setup.
Quoted 1 line
ACL Data RX: Handle 256 flags
0x02dlen 12 #6 [hci0] 9.314240
L2CAP: Connection Request (0x02) ident 1 len 4
PSM: 1 (0x0001)
Source CID: 1536Quoted 1 line
HCI Event: Connect Complete (
0x03) plen 11 #7 [hci0] 9.333236
Status: Success (0x00)
Handle: 256
Address: 70:BF:92:CF:95:B7 (OUI 70-BF-92)
Link type: ACL (0x01)
Encryption: Disabled (0x00)If this happens, we will simply discard the ACL packet, since no corresponding handle is registered yet. The situation where the ACL packet is not replied by us is handled differently by each peripheral:
some will resend the ACL packet (which will be successful, since the handle can be found now), but some will get upset and disconnect.
To prevent this from happening, we propose to introduce a queue. So, instead of discarding those packets without handle, we put them in a queue. Then, we will process this queue when we receive a connect completion event for the matching handle. The queued packets will be cleared if after 2 seconds we still don't receive the corresponding connect complete event.
Similarly, there is a chance that the incoming L2CAP connection request comes before HCI encryption change event. When this happens, the incoming connection will be refused.
Quoted 1 line
ACL Data RX: Handle 256 flags
0x02dlen 12 #46 [hci0] 9.275297
L2CAP: Connection Request (0x02) ident 4 len 4
PSM: 3 (0x0003)
Source CID: 256
< ACL Data TX: Handle 256 flags 0x00 dlen 16 #47 [hci0] 9.275393
L2CAP: Connection Response (0x03) ident 4 len 8
Destination CID: 0
Source CID: 256
Result: Connection refused - security block (0x0003)
Status: No further information available (0x0000)Quoted 1 line
HCI Event: Encryption Change (
0x08) plen 4 #51 [hci0] 9.314109
Status: Success (0x00)
Handle: 256
Encryption: Enabled with E0 (0x01)We propose to handle this case with a similar solution: queuing the L2CAP connection request until we receive HCI encryption change.
The proposed patch is tested with a special Intel firmware which allows us to purposely delay the "connect complete" event.
We plan to merge this change to ChromeOS auto test setup to see whether this could fix the problem there, but we also would like to have your input on this in the meantime.
Thanks,
Archie
Archie Pusaka (2):
Bluetooth: queue ACL packets if no handle is found
Bluetooth: queue L2CAP conn req if encryption is needed
include/net/bluetooth/bluetooth.h | 6 +++ include/net/bluetooth/hci_core.h | 8 +++ include/net/bluetooth/l2cap.h | 6 +++ net/bluetooth/hci_core.c | 84 ++++++++++++++++++++++++++--- net/bluetooth/hci_event.c | 5 ++ net/bluetooth/l2cap_core.c | 87 +++++++++++++++++++++++++++---- 6 files changed, 179 insertions(+), 17 deletions(-)
Signature · 1 line
2.27.0.212.ge8ba1cc988-goog