Skip to content

fs/minix: fix syzbot bugs and set s_maxbytes

Eric Biggers linux-fsdevel lkml stable 1 version Applied

Status from this message: [merged] fs-minix-remove-expected-error-message-in-block_to_path.patch removed from -mm tree

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 3 repliesApplied 6/6

Patches in v1 All 6 applied

#Subject and filesSizeRepliesApplied
1/6fs/minix: check return value of sb_getblk()fs/minix/itree_common.c+7 -12 repliesApplied
2/6fs/minix: don't allow getting deleted inodesfs/minix/inode.c+14 -00 repliesApplied
3/6fs/minix: reject too-large maximum file sizefs/minix/inode.c+20 -20 repliesApplied
4/6fs/minix: set s_maxbytes correctlyfs/minix/inode.c fs/minix/itree_v1.c fs/minix/itree_v2.c +1 more+9 -90 repliesApplied
5/6fs/minix: fix block limit check for V1 filesystemsfs/minix/itree_v1.c+1 -10 repliesApplied
6/6fs/minix: remove expected error message in block_to_path()fs/minix/itree_v1.c fs/minix/itree_v2.c+12 -120 repliesApplied

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/6] fs/minix: fix syzbot bugs and set s_maxbytes

This series fixes all syzbot bugs in the minix filesystem:

	KASAN: null-ptr-deref Write in get_block
	KASAN: use-after-free Write in get_block
	KASAN: use-after-free Read in get_block
	WARNING in inc_nlink
	KMSAN: uninit-value in get_block
	WARNING in drop_nlink

It also fixes the minix filesystem to set s_maxbytes correctly, so that userspace sees the correct behavior when exceeding the max file size.

Al or Andrew: one of you will need to take these patches, since no one is maintaining this filesystem.

Eric Biggers (6):
fs/minix: check return value of sb_getblk() fs/minix: don't allow getting deleted inodes fs/minix: reject too-large maximum file size fs/minix: set s_maxbytes correctly
fs/minix: fix block limit check for V1 filesystems fs/minix: remove expected error message in block_to_path()

 fs/minix/inode.c        | 42 +++++++++++++++++++++++++++++++++++++----
 fs/minix/itree_common.c |  8 +++++++-
 fs/minix/itree_v1.c     | 12 ++++++------
 fs/minix/itree_v2.c     | 13 ++++++-------
 fs/minix/minix.h        |  1 -
 5 files changed, 57 insertions(+), 19 deletions(-)
Signature · 1 line
2.27.0