Skip to content

always use netdev_tx_t for xmit()'s return type

Luc Van Oostenryck linux-usb lkml netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest15 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/15cail,hsi: fix cfhsi_xmit()'s return typedrivers/net/caif/caif_hsi.c+3 -30 replies
2/15caif: fix caif_xmit()'s return typedrivers/net/caif/caif_serial.c+1 -10 replies
3/15caif: fix cfspi_xmit()'s return typedrivers/net/caif/caif_spi.c+2 -20 replies
4/15caif: fix cfv_netdev_tx()'s return typedrivers/net/caif/caif_virtio.c+1 -10 replies
5/15net: aquantia: fix aq_ndev_start_xmit()'s return typedrivers/net/ethernet/aquantia/atlantic/aq_main.c+1 -10 replies
6/15net: arc_emac: fix arc_emac_tx()'s return typedrivers/net/ethernet/arc/emac_main.c+1 -10 replies
7/15net: nb8800: fix nb8800_xmit()'s return typedrivers/net/ethernet/aurora/nb8800.c+1 -10 replies
8/15net: nfp: fix nfp_net_tx()'s return typedrivers/net/ethernet/netronome/nfp/nfp_net_common.c+1 -10 replies
9/15net: pch_gbe: fix pch_gbe_xmit_frame()'s return typedrivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c+1 -10 replies
10/15net: dwc-xlgmac: fix xlgmac_xmit()'s return typedrivers/net/ethernet/synopsys/dwc-xlgmac-net.c+1 -10 replies
11/15net: plip: fix plip_tx_packet()'s return typedrivers/net/plip/plip.c+2 -20 replies
12/15usbnet: ipheth: fix ipheth_tx()'s return typedrivers/net/usb/ipheth.c+1 -10 replies
13/15net/hsr: fix hsr_dev_xmit()'s return typenet/hsr/hsr_device.c+1 -10 replies
14/15l2tp: fix l2tp_eth_dev_xmit()'s return typenet/l2tp/l2tp_eth.c+1 -10 replies
15/15cxgb4vf: fix t4vf_eth_xmit()'s return typedrivers/net/ethernet/chelsio/cxgb4vf/adapter.h drivers/net/ethernet/chelsio/cxgb4vf/sge.c+2 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/15] always use netdev_tx_t for xmit()'s return type

The ndo_start_xmit() methods should return a 'netdev_tx_t', not an int, and so should return NETDEV_TX_OK, not 0.
The patches in the series fix most of the remaning drivers and subsystems (those included in allyesconfig on x86).

Luc Van Oostenryck (15):
cail,hsi: fix cfhsi_xmit()'s return type
caif: fix caif_xmit()'s return type
caif: fix cfspi_xmit()'s return type
caif: fix cfv_netdev_tx()'s return type
net: aquantia: fix aq_ndev_start_xmit()'s return type
net: arc_emac: fix arc_emac_tx()'s return type
net: nb8800: fix nb8800_xmit()'s return type
net: nfp: fix nfp_net_tx()'s return type
net: pch_gbe: fix pch_gbe_xmit_frame()'s return type
net: dwc-xlgmac: fix xlgmac_xmit()'s return type
net: plip: fix plip_tx_packet()'s return type
usbnet: ipheth: fix ipheth_tx()'s return type net/hsr: fix hsr_dev_xmit()'s return type
l2tp: fix l2tp_eth_dev_xmit()'s return type
cxgb4vf: fix t4vf_eth_xmit()'s return type

 drivers/net/caif/caif_hsi.c                          | 6 +++---
 drivers/net/caif/caif_serial.c                       | 2 +-
 drivers/net/caif/caif_spi.c                          | 4 ++--
 drivers/net/caif/caif_virtio.c                       | 2 +-
 drivers/net/ethernet/aquantia/atlantic/aq_main.c     | 2 +-
 drivers/net/ethernet/arc/emac_main.c                 | 2 +-
 drivers/net/ethernet/aurora/nb8800.c                 | 2 +-
 drivers/net/ethernet/chelsio/cxgb4vf/adapter.h       | 2 +-
 drivers/net/ethernet/chelsio/cxgb4vf/sge.c           | 2 +-
 drivers/net/ethernet/netronome/nfp/nfp_net_common.c  | 2 +-
 drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c | 2 +-
 drivers/net/ethernet/synopsys/dwc-xlgmac-net.c       | 2 +-
 drivers/net/plip/plip.c                              | 4 ++--
 drivers/net/usb/ipheth.c                             | 2 +-
 net/hsr/hsr_device.c                                 | 2 +-
 net/l2tp/l2tp_eth.c                                  | 2 +-
 16 files changed, 20 insertions(+), 20 deletions(-)
Signature · 1 line
2.27.0