Skip to content

hw/arm/virt-acpi-build: Only expose flash on older machine types

Andrew Jones qemu-arm qemu-devel 1 version Applied

Status from this message: Applied to target-arm.next, thanks.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 20 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/4tests/acpi: remove stale allowed tablestests/qtest/bios-tables-test-allowed-diff.h+0 -181 reply
2/4tests/acpi: virt: allow DSDT acpi table changestests/qtest/bios-tables-test-allowed-diff.h+3 -00 replies
3/4hw/arm/virt-acpi-build: Only expose flash on older machine typeshw/arm/virt-acpi-build.c hw/arm/virt.c include/hw/arm/virt.h+8 -115 replies
4/4tests/acpi: virt: update golden masters for DSDTtests/data/acpi/virt/DSDT tests/data/acpi/virt/DSDT.memhp tests/data/acpi/virt/DSDT.numamem +1 more+0 -31 reply

Reviews trailers per patch

2 of 4 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchPhilippe Mathieu-DaudéMichael S. TsirkinLaszlo ErsekEric Auger
SeriesR-b R-b
1/4
2/4
3/4R-b R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v1 thread

Cover letter [PATCH 0/4] hw/arm/virt-acpi-build: Only expose flash on older machine types

The flash device is exclusively for the host-controlled firmware, so we should not expose it to the OS. Exposing it risks the OS messing with it, which could break firmware runtime services and surprise the OS when all its changes disappear after reboot.

This change was suggested by Ard and Laszlo.

Patch 3/4 is the meat. The other patches deal with updating qtest.

Thanks,
drew

Andrew Jones (4):
tests/acpi: remove stale allowed tables
tests/acpi: virt: allow DSDT acpi table changes hw/arm/virt-acpi-build: Only expose flash on older machine types tests/acpi: virt: update golden masters for DSDT

 hw/arm/virt-acpi-build.c                    |   5 ++++-
 hw/arm/virt.c                               |   3 +++
 include/hw/arm/virt.h                       |   1 +
 tests/data/acpi/virt/DSDT                   | Bin 5307 -> 5205 bytes
 tests/data/acpi/virt/DSDT.memhp             | Bin 6668 -> 6566 bytes
 tests/data/acpi/virt/DSDT.numamem           | Bin 5307 -> 5205 bytes
 tests/qtest/bios-tables-test-allowed-diff.h |  18 ------------------
 7 files changed, 8 insertions(+), 19 deletions(-)
Signature · 1 line
2.25.4