Skip to content

net: ipa: endpoint configuration updates

Alex Elder lkml netdev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest5 patches 1 replyIn review
  2. v15 patches 7 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5net: ipa: head-of-line block registers are RX onlydrivers/net/ipa/ipa_endpoint.c+1 -10 replies
2/5net: ipa: metadata_mask register is RX onlydrivers/net/ipa/ipa_endpoint.c+2 -20 replies
3/5net: ipa: mode register is TX onlydrivers/net/ipa/ipa_endpoint.c+3 -30 replies
4/5net: ipa: clarify endpoint register macro constraintsdrivers/net/ipa/ipa_reg.h+25 -180 replies
5/5net: ipa: HOL_BLOCK_EN_FMASK is a 1-bit maskdrivers/net/ipa/ipa_endpoint.c+1 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH net-next v2 0/5] net: ipa: endpoint configuration updates

This series updates code that configures IPA endpoints. The changes made mainly affect access to registers that are valid only for RX, or only for TX endpoints.

The first three patches avoid writing endpoint registers if they are not defined to be valid. The fourth patch slightly modifies the parameters for the offset macros used for these endpoint registers, to make it explicit when only some endpoints are valid.

The last patch just tweaks one line of code so it uses a convention used everywhere else in the driver.

Version 2 of this series eliminates some of the "assert()" comments that Jakub inquired about. The ones removed will actually go away in an upcoming (not-yet-posted) patch series anyway.

-Alex

Alex Elder (5):
net: ipa: head-of-line block registers are RX only
net: ipa: metadata_mask register is RX only
net: ipa: mode register is TX only
net: ipa: clarify endpoint register macro constraints
net: ipa: HOL_BLOCK_EN_FMASK is a 1-bit mask

 drivers/net/ipa/ipa_endpoint.c | 14 +++++------
 drivers/net/ipa/ipa_reg.h      | 43 ++++++++++++++++++++--------------
 2 files changed, 32 insertions(+), 25 deletions(-)
Signature · 1 line
2.25.1