Skip to content

hw/block/nvme: dulbe and dsm support

Klaus Jensen qemu-devel 8 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v8 Latest5 patches 12 repliesIn review
  2. v73 patches 1 replySuperseded
  3. v63 patches 2 repliesSuperseded
Earlier versions · 5
VersionPostedPatchesRepliesStatus
v52 patches4 repliesSuperseded
v42 patches4 repliesSuperseded
v32 patches5 repliesSuperseded
v21 patch0 repliesSuperseded
v11 patch0 repliesSuperseded

Changes in v8 from the cover letter

- Move req->opaque clearing to nvme_req_clear.
- Add two preparation/cleanup patches.

Patches in v8 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5hw/block/nvme: remove superfluous NvmeCtrl parameterhw/block/nvme.c+4 -41 reply
2/5hw/block/nvme: pull aio error handlinghw/block/nvme.c+36 -255 replies
3/5hw/block/nvme: add dulbe supporthw/block/nvme-ns.c hw/block/nvme-ns.h hw/block/nvme.c +2 more+107 -53 replies
4/5nvme: add namespace I/O optimization fields to shared headerinclude/block/nvme.h+6 -11 reply
5/5hw/block/nvme: add the dataset management commandhw/block/nvme-ns.c hw/block/nvme.c hw/block/nvme.h+125 -51 reply

Reviews trailers per patch

4 of 5 patches have a Reviewed-by or Acked-by.

PatchStefan HajnocziMinwoo ImKeith Busch
1/5R-b
2/5
3/5R-b
4/5R-b R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v8 thread

Cover letter [PATCH v8 0/5] hw/block/nvme: dulbe and dsm support

From: Klaus Jensen <[email protected]>

This adds support for the Deallocated or Unwritten Logical Block error recovery feature as well as the Dataset Management command.

v8:
- Move req->opaque clearing to nvme_req_clear.
- Add two preparation/cleanup patches.

v7:
- Handle negative return value from bdrv_block_status.
- bdrv_get_info may not be supported on all block drivers, so do not consider it a fatal error.

v6:
- Skip the allocation of the discards integer and just use the opaque value directly (Philippe)
- Split changes to include/block/nvme.h into a separate patch (Philippe)
- Clean up some convoluted checks on the discards value (Philippe)
- Use unambiguous units in the commit messages (Philippe)
- Stack allocate the range array (Keith)

v5:
- Restore status code from callback (Keith)

v4:
- Removed mixed declaration and code (Keith)
- Set NPDG and NPDA and account for the blockdev cluster size.

Klaus Jensen (5):
hw/block/nvme: remove superfluous NvmeCtrl parameter hw/block/nvme: pull aio error handling hw/block/nvme: add dulbe support
nvme: add namespace I/O optimization fields to shared header hw/block/nvme: add the dataset management command

 hw/block/nvme-ns.h    |   4 +
 hw/block/nvme.h       |   2 +
 include/block/nvme.h  |  12 +-
 hw/block/nvme-ns.c    |  34 +++++-
 hw/block/nvme.c       | 258 ++++++++++++++++++++++++++++++++++++------
 hw/block/trace-events |   4 +
 6 files changed, 276 insertions(+), 38 deletions(-)
Signature · 1 line
2.29.2