Skip to content

hw/block/nvme: bump to v1.3

Klaus Jensen qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest18 patches 41 repliesIn review
  2. v218 patches 23 repliesSuperseded
  3. v13 patches 1 replySuperseded

Changes in v3 from the cover letter

* hw/block/nvme: additional tracing
- Reverse logic in nvme_cid(). (Philippe)
- Move nvme_cid() and nvme_sqid() to source file. (Philippe)
* hw/block/nvme: fix missing endian conversion
- Move this patch to very early in the series and fix the bug properly as suggested by Philippe. Then let the change trickle down through the series. (Philippe)
* hw/block/nvme: add remaining mandatory controller parameters
- Move the nvme_feature_{support,default} arrays to the source file. (Philippe)
- Add a NVME_FID_MAX constant. (Philippe)
* hw/block/nvme: support the get/set features select and save fields
- Move the nvme_feature_cap array to the source file. (Philippe)
* hw/block/nvme: reject invalid nsid values in active namespace id list
- Rework the condition and add a comment and reference to the spec. (Philippe)
* hw/block/nvme: provide the mandatory subnqn field
- Change to use strpadcpy(). (Philippe)

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/18hw/block/nvme: bump spec data structures to v1.3block/nvme.c hw/block/nvme.c include/block/nvme.h+154 -324 replies
2/18hw/block/nvme: fix missing endian conversionhw/block/nvme.c+3 -33 replies
3/18hw/block/nvme: additional tracinghw/block/nvme.c hw/block/trace-events+44 -23 replies
4/18hw/block/nvme: add support for the abort commandhw/block/nvme.c+27 -00 replies
5/18hw/block/nvme: add temperature threshold featurehw/block/nvme.c hw/block/nvme.h include/block/nvme.h+53 -11 reply
6/18hw/block/nvme: mark fw slot 1 as read-onlyhw/block/nvme.c include/block/nvme.h+6 -11 reply
7/18hw/block/nvme: add support for the get log page commandhw/block/nvme.c hw/block/nvme.h hw/block/trace-events +1 more+149 -39 replies
8/18hw/block/nvme: add support for the asynchronous event request commandhw/block/nvme.c hw/block/nvme.h hw/block/trace-events +1 more+198 -95 replies
9/18hw/block/nvme: move NvmeFeatureVal into hw/block/nvme.hhw/block/nvme.h include/block/nvme.h+8 -171 reply
10/18hw/block/nvme: flush write cache when disabledhw/block/nvme.c+4 -01 reply
11/18hw/block/nvme: add remaining mandatory controller parametershw/block/nvme.c hw/block/trace-events include/block/nvme.h+61 -71 reply
12/18hw/block/nvme: support the get/set features select and save fieldshw/block/nvme.c hw/block/trace-events include/block/nvme.h+119 -154 replies
13/18hw/block/nvme: make sure ncqr and nsqr is validhw/block/nvme.c+8 -00 replies
14/18hw/block/nvme: support identify namespace descriptor listhw/block/nvme.c hw/block/trace-events+42 -01 reply
15/18hw/block/nvme: reject invalid nsid values in active namespace id listhw/block/nvme.c+10 -03 replies
16/18hw/block/nvme: enforce valid queue creation sequencehw/block/nvme.c hw/block/nvme.h+13 -00 replies
17/18hw/block/nvme: provide the mandatory subnqn fieldhw/block/nvme.c+5 -03 replies
18/18hw/block/nvme: bump supported version to v1.3hw/block/nvme.c+3 -10 replies

Reviews trailers per patch

All 18 patches have a Reviewed-by or Acked-by.

PatchKeith BuschMaxim LevitskyDmitry FomichevFam ZhengPhilippe Mathieu-Daudé
1/18R-b R-b A-b
2/18R-b R-b R-b
3/18R-b R-b R-b
4/18A-b R-b R-b
5/18A-b R-b R-b
6/18R-b R-b
7/18A-b R-b R-b
8/18A-b R-b R-b
9/18R-b R-b
10/18R-b R-b
11/18R-b R-b
12/18R-b R-b
13/18A-b R-b R-b
14/18R-b R-b
15/18R-b R-b R-b
16/18R-b R-b
17/18R-b R-b R-b
18/18R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v3 thread

Cover letter [PATCH v3 00/18] hw/block/nvme: bump to v1.3

From: Klaus Jensen <[email protected]>

This adds mandatory features of NVM Express v1.3 to the emulated NVMe device.

v3:
* hw/block/nvme: additional tracing
- Reverse logic in nvme_cid(). (Philippe)
- Move nvme_cid() and nvme_sqid() to source file. (Philippe)
* hw/block/nvme: fix missing endian conversion
- Move this patch to very early in the series and fix the bug properly as suggested by Philippe. Then let the change trickle down through the series. (Philippe)
* hw/block/nvme: add remaining mandatory controller parameters
- Move the nvme_feature_{support,default} arrays to the source file. (Philippe)
- Add a NVME_FID_MAX constant. (Philippe)
* hw/block/nvme: support the get/set features select and save fields
- Move the nvme_feature_cap array to the source file. (Philippe)
* hw/block/nvme: reject invalid nsid values in active namespace id list
- Rework the condition and add a comment and reference to the spec. (Philippe)
* hw/block/nvme: provide the mandatory subnqn field
- Change to use strpadcpy(). (Philippe)

Had to clear some R-b's due to functional changes.

Missing review: 2, 3, 7, 12, 16, 17

v2:
* hw/block/nvme: bump spec data structures to v1.3
- Shorten some constants. (Dmitry)
* hw/block/nvme: add temperature threshold feature
- Remove unused temp_thresh member. (Dmitry)
* hw/block/nvme: add support for the get log page command
- Change the temperature field in the NvmeSmartLog struct to be an uint16_t and handle wierd alignment by adding QEMU_PACKED to the struct. (Dmitry)
* hw/block/nvme: add remaining mandatory controller parameters
- Fix spelling. (Dmitry)
* hw/block/nvme: support the get/set features select and save fields
- Fix bad logic causing temperature thresholds to always report defaults. (Dmitry)
* hw/block/nvme: reject invalid nsid values in active namespace id list
- Added patch; reject the 0xfffffffe and 0xffffffff nsid values.

$ git-backport-diff -u for-master/bump-to-v1.3-v2 -r upstream/master... -S
Key:
[----] : patches are identical
[####] : number of functional differences between upstream/downstream patch
[down] : patch is downstream-only
The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively

001/18:[----] [--] 'hw/block/nvme: bump spec data structures to v1.3' 002/18:[0008] [FC] 'hw/block/nvme: fix missing endian conversion' 003/18:[0028] [FC] 'hw/block/nvme: additional tracing'
004/18:[----] [--] 'hw/block/nvme: add support for the abort command' 005/18:[0004] [FC] 'hw/block/nvme: add temperature threshold feature' 006/18:[----] [--] 'hw/block/nvme: mark fw slot 1 as read-only' 007/18:[----] [--] 'hw/block/nvme: add support for the get log page command' 008/18:[0002] [FC] 'hw/block/nvme: add support for the asynchronous event request command' 009/18:[----] [--] 'hw/block/nvme: move NvmeFeatureVal into hw/block/nvme.h' 010/18:[----] [--] 'hw/block/nvme: flush write cache when disabled' 011/18:[0044] [FC] 'hw/block/nvme: add remaining mandatory controller parameters' 012/18:[0024] [FC] 'hw/block/nvme: support the get/set features select and save fields' 013/18:[----] [--] 'hw/block/nvme: make sure ncqr and nsqr is valid' 014/18:[----] [--] 'hw/block/nvme: support identify namespace descriptor list' 015/18:[0008] [FC] 'hw/block/nvme: reject invalid nsid values in active namespace id list' 016/18:[----] [--] 'hw/block/nvme: enforce valid queue creation sequence' 017/18:[0006] [FC] 'hw/block/nvme: provide the mandatory subnqn field' 018/18:[----] [--] 'hw/block/nvme: bump supported version to v1.3'

Klaus Jensen (18):
hw/block/nvme: bump spec data structures to v1.3 hw/block/nvme: fix missing endian conversion hw/block/nvme: additional tracing
hw/block/nvme: add support for the abort command hw/block/nvme: add temperature threshold feature hw/block/nvme: mark fw slot 1 as read-only
hw/block/nvme: add support for the get log page command hw/block/nvme: add support for the asynchronous event request command hw/block/nvme: move NvmeFeatureVal into hw/block/nvme.h hw/block/nvme: flush write cache when disabled hw/block/nvme: add remaining mandatory controller parameters hw/block/nvme: support the get/set features select and save fields hw/block/nvme: make sure ncqr and nsqr is valid hw/block/nvme: support identify namespace descriptor list hw/block/nvme: reject invalid nsid values in active namespace id list hw/block/nvme: enforce valid queue creation sequence hw/block/nvme: provide the mandatory subnqn field hw/block/nvme: bump supported version to v1.3

 block/nvme.c          |  18 +-
 hw/block/nvme.c       | 676 ++++++++++++++++++++++++++++++++++++++++--
 hw/block/nvme.h       |  22 +-
 hw/block/trace-events |  27 +-
 include/block/nvme.h  | 225 +++++++++++---
 5 files changed, 892 insertions(+), 76 deletions(-)
Signature · 1 line
2.27.0