Skip to content

VSX 32-byte vector paired load/store instructions

Balamuruhan S linuxppc-dev 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 1 replyIn review
  2. v24 patches 2 repliesSuperseded
  3. v14 patches 0 repliesSuperseded

Changes in v3 from the cover letter

-------------
Worked on review comments and suggestions from Ravi and Naveen,

* Fix the do_vsx_load() to handle vsx instructions if MSR_FP/MSR_VEC cleared in exception conditions and it reaches to read/write to thread_struct member fp_state/vr_state respectively.
* Fix wrongly used __vector128 v[2] in struct vsx_reg as it should hold a single vsx register size.
* Remove unnecessary VSX_CHECK_VEC flag set and condition to check VSX_LDLEFT that is not applicable for these vsx instructions.
* Fix comments in emulate_vsx_load() that were misleading.
* Rebased on latest powerpc next branch.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4powerpc/sstep: support new VSX vector paired storage access instructionsarch/powerpc/lib/sstep.c+45 -00 replies
2/4powerpc/sstep: support emulation for vsx vector paired storage access instructionsarch/powerpc/lib/sstep.c+60 -171 reply
3/4powerpc ppc-opcode: add encoding macros for vsx vector paired instructionsarch/powerpc/include/asm/ppc-opcode.h+17 -00 replies
4/4powerpc sstep: add testcases for vsx load/store instructionsarch/powerpc/lib/test_emulate_step.c+252 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/4] VSX 32-byte vector paired load/store instructions

VSX vector paired instructions operates with octword (32-byte) operand for loads and stores between storage and a pair of two sequential Vector-Scalar Registers (VSRs). There are 4 word instructions and 2 prefixed instructions that provides this 32-byte storage access operations - lxvp, lxvpx, stxvp, stxvpx, plxvpx, pstxvpx.

Emulation infrastructure doesn't have support for these instructions, to operate with 32-byte storage access and to operate with 2 VSX registers. This patch series enables the instruction emulation support and adds test cases for them respectively.

Changes in v3:
-------------
Worked on review comments and suggestions from Ravi and Naveen,

* Fix the do_vsx_load() to handle vsx instructions if MSR_FP/MSR_VEC cleared in exception conditions and it reaches to read/write to thread_struct member fp_state/vr_state respectively.
* Fix wrongly used __vector128 v[2] in struct vsx_reg as it should hold a single vsx register size.
* Remove unnecessary VSX_CHECK_VEC flag set and condition to check VSX_LDLEFT that is not applicable for these vsx instructions.
* Fix comments in emulate_vsx_load() that were misleading.
* Rebased on latest powerpc next branch.

Changes in v2:
-------------
* Fix suggestion from Sandipan, wrap ISA 3.1 instructions with cpu_has_feature(CPU_FTR_ARCH_31) check.
* Rebase on latest powerpc next branch.

Balamuruhan S (4):
powerpc/sstep: support new VSX vector paired storage access
instructions
powerpc/sstep: support emulation for vsx vector paired storage access
instructions
powerpc ppc-opcode: add encoding macros for vsx vector paired
instructions
powerpc sstep: add testcases for vsx load/store instructions

 arch/powerpc/include/asm/ppc-opcode.h |  17 ++
 arch/powerpc/lib/sstep.c              | 122 +++++++++++--
 arch/powerpc/lib/test_emulate_step.c  | 252 ++++++++++++++++++++++++++
 3 files changed, 374 insertions(+), 17 deletions(-)

base-commit: 71d7bca373d5fa0ec977ca4814f49140621bd7ae

Signature · 1 line
2.24.1