Skip to content

migration: Add block-bitmap-mapping parameter

Max Reitz qemu-devel 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest3 patches 4 repliesIn review
  2. v44 patches 18 repliesSuperseded
  3. v33 patches 5 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v23 patches9 repliesSuperseded
v14 patches15 repliesSuperseded

Changes in v5 from the cover letter

- Patch 1:
- QAPI documentation: On the destination, unmapped aliases are not just reported and that’s it – encountering one will actually lead to the whole rest of the bitmap migration data being discarded.

- Use sizeof_field instead of hand-coding it

- %s/255/UINT8_MAX/

- s/Unable to read bitmap name string/
Unable to read bitmap alias string/

- Cancellation on unknown incoming bitmap aliases was handled improperly; it should be handled properly now

- Old patch 2: Dropped

- Patch 3 (was 4): Use discards instead of writes to dirty the bitmap

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3migration: Add block-bitmap-mapping parametermigration/block-dirty-bitmap.c migration/migration.c migration/migration.h +2 more+522 -572 replies
2/3iotests.py: Let wait_migration() return on failuretests/qemu-iotests/iotests.py+12 -60 replies
3/3iotests: Test node/bitmap aliases during migrationtests/qemu-iotests/300 tests/qemu-iotests/300.out tests/qemu-iotests/group+601 -02 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchEric BlakeVladimir Sementsov-Ogievskiy
1/3Reviwed-by R-b
2/3R-b R-b
3/3T-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 0/3] migration: Add block-bitmap-mapping parameter

RFC v1: https://lists.nongnu.org/archive/html/qemu-block/2020-05/msg00912.html
RFC v2: https://lists.nongnu.org/archive/html/qemu-block/2020-05/msg00915.html
v1: https://lists.nongnu.org/archive/html/qemu-devel/2020-06/msg09792.html
v2: https://lists.nongnu.org/archive/html/qemu-block/2020-07/msg01179.html
v3: https://lists.nongnu.org/archive/html/qemu-block/2020-07/msg01385.html
v4: https://lists.nongnu.org/archive/html/qemu-block/2020-08/msg00566.html

Branch: https://github.com/XanClic/qemu.git migration-bitmap-mapping-v5
Branch: https://git.xanclic.moe/XanClic/qemu.git migration-bitmap-mapping-v5

Hi,

This new migration parameter allows mapping block node names and bitmap names to aliases for the purpose of block dirty bitmap migration.

This way, management tools can use different node names on the source and destination and pass the mapping of how bitmaps are to be transferred to qemu (on the source, the destination, or even both with arbitrary aliases in the migration stream).

v5:
- Patch 1:
- QAPI documentation: On the destination, unmapped aliases are not just reported and that’s it – encountering one will actually lead to the whole rest of the bitmap migration data being discarded.

- Use sizeof_field instead of hand-coding it

- %s/255/UINT8_MAX/

- s/Unable to read bitmap name string/
Unable to read bitmap alias string/

- Cancellation on unknown incoming bitmap aliases was handled improperly; it should be handled properly now

- Old patch 2: Dropped

- Patch 3 (was 4): Use discards instead of writes to dirty the bitmap

git-backport-diff against v4:

Key:
[----] : patches are identical
[####] : number of functional differences between upstream/downstream patch [down] : patch is downstream-only
The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively

001/3:[0040] [FC] 'migration: Add block-bitmap-mapping parameter' 002/3:[----] [--] 'iotests.py: Let wait_migration() return on failure' 003/3:[0002] [FC] 'iotests: Test node/bitmap aliases during migration'

Max Reitz (3):
migration: Add block-bitmap-mapping parameter iotests.py: Let wait_migration() return on failure
iotests: Test node/bitmap aliases during migration

 qapi/migration.json            | 104 +++++-
 migration/migration.h          |   3 +
 migration/block-dirty-bitmap.c | 412 ++++++++++++++++++++---
 migration/migration.c          |  30 ++
 monitor/hmp-cmds.c             |  30 ++
 tests/qemu-iotests/300         | 595 +++++++++++++++++++++++++++++++++
 tests/qemu-iotests/300.out     |   5 +
 tests/qemu-iotests/group       |   1 +
 tests/qemu-iotests/iotests.py  |  18 +-
 9 files changed, 1135 insertions(+), 63 deletions(-)
 create mode 100755 tests/qemu-iotests/300
 create mode 100644 tests/qemu-iotests/300.out
Signature · 1 line
2.26.2