mm / virtio-mem: support ZONE_MOVABLE
Status from this message: [merged] mm-document-semantics-of-zone_movable.patch removed from -mm tree
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest6 patches 6 repliesApplied 6/6
- v46 patches 3 repliesSuperseded
- v36 patches 4 repliesSuperseded
Earlier versions · 2
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 | 6 patches | 2 replies | Superseded | |
| v1 | 6 patches | 17 replies | Superseded |
Changes in v5 from the cover letter
- Rename "mm/page_isolation: don't dump_page(NULL) in set_migratetype_isolate()" to "mm/page_isolation: exit early when pageblock is isolated in set_migratetype_isolate()" as I was messing up things while reshuffling patches (dump_page(NULL) could never happen, only the WARN_ON_ONCE())
-- Clarify in the description that this is currently a cleanup only
- "mm: document semantics of ZONE_MOVABLE"
-- Clarified in the memory hole case, that kernelcore/movablecore is
required to create such rare special cases
Patches in v5 All 6 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | mm/page_alloc: tweak comments in has_unmovable_pages()mm/ | +6 | 0 replies | Applied |
| 2/6 | mm/page_isolation: exit early when pageblock is isolated in set_migratetype_isolate()mm/ | +5 | 0 replies | Applied |
| 3/6 | mm/page_isolation: drop WARN_ON_ONCE() in set_migratetype_isolate()mm/ | +6 | 0 replies | Applied |
| 4/6 | mm/page_isolation: cleanup set_migratetype_isolate()mm/ | +7 | 0 replies | Applied |
| 5/6 | virtio-mem: don't special-case ZONE_MOVABLEdrivers/ | +8 | 0 replies | Applied |
| 6/6 | mm: document semantics of ZONE_MOVABLEinclude/ | +35 | 0 replies | Applied |
Reviews trailers per patch
5 of 6 patches have a Reviewed-by or Acked-by.
| Patch | Baoquan He | Pankaj Gupta | Mike Kravetz | Mike Rapoport |
|---|---|---|---|---|
| 1/6 | R-b | |||
| 2/6 | R-b | R-b | A-b | |
| 3/6 | R-b | |||
| 4/6 | R-b | R-b | ||
| 5/6 | ||||
| 6/6 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.
Cover letter [PATCH v5 0/6] mm / virtio-mem: support ZONE_MOVABLE
For 5.10. Patch #1-#4,#6 have RBs or ACKs, patch #5 is virtio-mem stuff maintained by me. This should go via the -mm tree.
---
When introducing virtio-mem, the semantics of ZONE_MOVABLE were rather unclear, which is why we special-cased ZONE_MOVABLE such that partially plugged blocks would never end up in ZONE_MOVABLE.
Now that the semantics are much clearer (and are documented in patch #6), let's support partially plugged memory blocks in ZONE_MOVABLE, allowing partially plugged memory blocks to be online to ZONE_MOVABLE and also unplugging from such memory blocks. This avoids surprises when onlining of memory blocks suddenly fails, just because they are not completely populated by virtio-mem (yet).
This is especially helpful for testing, but also paves the way for virtio-mem optimizations, allowing more memory to get reliably unplugged.
Cleanup has_unmovable_pages() and set_migratetype_isolate(), providing better documentation of how ZONE_MOVABLE interacts with different kind of unmovable pages (memory offlining vs. alloc_contig_range()).
v4 -> v5:
- Rename "mm/page_isolation: don't dump_page(NULL) in set_migratetype_isolate()" to "mm/page_isolation: exit early when pageblock is isolated in set_migratetype_isolate()" as I was messing up things while reshuffling patches (dump_page(NULL) could never happen, only the WARN_ON_ONCE())
-- Clarify in the description that this is currently a cleanup only
- "mm: document semantics of ZONE_MOVABLE"
-- Clarified in the memory hole case, that kernelcore/movablecore is
required to create such rare special cases
v3 -> v4:
- "mm/page_isolation: drop WARN_ON_ONCE() in set_migratetype_isolate()" -- Fix typo in description
- "virtio-mem: don't special-case ZONE_MOVABLE"
-- Add more details why we initialli special-cased ZONE_MOVABLE (via MST)
- "mm: document semantics of ZONE_MOVABLE"
-- Rephrase some parts of documentation (via Mike)
v2 -> v3:
- "mm: document semantics of ZONE_MOVABLE"
-- Fix a typo
v1 -> v2:
- "mm/page_isolation: don't dump_page(NULL) in set_migratetype_isolate()" -- Move to position 1, add Fixes: tag
-- Drop unused "out:" label
- "mm/page_isolation: drop WARN_ON_ONCE() in set_migratetype_isolate()" -- Keep curly braces on "else" case
- Replace "[PATCH v1 5/6] mm/page_alloc: restrict ZONE_MOVABLE optimization in has_unmovable_pages() to memory offlining"
by "mm: document semantics of ZONE_MOVABLE"
-- Brain dump of what I know about ZONE_MOVABLE
David Hildenbrand (6):
mm/page_alloc: tweak comments in has_unmovable_pages() mm/page_isolation: exit early when pageblock is isolated in
set_migratetype_isolate()
mm/page_isolation: drop WARN_ON_ONCE() in set_migratetype_isolate() mm/page_isolation: cleanup set_migratetype_isolate()
virtio-mem: don't special-case ZONE_MOVABLE
mm: document semantics of ZONE_MOVABLE
drivers/virtio/virtio_mem.c | 47 +++++++------------------------------ include/linux/mmzone.h | 35 +++++++++++++++++++++++++++ mm/page_alloc.c | 22 +++++------------ mm/page_isolation.c | 39 ++++++++++++++---------------- 4 files changed, 66 insertions(+), 77 deletions(-)
Signature · 1 line
2.26.2