Skip to content

RFC timer: Reduce timers softirq (and other optimizations)

Frederic Weisbecker lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest10 patches 14 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10timer: Prevent base->clk from moving backwardkernel/time/timer.c+14 -37 replies
2/10timer: Move trigger_dyntick_cpu() to enqueue_timer()kernel/time/timer.c+19 -270 replies
3/10timer: Simplify LVL_START() and calc_index()kernel/time/timer.c+2 -22 replies
4/10timer: Optimize _next_timer_interrupt() level iterationkernel/time/timer.c+9 -10 replies
5/10timers: Always keep track of next expirykernel/time/timer.c+18 -170 replies
6/10timer: Reuse next expiry cache after nohz exitkernel/time/timer.c+2 -40 replies
7/10timer: Expand clk forward logic beyond nohzkernel/time/timer.c+4 -220 replies
8/10timer: Spare timer softirq until next expirykernel/time/timer.c+8 -410 replies
9/10timer: Remove must_forward_clkkernel/time/timer.c+6 -160 replies
10/10timer: Lower base clock forwarding thresholdkernel/time/timer.c+1 -15 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCH 00/10] timer: Reduce timers softirq (and other optimizations)

Juri Lelli has reported that threaded IRQs don't go along well with full dynticks.

The tick never manages to stop due to the following endless loop:

* Timer tick raises timer softirq
* Ksoftirqd wakes up, restarts the tick (2 tasks in the runqueue)
* Timer tick raises timer softirq
* Ksoftirqd wakes up, etc...

The main issue here is that the tick fires the timer tick unconditionally, whether timers have expired or not. This set is a proposal to lower that.

The 1st patch is actually a bugfix for a theoretical issue that I haven't observed in practice. But who knows?

Patch 2 is a consolidation.

Patch 3 and 4 are optimizations.

The rest is about timer softirqs.

git://git.kernel.org/pub/scm/linux/kernel/git/frederic/linux-dynticks.git
timers/softirq

HEAD: d0567dd5546d1f32eca3772a431488f8b0ac26a1

Thanks,
Frederic
---

Frederic Weisbecker (10):
timer: Prevent base->clk from moving backward
timer: Move trigger_dyntick_cpu() to enqueue_timer()
timer: Simplify LVL_START() and calc_index()
timer: Optimize _next_timer_interrupt() level iteration
timers: Always keep track of next expiry
timer: Reuse next expiry cache after nohz exit
timer: Expand clk forward logic beyond nohz
timer: Spare timer softirq until next expiry
timer: Remove must_forward_clk
timer: Lower base clock forwarding threshold

 kernel/time/timer.c | 179 +++++++++++++++++++---------------------------------
 1 file changed, 64 insertions(+), 115 deletions(-)