usb: cdns3: Improvements for cdns3 DRD code
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest9 patches 7 repliesIn review
- v19 patches 12 repliesSuperseded
Changes in v2 from the cover letter
- Change patch titles as sugested by Peter Chen.
- Remove typos in patch 5 and patch 7.
- Add reviewed-by Peter Chen tag [Patch 1, patch 8 and Patch 9].
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | usb: cdns3: core: removed cdns3_get_current_role_driver functiondrivers/ | +0 | 0 replies | |
| 2/9 | usb: cdns3: drd: removed not needed variables initializationdrivers/ drivers/ | +11 | 1 reply | |
| 3/9 | usb: cnds3: drd: deleted !=drivers/ | +1 | 1 reply | |
| 4/9 | usb: cdns3: drd: return IRQ_NONE explicitly.drivers/ | +2 | 1 reply | |
| 5/9 | usb: cdns3: drd: changed return type from int to booldrivers/ drivers/ | +10 | 1 reply | |
| 6/9 | usb: cdns3: Added CDNS3_ID_PERIPHERAL and CDNS3_ID_HOSTdrivers/ drivers/ | +5 | 1 reply | |
| 7/9 | usb: cdns3: core: removed 'goto not_otg'drivers/ | +9 | 2 replies | |
| 8/9 | usb: cdns3: core: removed overwriting some error codedrivers/ | +2 | 0 replies | |
| 9/9 | usb: cdns3: drd: simplify *switch_gadet and *switch_hostdrivers/ drivers/ drivers/ +1 more | +76 | 0 replies |
Reviews trailers per patch
8 of 9 patches have a Reviewed-by or Acked-by.
| Patch | Peter Chen |
|---|---|
| 1/9 | R-b |
| 2/9 | R-b |
| 3/9 | R-b |
| 4/9 | R-b |
| 5/9 | R-b |
| 6/9 | R-b |
| 7/9 | |
| 8/9 | R-b |
| 9/9 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/9] usb: cdns3: Improvements for cdns3 DRD code
Series introduce some improvements to drd.c, drd.h and core.c files of cdns3 driver.
Except for the first (1/9) patch that removes not needed function, the rest patches make improvements suggested by Dan Carpenter during reviewing CDNSP driver.
CDNSP is the next Cadence USBSSP driver which will be upstreamed. The DRD part is similar for both CDNS3 and CDNSP and Greg suggested to merge the similar part of DRD code. As first step I want to merge some improvements.
Changes for v2:
- Change patch titles as sugested by Peter Chen.
- Remove typos in patch 5 and patch 7.
- Add reviewed-by Peter Chen tag [Patch 1, patch 8 and Patch 9].
Pawel Laszczak (9):
usb: cdns3: core: removed cdns3_get_current_role_driver function
usb: cdns3: drd: removed not needed variables initialization
usb: cnds3: drd: deleted !=
usb: cdns3: drd: return IRQ_NONE explicitly.
usb: cdns3: drd: changed return type from int to bool
usb: cdns3: Added CDNS3_ID_PERIPHERAL and CDNS3_ID_HOST
usb: cdns3: core: removed 'goto not_otg'
usb: cdns3: core: removed overwriting some error code
usb: cdns3: drd: simplify *switch_gadet and *switch_host
drivers/usb/cdns3/core.c | 39 +++------ drivers/usb/cdns3/drd.c | 165 ++++++++++++++++++++----------------- drivers/usb/cdns3/drd.h | 13 ++- drivers/usb/cdns3/gadget.c | 4 +- drivers/usb/cdns3/host.c | 4 +- 5 files changed, 114 insertions(+), 111 deletions(-)
Signature · 1 line
2.17.1