Skip to content

gro: add UDP/IPv4 GRO and VXLAN UDP/IPv4 GRO support

[email protected] dpdk-dev 7 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest3 patches 13 repliesIn review
  2. v63 patches 14 repliesSuperseded
  3. v52 patches 10 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v42 patches5 repliesSuperseded
v32 patches2 repliesSuperseded
v22 patches0 repliesSuperseded
v11 patch7 repliesSuperseded

Patches in v7 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3gro: add UDP/IPv4 GRO supportlib/librte_gro/gro_udp4.c lib/librte_gro/gro_udp4.h lib/librte_gro/meson.build +2 more+798 -171 reply
2/3gro: add VXLAN UDP/IPv4 GRO supportlib/librte_gro/gro_udp4.h lib/librte_gro/gro_vxlan_udp4.c lib/librte_gro/gro_vxlan_udp4.h +3 more+792 -274 replies
3/3doc: update prog_guide and rel_notes for GROdoc/guides/prog_guide/generic_receive_offload_lib.rst doc/guides/rel_notes/release_20_11.rst+9 -37 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchJiayu Hu
1/3A-b
2/3A-b
3/3A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v7 thread

Cover letter [dpdk-dev] [PATCH v7 0/3] gro: add UDP/IPv4 GRO and VXLAN UDP/IPv4 GRO support

From: Yi Yang <[email protected]>

In case that UFO or GSO is enabled, GRO is very necessary, especially for UDP, it is more so. Many NICs can't support VXLAN UDP UFO/USO and VLAN UFO/USO, so UDP performance improvement depends on GSO and GRO to a great extent.

This patch series added VLAN UDP/IPv4 GRO and VXLAN UDP/IPv4 GRO support.

I have tested it in OVS DPDK, test scenario is as below:

+-------------------------+   +--------------------------+
|VM1 --- OVS DPDK --- NIC1|---| NIC2 --- OVS-DPDK --- VM2|
+-------------------------+   +--------------------------+
         SERVER1                       SERVER2

If no GSO and GRO, 8k UDP packet can't work in case of UFO or in case that underlay MTU is 1500, so UDP size must meet MTU limitation, my VM MTU is 1450 (consider vxlan header), UDP performance is about 3Gbps, with GSO and GRO enabled, I can send 8K UDP packet, UDP performance is about 6Gbps (Note: with small UDP packet loss rate).

FYI: OVS DPDK patch series
https://patchwork.ozlabs.org/project/openvswitch/list/?series=194621

Changelog
---------
v6 -> v7: correct max_nb_out to left_nb_out in some if statement
add more comments for break branch in gro_*_tbl_timeout_flush remove whitespace line in struct vxlan_udp4_flow_key

v5 -> v6: add doc update patch for prog_guide and rel_notes
rename udp_check_vxlan_neighbor to udp4_check_vxlan_neighbor remove outer_ip_id and outer_is_atomic
some other misc changes

v4 -> v5: remove duplicate line
fix header length check issue
add unlikely for some low probability condition branch rename udp_check_neighbor to udp4_check_neighbor remove brace for single line else statement remove outer_l2_len and pkt->outer_l3_len because they
are nonsense for non-VXLAN UDP packet

v3 -> v4: split two patches in cleaner way
remove ip_id which is unnecessary for UDP GRO correct hdr_len calculation

v2 -> v3: remove UDP header length check

v1 -> v2: split into two patches

Yi Yang (3):
gro: add UDP/IPv4 GRO support
gro: add VXLAN UDP/IPv4 GRO support
doc: update prog_guide and rel_notes for GRO

 .../prog_guide/generic_receive_offload_lib.rst     |   6 +-
 doc/guides/rel_notes/release_20_11.rst             |   6 +
 lib/librte_gro/gro_udp4.c                          | 433 ++++++++++++++++
 lib/librte_gro/gro_udp4.h                          | 282 +++++++++++
 lib/librte_gro/gro_vxlan_udp4.c                    | 545 +++++++++++++++++++++
 lib/librte_gro/gro_vxlan_udp4.h                    | 153 ++++++
 lib/librte_gro/meson.build                         |   2 +-
 lib/librte_gro/rte_gro.c                           | 193 ++++++--
 lib/librte_gro/rte_gro.h                           |   8 +-
 9 files changed, 1590 insertions(+), 38 deletions(-)
 create mode 100644 lib/librte_gro/gro_udp4.c
 create mode 100644 lib/librte_gro/gro_udp4.h
 create mode 100644 lib/librte_gro/gro_vxlan_udp4.c
 create mode 100644 lib/librte_gro/gro_vxlan_udp4.h
Signature · 1 line
1.8.3.1