Skip to content

coresight: allow to build coresight as modules

Tingwei Zhang linux-arm-kernel lkml 11 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v11 Latest24 patches 5 repliesIn review
  2. v1024 patches 27 repliesSuperseded
  3. v924 patches 8 repliesSuperseded
Earlier versions · 8
VersionPostedPatchesRepliesStatus
v824 patches43 repliesSuperseded
v725 patches37 repliesSuperseded
v625 patches23 repliesSuperseded
v522 patches1 replySuperseded
v420 patches17 repliesSuperseded
v320 patches20 repliesSuperseded
v220 patches9 repliesSuperseded
v121 patches2 repliesSuperseded

Changes in v11 from the cover letter

Rebase to latest coresight-next
Protect etmdrvdata[] by modifying it on relevant CPU for ETM3. (Mathieu and Suzuki)
-It's not tested.
Refine the alignment in coresight makefile. (Mathieu)
Add reason for cti_remove_conn_xrefs change. (Mathieu)
Set owner for static funnel driver. (Suzuki)

Patches in v11 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/24coresight: cpu_debug: add module name in Kconfigdrivers/hwtracing/coresight/Kconfig+3 -00 replies
2/24coresight: cpu_debug: define MODULE_DEVICE_TABLEdrivers/hwtracing/coresight/coresight-cpu-debug.c+2 -00 replies
3/24coresight: use IS_ENABLED for CONFIGs that may be modulesdrivers/hwtracing/coresight/coresight-etm-perf.h drivers/hwtracing/coresight/coresight-priv.h include/linux/coresight.h+3 -30 replies
4/24coresight: add coresight prefix to barrier_pktdrivers/hwtracing/coresight/coresight-etb10.c drivers/hwtracing/coresight/coresight-priv.h drivers/hwtracing/coresight/coresight-tmc-etf.c +1 more+6 -70 replies
5/24coresight: export global symbolsdrivers/hwtracing/coresight/coresight-etm-perf.c drivers/hwtracing/coresight/coresight-sysfs.c drivers/hwtracing/coresight/coresight-tmc-etr.c +1 more+17 -00 replies
6/24coresight: add try_get_module() in coresight_grab_device()drivers/hwtracing/coresight/coresight.c+53 -71 reply
7/24coresight: stm: allow to build coresight-stm as a moduledrivers/hwtracing/coresight/Kconfig drivers/hwtracing/coresight/coresight-stm.c+23 -20 replies
8/24coresight: etm: perf: Fix warning caused by etm_setup_aux failuredrivers/hwtracing/coresight/coresight-etm-perf.c+2 -20 replies
9/24coresight: etm3x: allow etm3x to be built as a moduledrivers/hwtracing/coresight/Kconfig drivers/hwtracing/coresight/Makefile drivers/hwtracing/coresight/coresight-etm3x-core.c+122 -363 replies
10/24coresight: etm4x: allow etm4x to be built as a moduledrivers/hwtracing/coresight/Kconfig drivers/hwtracing/coresight/Makefile drivers/hwtracing/coresight/coresight-etm4x-core.c+69 -240 replies
11/24coresight: etb: allow etb to be built as a moduledrivers/hwtracing/coresight/Kconfig drivers/hwtracing/coresight/coresight-etb10.c+29 -20 replies
12/24coresight: tpiu: allow tpiu to be built as a moduledrivers/hwtracing/coresight/Kconfig drivers/hwtracing/coresight/coresight-tpiu.c+23 -20 replies
13/24coresight: tmc: allow tmc to be built as a moduledrivers/hwtracing/coresight/Kconfig drivers/hwtracing/coresight/Makefile drivers/hwtracing/coresight/coresight-tmc-core.c+32 -50 replies
14/24coresight: allow funnel driver to be built as moduledrivers/hwtracing/coresight/coresight-funnel.c+63 -20 replies
15/24coresight: allow replicator driver to be built as moduledrivers/hwtracing/coresight/Kconfig drivers/hwtracing/coresight/coresight-replicator.c+67 -31 reply
16/24coresight: cti: add function to register cti associate opsdrivers/hwtracing/coresight/coresight-cti.c drivers/hwtracing/coresight/coresight-priv.h drivers/hwtracing/coresight/coresight.c+55 -160 replies
17/24coresight: cti: Fix remove sysfs link errordrivers/hwtracing/coresight/coresight-cti.c+6 -30 replies
18/24coresight: cti: Fix bug clearing sysfs links on callbackdrivers/hwtracing/coresight/coresight-cti.c drivers/hwtracing/coresight/coresight.c+3 -30 replies
19/24coresight: cti: don't disable ect device if it's not enableddrivers/hwtracing/coresight/coresight.c include/linux/coresight.h+9 -30 replies
20/24coresight: cti: increase reference count when enabling ctidrivers/hwtracing/coresight/coresight.c+14 -30 replies
21/24coresight: cti: allow cti to be built as a moduledrivers/hwtracing/coresight/Kconfig drivers/hwtracing/coresight/Makefile drivers/hwtracing/coresight/coresight-cti-core.c +2 more+28 -50 replies
22/24coresight: tmc-etr: add function to register catu opsdrivers/hwtracing/coresight/coresight-catu.c drivers/hwtracing/coresight/coresight-catu.h drivers/hwtracing/coresight/coresight-tmc-etr.c +1 more+36 -60 replies
23/24coresight: catu: allow catu drivers to be built as modulesdrivers/hwtracing/coresight/Kconfig drivers/hwtracing/coresight/coresight-catu.c+19 -10 replies
24/24coresight: allow the coresight core driver to be built as a moduledrivers/hwtracing/coresight/Kconfig drivers/hwtracing/coresight/Makefile drivers/hwtracing/coresight/coresight-core.c +2 more+48 -150 replies

Reviews trailers per patch

23 of 24 patches have a Reviewed-by or Acked-by.

PatchSuzuki K PouloseMathieu PoirierMike Leach
1/24R-b R-b T-b
2/24R-b R-b
3/24R-b R-b
4/24R-b R-b
5/24R-b T-b
6/24R-b T-b
7/24R-b R-b T-b
8/24R-b R-b R-b
9/24R-b
10/24R-b T-b
11/24R-b R-b T-b
12/24R-b R-b R-b
13/24R-b R-b T-b
14/24R-b R-b T-b
15/24R-b R-b T-b
16/24R-b T-b
17/24R-b
18/24A-b R-b
19/24R-b
20/24R-b
21/24T-b
22/24R-b R-b
23/24R-b R-b R-b
24/24R-b R-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v11 thread

Cover letter [PATCH v11 00/24] coresight: allow to build coresight as modules

Allow to build coresight as modules. This gives developers the feasibility to test their code without reboot.

This series is based on below two series.

- "coresight: allow to build components as modules"
https://lkml.org/lkml/2018/6/5/989
- "coresight: make drivers modular"
https://lkml.org/lkml/2020/1/17/468

Change from v10:
Rebase to latest coresight-next
Protect etmdrvdata[] by modifying it on relevant CPU for ETM3. (Mathieu and Suzuki)
-It's not tested.
Refine the alignment in coresight makefile. (Mathieu)
Add reason for cti_remove_conn_xrefs change. (Mathieu)
Set owner for static funnel driver. (Suzuki)

Change from v9:
Fix warning reported by kernel test robot <[email protected]> Rebase to coresight-next

Change from v8:
Protect etmdrvdata[] by modifying it on relevant CPU (Mathieu and Suzuki) Grab the device before allocating memory for the node (Mathieu) Add author of coresight core driver (Mathieu)

Change from v7:
Depends on below change for ETM hotplug (Sai)
https://lore.kernel.org/linux-arm-kernel/[email protected]/
Add mutex lock to protect etmdrvdata[] (Suzuki)
Add helper function coresight_get_ref() (Suzuki)
Reorg replicator and funnel change. Use two patches to support these two drivers. (Suzuki)
Add fix tag to "coresight: etm: perf: Fix warning caused by etm_setup_aux failure" (Suzuki)
Update author of "coresight: cti: Fix bug clearing sysfs links on callback"

Change from v6:
Correct module description for CATU (Mike) Check ect_ret equals 0 and set ect_enabled flag (Mike) Add Tested-by and Reviewed-by from Mike

Change from v5:
Add below CTI clean up change from Mike into series
-https://lists.linaro.org/pipermail/coresight/2020-July/004349.html
Increase module reference count when enabling CTI device (Mike)

Change from v4:
Fix error handling in coresight_grab_devicei() (Greg)
Add coresight: cti: Fix remove sysfs link error from Mike
-https://lists.linaro.org/pipermail/coresight/2020-July/004275.html
Move cti_remove_conn_xrefs() into cti_remove() (Mike) Align patch subject to coresight: <component>: <description> (Mike)

Change from v3:
Rebase to coresight-next (Mike and Mathieu) Reorder try_get_module() (Suzuki)
Clean up etmdrvdata[] in device remote path (Mike) Move cti_remove_conn_xrefs to cti_remove (Mike)

Change from v2:
Rebase to 5.8-rc5. Export coresight_add_sysfs_link and coresight_remove_sysfs_link
Fix one cut and paste error on MODULE_DESCRIPTION of CTI

Change from v1:
Use try_module_get() to avoid module to be unloaded when device is used in active trace session. (Mathieu P)

Change from above two series.
This series adds the support to dynamically remove module when the device in that module is enabled and used by some trace path. It disables all trace paths with that device and release the trace path.

Kim Phillips (8):
coresight: use IS_ENABLED for CONFIGs that may be modules
coresight: etm3x: allow etm3x to be built as a module
coresight: etm4x: allow etm4x to be built as a module
coresight: etb: allow etb to be built as a module
coresight: tpiu: allow tpiu to be built as a module
coresight: tmc: allow tmc to be built as a module
coresight: allow funnel driver to be built as module
coresight: allow replicator driver to be built as module

Mian Yousaf Kaukab (2):
coresight: export global symbols
coresight: tmc-etr: add function to register catu ops

Mike Leach (2):
coresight: cti: Fix remove sysfs link error
coresight: cti: Fix bug clearing sysfs links on callback

Tingwei Zhang (12):
coresight: cpu_debug: add module name in Kconfig
coresight: cpu_debug: define MODULE_DEVICE_TABLE
coresight: add coresight prefix to barrier_pkt
coresight: add try_get_module() in coresight_grab_device()
coresight: stm: allow to build coresight-stm as a module
coresight: etm: perf: Fix warning caused by etm_setup_aux failure
coresight: cti: add function to register cti associate ops
coresight: cti: don't disable ect device if it's not enabled
coresight: cti: increase reference count when enabling cti
coresight: cti: allow cti to be built as a module
coresight: catu: allow catu drivers to be built as modules
coresight: allow the coresight core driver to be built as a module

 drivers/hwtracing/coresight/Kconfig           |  54 ++++--
 drivers/hwtracing/coresight/Makefile          |  26 +--
 drivers/hwtracing/coresight/coresight-catu.c  |  37 ++++-
 drivers/hwtracing/coresight/coresight-catu.h  |   2 -
 .../{coresight.c => coresight-core.c}         | 154 +++++++++++++++---
 .../hwtracing/coresight/coresight-cpu-debug.c |   2 +
 .../{coresight-cti.c => coresight-cti-core.c} |  67 ++++++--
 drivers/hwtracing/coresight/coresight-etb10.c |  28 +++-
 .../hwtracing/coresight/coresight-etm-perf.c  |  13 +-
 .../hwtracing/coresight/coresight-etm-perf.h  |   5 +-
 ...resight-etm3x.c => coresight-etm3x-core.c} | 148 +++++++++++++----
 ...resight-etm4x.c => coresight-etm4x-core.c} |  84 +++++++---
 .../hwtracing/coresight/coresight-funnel.c    |  65 +++++++-
 .../hwtracing/coresight/coresight-platform.c  |   1 +
 drivers/hwtracing/coresight/coresight-priv.h  |  23 ++-
 .../coresight/coresight-replicator.c          |  65 +++++++-
 drivers/hwtracing/coresight/coresight-stm.c   |  20 ++-
 drivers/hwtracing/coresight/coresight-sysfs.c |   2 +
 .../{coresight-tmc.c => coresight-tmc-core.c} |  25 ++-
 .../hwtracing/coresight/coresight-tmc-etf.c   |   2 +-
 .../hwtracing/coresight/coresight-tmc-etr.c   |  21 ++-
 drivers/hwtracing/coresight/coresight-tmc.h   |   3 +
 drivers/hwtracing/coresight/coresight-tpiu.c  |  20 ++-
 include/linux/coresight.h                     |   3 +-
 24 files changed, 726 insertions(+), 144 deletions(-)
 rename drivers/hwtracing/coresight/{coresight.c => coresight-core.c} (92%)
 rename drivers/hwtracing/coresight/{coresight-cti.c => coresight-cti-core.c} (94%)
 rename drivers/hwtracing/coresight/{coresight-etm3x.c => coresight-etm3x-core.c} (90%)
 rename drivers/hwtracing/coresight/{coresight-etm4x.c => coresight-etm4x-core.c} (96%)
 rename drivers/hwtracing/coresight/{coresight-tmc.c => coresight-tmc-core.c} (95%)
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project