Skip to content

vfio/pci: add denylist and disable qat

Giovanni Cabiddu kvm linux-crypto linux-pci lkml 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest5 patches 1 replyIn review
  2. v45 patches 2 repliesSuperseded
  3. v35 patches 2 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v25 patches3 repliesSuperseded
v15 patches11 repliesSuperseded

Changes in v5 from the cover letter

- Patch #2: added Reviewed-by tag from Cornelia Huck
- Patch #5: added Suggested-by tag as this change was suggested internally by Andy Shevchenko
- Patches 1-5: added Reviewed-by tag from Fiona Trahe

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5PCI: Add Intel QuickAssist device IDsinclude/linux/pci_ids.h+6 -00 replies
2/5vfio/pci: Add device denylistdrivers/vfio/pci/vfio_pci.c+33 -00 replies
3/5vfio/pci: Add QAT devices to denylistdrivers/vfio/pci/vfio_pci.c+15 -00 replies
4/5crypto: qat - replace device ids definesdrivers/crypto/qat/qat_c3xxx/adf_drv.c drivers/crypto/qat/qat_c3xxxvf/adf_drv.c drivers/crypto/qat/qat_c62x/adf_drv.c +6 more+27 -310 replies
5/5crypto: qat - use PCI_VDEVICEdrivers/crypto/qat/qat_c3xxx/adf_drv.c drivers/crypto/qat/qat_c3xxxvf/adf_drv.c drivers/crypto/qat/qat_c62x/adf_drv.c +3 more+12 -300 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchBjorn HelgaasFiona TraheCornelia HuckAndy Shevchenko
SeriesR-b
1/5A-b R-b
2/5R-b R-b
3/5R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v5 thread

Cover letter [PATCH v5 0/5] vfio/pci: add denylist and disable qat

This patchset defines a denylist of devices in the vfio-pci module and adds the current generation of Intel(R) QuickAssist devices to it as they are not designed to run in an untrusted environment.

By default, if a device is in the denylist, the probe of vfio-pci fails. If a user wants to use a device in the denylist, he needs to disable the full denylist providing the option disable_denylist=1 at the load of vfio-pci or specifying that parameter in a config file in /etc/modprobe.d.

This series also moves the device ids definitions present in the qat driver to linux/pci_ids.h since they will be shared between the vfio-pci and the qat drivers and replaces the custom ADF_SYSTEM_DEVICE macro with PCI_VDEVICE.

The series is applicable to Herbert's tree. Patches 1 to 3 apply also to Alex's tree (next). Patches 4 and 5 are optional and can be applied at a later stage.

Changes from v4:
- Patch #2: added Reviewed-by tag from Cornelia Huck
- Patch #5: added Suggested-by tag as this change was suggested internally by Andy Shevchenko
- Patches 1-5: added Reviewed-by tag from Fiona Trahe

Changes from v3:
- Patch #1: included Acked-by tag, after ack from Bjorn Helgaas
- Patch #2: s/prevents/allows/ in module parameter description

Changes from v2:
- Renamed blocklist in denylist
- Patch #2: reworded module parameter description to clarify why a device is in the denylist
- Patch #2: reworded warning that occurs when denylist is enabled and device is present in that list

Changes from v1:
- Reworked commit messages:
Patches #1, #2 and #3: capitalized first character after column to comply to subject line convention
Patch #3: Capitalized QAT acronym and added link and doc number for document "Intel® QuickAssist Technology (Intel® QAT) Software for Linux"

Giovanni Cabiddu (5):
PCI: Add Intel QuickAssist device IDs
vfio/pci: Add device denylist
vfio/pci: Add QAT devices to denylist
crypto: qat - replace device ids defines
crypto: qat - use PCI_VDEVICE

 drivers/crypto/qat/qat_c3xxx/adf_drv.c        | 11 ++---
 drivers/crypto/qat/qat_c3xxxvf/adf_drv.c      | 11 ++---
 drivers/crypto/qat/qat_c62x/adf_drv.c         | 11 ++---
 drivers/crypto/qat/qat_c62xvf/adf_drv.c       | 11 ++---
 .../crypto/qat/qat_common/adf_accel_devices.h |  6 ---
 drivers/crypto/qat/qat_common/qat_hal.c       |  7 +--
 drivers/crypto/qat/qat_common/qat_uclo.c      |  9 ++--
 drivers/crypto/qat/qat_dh895xcc/adf_drv.c     | 11 ++---
 drivers/crypto/qat/qat_dh895xccvf/adf_drv.c   | 11 ++---
 drivers/vfio/pci/vfio_pci.c                   | 48 +++++++++++++++++++
 include/linux/pci_ids.h                       |  6 +++
 11 files changed, 87 insertions(+), 55 deletions(-)
Signature · 1 line
2.26.2