Skip to content

Misc fixes & cleanups for nfs-utils

Doug Nazar linux-nfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest10 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10gssd: Refcount struct clnt_info to protect multithread usageutils/gssd/gssd.c utils/gssd/gssd.h utils/gssd/gssd_proc.c+55 -210 replies
2/10Update to libevent 2.x apis.aclocal/libevent.m4 utils/gssd/gssd.c utils/gssd/gssd.h +5 more+94 -700 replies
3/10gssd: Cleanup on exit to support valgrind.utils/gssd/gssd.c utils/gssd/krb5_util.c utils/gssd/krb5_util.h+70 -300 replies
4/10gssd: gssd_k5_err_msg() returns a strdup'd msg. Use free() to release.utils/gssd/krb5_util.c+7 -74 replies
5/10gssd: Fix locking for machine principal listutils/gssd/gssd.h utils/gssd/gssd_proc.c utils/gssd/krb5_util.c +1 more+185 -1260 replies
6/10gssd: Add a few debug statements to help track client_info lifetimes.utils/gssd/gssd.c+4 -00 replies
7/10gssd: Lookup local hostname when srchost is '*'utils/gssd/krb5_util.c+27 -250 replies
8/10gssd: We never use the nocache param of gssd_check_if_cc_exists()utils/gssd/krb5_util.c+5 -50 replies
9/10Cleanup printf format attribute handling and fix format stringssupport/include/compiler.h support/include/xcommon.h support/include/xlog.h +20 more+93 -600 replies
9/10Cleanup printf format attribute handling and fix various format stringssupport/include/compiler.h support/include/xcommon.h support/include/xlog.h +20 more+93 -600 replies
9/10Consolidate printf format attribute handling and fix various format stringssupport/include/compiler.h support/include/xcommon.h support/include/xlog.h +20 more+93 -600 replies
10/10Fix various clang warnings.configure.ac support/include/xcommon.h utils/mount/network.c +2 more+7 -90 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/10] Misc fixes & cleanups for nfs-utils

Most of this work centers around gssd, however a few items I did tree wide. It's been compile tested with both gcc & clang on x86_64 & arm32 and runtime tested on x86_64.

Doug Nazar (10):
gssd: Refcount struct clnt_info to protect multithread usage Update to libevent 2.x apis.
gssd: Cleanup on exit to support valgrind.
gssd: gssd_k5_err_msg() returns a strdup'd msg. Use free() to release.
gssd: Fix locking for machine principal list
gssd: Add a few debug statements to help track client_info lifetimes.
gssd: Lookup local hostname when srchost is '*'
gssd: We never use the nocache param of gssd_check_if_cc_exists() Cleanup printf format attribute handling and fix format strings Fix various clang warnings.

 aclocal/libevent.m4                |   6 +-
 configure.ac                       |   6 +-
 support/include/compiler.h         |  14 +
 support/include/xcommon.h          |  12 +-
 support/include/xlog.h             |  20 +-
 support/nfs/xcommon.c              |   2 +
 support/nfsidmap/gums.c            |   2 +
 support/nfsidmap/libnfsidmap.c     |   8 +-
 support/nfsidmap/nfsidmap.h        |  10 +-
 support/nfsidmap/nfsidmap_common.c |   1 +
 support/nfsidmap/nss.c             |   4 +-
 support/nfsidmap/regex.c           |   6 +-
 support/nfsidmap/static.c          |   1 +
 support/nfsidmap/umich_ldap.c      |  10 +-
 tools/locktest/testlk.c            |   6 +-
 utils/exportfs/exportfs.c          |   5 +-
 utils/gssd/err_util.h              |   4 +-
 utils/gssd/gss_names.c             |   9 +-
 utils/gssd/gss_util.c              |   2 +-
 utils/gssd/gssd.c                  | 165 ++++++++---
 utils/gssd/gssd.h                  |  10 +-
 utils/gssd/gssd_proc.c             |  14 +-
 utils/gssd/krb5_util.c             | 422 +++++++++++++++++------------
 utils/gssd/krb5_util.h             |  16 +-
 utils/gssd/svcgssd.c               |   4 +-
 utils/gssd/svcgssd_proc.c          |   9 +-
 utils/idmapd/idmapd.c              |  65 +++--
 utils/mount/network.c              |   4 +-
 utils/mount/stropts.c              |   2 -
 utils/mountd/cache.c               |   2 +-
 utils/nfsdcld/cld-internal.h       |   2 +-
 utils/nfsdcld/nfsdcld.c            |  29 +-
 utils/nfsdcld/sqlite.c             |   1 -
 utils/nfsdcltrack/sqlite.c         |   2 +-
 utils/nfsidmap/nfsidmap.c          |   3 +-
 35 files changed, 536 insertions(+), 342 deletions(-)
 create mode 100644 support/include/compiler.h
Signature · 1 line
2.26.2