Skip to content

powerpc: queued spinlocks and rwlocks

Nicholas Piggin kvm-ppc linux-arch linuxppc-dev lkml 4 versions – Applied

Status from this message: Applied to powerpc/next.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest6 patches 3 repliesApplied
  2. v36 patches 39 repliesSuperseded
  3. v26 patches 2 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v18 patches10 repliesSuperseded

Patches in v4 Applied

#Subject and filesSizeRepliesApplied
1/6powerpc/pseries: move some PAPR paravirt functions to their own filearch/powerpc/include/asm/paravirt.h arch/powerpc/include/asm/spinlock.h arch/powerpc/lib/locks.c+66 -290 replies
2/6powerpc: move spinlock implementation to simple_spinlockarch/powerpc/include/asm/simple_spinlock.h arch/powerpc/include/asm/simple_spinlock_types.h arch/powerpc/include/asm/spinlock.h +1 more+311 -2950 replies
3/6powerpc/64s: implement queued spinlocks and rwlocksarch/powerpc/Kconfig arch/powerpc/include/asm/Kbuild arch/powerpc/include/asm/qspinlock.h +4 more+56 -00 replies
4/6powerpc/pseries: implement paravirt qspinlocks for SPLPARarch/powerpc/include/asm/paravirt.h arch/powerpc/include/asm/qspinlock.h arch/powerpc/include/asm/qspinlock_paravirt.h +4 more+118 -20 replies
5/6powerpc/qspinlock: optimised atomic_try_cmpxchg_lock that adds the lock hintarch/powerpc/include/asm/atomic.h arch/powerpc/include/asm/qspinlock.h+29 -10 replies
6/6powerpc: implement smp_cond_load_relaxedarch/powerpc/include/asm/barrier.h+14 -01 reply

Reviews trailers per patch

2 of 6 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchPeter Zijlstra (Intel)Waiman Long
SeriesA-b
1/6
2/6
3/6A-b
4/6A-b A-b
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/6] powerpc: queued spinlocks and rwlocks

Updated with everybody's feedback (thanks all), and more performance results.

What I've found is I might have been measuring the worst load point for the paravirt case, and by looking at a range of loads it's clear that queued spinlocks are overall better even on PV, doubly so when you look at the generally much improved worst case latencies.

I have defaulted it to N even though I'm less concerned about the PV numbers now, just because I think it needs more stress testing. But it's very nicely selectable so should be low risk to include.

All in all this is a very cool technology and great results especially on the big systems but even on smaller ones there are nice gains. Thanks Waiman and everyone who developed it.

Thanks,
Nick

Nicholas Piggin (6):
powerpc/pseries: move some PAPR paravirt functions to their own file
powerpc: move spinlock implementation to simple_spinlock powerpc/64s: implement queued spinlocks and rwlocks powerpc/pseries: implement paravirt qspinlocks for SPLPAR powerpc/qspinlock: optimised atomic_try_cmpxchg_lock that adds the
lock hint
powerpc: implement smp_cond_load_relaxed

 arch/powerpc/Kconfig                          |  15 +
 arch/powerpc/include/asm/Kbuild               |   1 +
 arch/powerpc/include/asm/atomic.h             |  28 ++
 arch/powerpc/include/asm/barrier.h            |  14 +
 arch/powerpc/include/asm/paravirt.h           |  87 +++++
 arch/powerpc/include/asm/qspinlock.h          |  91 ++++++
 arch/powerpc/include/asm/qspinlock_paravirt.h |   7 +
 arch/powerpc/include/asm/simple_spinlock.h    | 288 ++++++++++++++++
 .../include/asm/simple_spinlock_types.h       |  21 ++
 arch/powerpc/include/asm/spinlock.h           | 308 +-----------------
 arch/powerpc/include/asm/spinlock_types.h     |  17 +-
 arch/powerpc/lib/Makefile                     |   3 +
 arch/powerpc/lib/locks.c                      |  12 +-
 arch/powerpc/platforms/pseries/Kconfig        |   9 +-
 arch/powerpc/platforms/pseries/setup.c        |   4 +-
 include/asm-generic/qspinlock.h               |   4 +
 16 files changed, 588 insertions(+), 321 deletions(-)
 create mode 100644 arch/powerpc/include/asm/paravirt.h
 create mode 100644 arch/powerpc/include/asm/qspinlock.h
 create mode 100644 arch/powerpc/include/asm/qspinlock_paravirt.h
 create mode 100644 arch/powerpc/include/asm/simple_spinlock.h
 create mode 100644 arch/powerpc/include/asm/simple_spinlock_types.h
Signature · 1 line
2.23.0