Skip to content

Cleanup mlx5_ib main file

Leon Romanovsky linux-rdma lkml 1 version Applied

Status from this message: Applied to for-next, thanks

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 3 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/6RDMA/mlx5: Limit the scope of mlx5_ib_enable_driver functiondrivers/infiniband/hw/mlx5/main.c drivers/infiniband/hw/mlx5/mlx5_ib.h+12 -130 replies
2/6RDMA/mlx5: Separate restrack callbacks initialization from main.cdrivers/infiniband/hw/mlx5/main.c drivers/infiniband/hw/mlx5/mlx5_ib.h drivers/infiniband/hw/mlx5/restrack.c +1 more+46 -770 replies
3/6RDMA/mlx5: Separate counters from main.cdrivers/infiniband/hw/mlx5/Makefile drivers/infiniband/hw/mlx5/cmd.c drivers/infiniband/hw/mlx5/cmd.h +6 more+737 -7090 replies
4/6RDMA/mlx5: Separate flow steering logic from main.cdrivers/infiniband/hw/mlx5/Makefile drivers/infiniband/hw/mlx5/devx.c drivers/infiniband/hw/mlx5/devx.h +5 more+2579 -25570 replies
5/6RDMA/mlx5: Cleanup DEVX initialization flowdrivers/infiniband/hw/mlx5/devx.c drivers/infiniband/hw/mlx5/devx.h drivers/infiniband/hw/mlx5/main.c +1 more+51 -540 replies
6/6RDMA/mlx5: Delete one-time used functionsdrivers/infiniband/hw/mlx5/main.c+198 -2740 replies

Reviews trailers per patch

1 of 6 patches has a Reviewed-by or Acked-by.

PatchMaor Gottlieb
1/6R-b
2/6
3/6
4/6
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH rdma-next 0/6] Cleanup mlx5_ib main file

From: Leon Romanovsky <[email protected]>

Over the years, the main.c file grew above all imagination and was >8K LOC of the code. This caused to a huge burden while I started to work on ib_flow allocation patches.

This series implements long standing "internal" wish to move flow logic from the main to separate file.

Based on
https://lore.kernel.org/linux-rdma/[email protected]

Thanks

Leon Romanovsky (6):
RDMA/mlx5: Limit the scope of mlx5_ib_enable_driver function RDMA/mlx5: Separate restrack callbacks initialization from main.c RDMA/mlx5: Separate counters from main.c
RDMA/mlx5: Separate flow steering logic from main.c RDMA/mlx5: Cleanup DEVX initialization flow
RDMA/mlx5: Delete one-time used functions

 drivers/infiniband/hw/mlx5/Makefile   |    3 +-
 drivers/infiniband/hw/mlx5/cmd.c      |   12 -
 drivers/infiniband/hw/mlx5/cmd.h      |    1 -
 drivers/infiniband/hw/mlx5/counters.c |  709 +++++
 drivers/infiniband/hw/mlx5/counters.h |   17 +
 drivers/infiniband/hw/mlx5/devx.c     |  102 +-
 drivers/infiniband/hw/mlx5/devx.h     |   45 +
 drivers/infiniband/hw/mlx5/flow.c     |  765 -----
 drivers/infiniband/hw/mlx5/fs.c       | 2514 +++++++++++++++
 drivers/infiniband/hw/mlx5/fs.h       |   29 +
 drivers/infiniband/hw/mlx5/main.c     | 4112 +++++--------------------
 drivers/infiniband/hw/mlx5/mlx5_ib.h  |   76 +-
 drivers/infiniband/hw/mlx5/qp.c       |    1 +
 drivers/infiniband/hw/mlx5/qp.h       |    1 +
 drivers/infiniband/hw/mlx5/restrack.c |   29 +-
 drivers/infiniband/hw/mlx5/restrack.h |   13 +
 16 files changed, 4184 insertions(+), 4245 deletions(-)
 create mode 100644 drivers/infiniband/hw/mlx5/counters.c
 create mode 100644 drivers/infiniband/hw/mlx5/counters.h
 create mode 100644 drivers/infiniband/hw/mlx5/devx.h
 delete mode 100644 drivers/infiniband/hw/mlx5/flow.c
 create mode 100644 drivers/infiniband/hw/mlx5/fs.c
 create mode 100644 drivers/infiniband/hw/mlx5/fs.h
 create mode 100644 drivers/infiniband/hw/mlx5/restrack.h

--
2.26.2