Skip to content

crypto: mark ecb(arc4) skcipher as obsolete

Ard Biesheuvel linux-crypto linux-nfs netdev 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest7 patches 2 repliesIn review
  2. v27 patches 2 repliesSuperseded
  3. v1 RFC7 patches 9 repliesSuperseded

Changes in v3 from the cover letter

- depend on CRYPTO_USER_API not CRYPTO_USER
- rename CRYPTO_USER_ENABLE_OBSOLETE to CRYPTO_USER_API_ENABLE_OBSOLETE for clarity

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7staging/rtl8192e: switch to RC4 library interfacedrivers/staging/rtl8192e/Kconfig drivers/staging/rtl8192e/rtllib_crypt_tkip.c drivers/staging/rtl8192e/rtllib_crypt_wep.c+28 -1180 replies
2/7staging/rtl8192u: switch to RC4 library interfacedrivers/staging/rtl8192u/Kconfig drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c+27 -1190 replies
3/7SUNRPC: remove RC4-HMAC-MD5 support from KerberosVinclude/linux/sunrpc/gss_krb5.h include/linux/sunrpc/gss_krb5_enctypes.h net/sunrpc/Kconfig +6 more+16 -5300 replies
4/7crypto: n2 - remove ecb(arc4) supportdrivers/crypto/n2_core.c+0 -460 replies
5/7crypto: bcm-iproc - remove ecb(arc4) supportdrivers/crypto/bcm/cipher.c drivers/crypto/bcm/cipher.h drivers/crypto/bcm/spu.c +3 more+6 -1280 replies
6/7net: wireless: drop bogus CRYPTO_xxx Kconfig selectsdrivers/net/wireless/intel/ipw2x00/Kconfig drivers/net/wireless/intersil/hostap/Kconfig+0 -80 replies
7/7crypto: arc4 - mark ecb(arc4) skcipher as obsoletecrypto/Kconfig crypto/arc4.c+20 -01 reply

Reviews trailers per patch

3 of 7 patches have a Reviewed-by or Acked-by.

PatchGreg Kroah-HartmanJ. Bruce Fields
1/7A-b
2/7A-b
3/7A-b
4/7
5/7
6/7
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/7] crypto: mark ecb(arc4) skcipher as obsolete

RC4 hasn't aged very well, and is a poor fit for the skcipher API so it would be good if we could get rid of the ecb(arc4) drivers in the kernel at some point in the future. This prevents new users from creeping in, and allows us to improve the skcipher API without having to care too much about obsolete algorithms that may be difficult to support going forward.

So let's get rid of any remaining in-kernel users, either by switching them to the arc4 library API (for cases which simply cannot change algorithms, e.g., WEP), or dropping the code entirely. Also remove the remaining h/w accelerated implementations, and mark the generic s/w implementation as obsolete in Kconfig.

Changes since v2:
- depend on CRYPTO_USER_API not CRYPTO_USER
- rename CRYPTO_USER_ENABLE_OBSOLETE to CRYPTO_USER_API_ENABLE_OBSOLETE for clarity

Changes since RFC [0]:
- keep ecb(arc4) generic C implementation, and the associated test vectors, but print a warning about ecb(arc4) being obsolete so we can identify remaining users
- add a Kconfig option to en/disable obsolete algorithms that are only kept around to prevent breaking users that rely on it via the socket interface
- add a patch to clean up some bogus Kconfig dependencies
- add acks to patches #1, #2 and #3

[0] https://lore.kernel.org/driverdev-devel/[email protected]/

Cc Herbert Xu <[email protected]>
Cc "David S. Miller" <[email protected]>
Cc Greg Kroah-Hartman <[email protected]>
Cc Trond Myklebust <[email protected]>
Cc Anna Schumaker <[email protected]>
Cc "J. Bruce Fields" <[email protected]>
Cc Chuck Lever <[email protected]>
Cc Eric Biggers <[email protected]>
Cc Arnd Bergmann <[email protected]>

Ard Biesheuvel (7):
staging/rtl8192e: switch to RC4 library interface staging/rtl8192u: switch to RC4 library interface
SUNRPC: remove RC4-HMAC-MD5 support from KerberosV
crypto: n2 - remove ecb(arc4) support
crypto: bcm-iproc - remove ecb(arc4) support
net: wireless: drop bogus CRYPTO_xxx Kconfig selects
crypto: arc4 - mark ecb(arc4) skcipher as obsolete

 crypto/Kconfig                                |  10 +
 crypto/arc4.c                                 |  10 +
 drivers/crypto/bcm/cipher.c                   |  96 +-----
 drivers/crypto/bcm/cipher.h                   |   1 -
 drivers/crypto/bcm/spu.c                      |  23 +-
 drivers/crypto/bcm/spu.h                      |   1 -
 drivers/crypto/bcm/spu2.c                     |  12 +-
 drivers/crypto/bcm/spu2.h                     |   1 -
 drivers/crypto/n2_core.c                      |  46 ---
 drivers/net/wireless/intel/ipw2x00/Kconfig    |   4 -
 drivers/net/wireless/intersil/hostap/Kconfig  |   4 -
 drivers/staging/rtl8192e/Kconfig              |   4 +-
 drivers/staging/rtl8192e/rtllib_crypt_tkip.c  |  70 +----
 drivers/staging/rtl8192e/rtllib_crypt_wep.c   |  72 +----
 drivers/staging/rtl8192u/Kconfig              |   1 +
 .../rtl8192u/ieee80211/ieee80211_crypt_tkip.c |  81 +----
 .../rtl8192u/ieee80211/ieee80211_crypt_wep.c  |  64 +---
 include/linux/sunrpc/gss_krb5.h               |  11 -
 include/linux/sunrpc/gss_krb5_enctypes.h      |   9 +-
 net/sunrpc/Kconfig                            |   1 -
 net/sunrpc/auth_gss/gss_krb5_crypto.c         | 276 ------------------
 net/sunrpc/auth_gss/gss_krb5_mech.c           |  95 ------
 net/sunrpc/auth_gss/gss_krb5_seal.c           |   1 -
 net/sunrpc/auth_gss/gss_krb5_seqnum.c         |  87 ------
 net/sunrpc/auth_gss/gss_krb5_unseal.c         |   1 -
 net/sunrpc/auth_gss/gss_krb5_wrap.c           |  65 +----
 26 files changed, 97 insertions(+), 949 deletions(-)
Signature · 1 line
2.17.1