Skip to content

net: rmnet: fix interface leak for rmnet module

Taehee Yoo netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2net: rmnet: fix lower interface leakdrivers/net/ethernet/qualcomm/rmnet/rmnet_config.c+12 -90 replies
2/2net: rmnet: do not allow to add multiple bridge interfacesdrivers/net/ethernet/qualcomm/rmnet/rmnet_config.c+5 -00 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchSubash Abhinov Kasiviswanathan
SeriesR-b
1/2
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH net 0/2] net: rmnet: fix interface leak for rmnet module

There are two problems in rmnet module that they occur the leak of a lower interface.
The symptom is the same, which is the leak of a lower interface. But there are two different real problems.
This patchset is to fix these real problems.

1. Do not allow to have different two modes.
As a lower interface of rmnet, there are two modes that they are VND and BRIDGE.
One interface can have only one mode.
But in the current rmnet, there is no code to prevent to have two modes in one lower interface.
So, interface leak occurs.

2. Do not allow to add multiple bridge interfaces. rmnet can have only two bridge interface.
If an additional bridge interface is tried to be attached, rmnet should deny it.
But there is no code to do that.
So, interface leak occurs.

Taehee Yoo (2):
net: rmnet: fix lower interface leak
net: rmnet: do not allow to add multiple bridge interfaces

 .../net/ethernet/qualcomm/rmnet/rmnet_config.c | 18 +++++++++++++-----
 1 file changed, 13 insertions(+), 5 deletions(-)
Signature · 1 line
2.17.1