Skip to content

RFC hw: Mark the device with no migratable fields

Philippe Mathieu-Daudé qemu-arm qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 RFC Latest20 patches 11 repliesIn review
  2. v118 patches 13 repliesSuperseded

Changes in v2 from the cover letter

- Tried to address Dave and Daniel comments
- Added Peter R-b
- Handle GPEX device

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/20migration/vmstate: Restrict vmstate_dummy to user-modeinclude/hw/core/cpu.h include/migration/vmstate.h stubs/vmstate.c+7 -34 replies
2/20hw/core/qdev: Add vmstate_qdev_no_state_to_migratehw/core/qdev.c include/hw/qdev-core.h include/migration/vmstate.h +2 more+20 -02 replies
3/20hw/arm/armv7m: Mark the device with no migratable fieldshw/arm/armv7m.c+1 -00 replies
4/20hw/arm/aspeed_soc: Mark the device with no migratable fieldshw/arm/aspeed_soc.c+1 -01 reply
5/20hw/arm/bcm283x: Mark devices with no migratable fieldshw/arm/bcm2835_peripherals.c hw/arm/bcm2836.c include/hw/arm/bcm2836.h+5 -20 replies
6/20hw/arm/msf2-soc: Mark the device with no migratable fieldshw/arm/msf2-soc.c include/hw/arm/msf2-soc.h+7 -50 replies
7/20hw/core/split-irq: Mark the device with no migratable fieldshw/core/split-irq.c+1 -00 replies
8/20hw/cpu/a9mpcore: Mark the device with no migratable fieldshw/cpu/a9mpcore.c include/hw/cpu/a9mpcore.h+3 -10 replies
9/20hw/cpu/cluster: Mark the device with no migratable fieldshw/cpu/cluster.c+1 -00 replies
10/20hw/usb/hcd-ohci: Mark the device with no migratable fieldshw/usb/hcd-ohci.c hw/usb/hcd-ohci.h+3 -01 reply
11/20hw/intc/arm_gicv2m: Mark the device with no migratable fieldshw/intc/arm_gicv2m.c+2 -00 replies
12/20hw/misc/armsse-cpuid: Mark the device with no migratable fieldshw/misc/armsse-cpuid.c+1 -00 replies
13/20hw/misc/iotkit-sysinfo: Mark the device with no migratable fieldshw/misc/iotkit-sysinfo.c+1 -00 replies
14/20hw/misc/unimp: Mark the device with no migratable fieldshw/misc/unimp.c+1 -00 replies
15/20hw/nubus/mac-nubus-bridge: Mark the device with no migratable fieldshw/nubus/mac-nubus-bridge.c+1 -01 reply
16/20hw/sparc64/sun4u: Mark devices with no migratable fieldshw/sparc64/sun4u.c+5 -11 reply
17/20hw/pci-host/gpex: Mark device with no migratable fieldshw/pci-host/gpex.c+1 -00 replies
18/20hw/core/qdev: Display warning for devices missing migration stateconfigure hw/core/qdev.c meson.build+16 -00 replies
19/20stubs/vmstate: Add VMSTATE_END_OF_LIST to vmstate_user_mode_cpu_dummystubs/vmstate.c+6 -11 reply
20/20migration/vmstate: Simplify vmstate for user-mode CPUinclude/hw/core/cpu.h include/migration/vmstate.h stubs/vmstate.c+1 -130 replies

Reviews trailers per patch

8 of 20 patches have a Reviewed-by or Acked-by.

PatchPeter MaydellArtyom TarasenkoDr. David Alan GilbertLaurent VivierCédric Le Goater
1/20R-b
2/20
3/20R-b
4/20R-b
5/20
6/20
7/20R-b
8/20
9/20
10/20R-b
11/20
12/20
13/20
14/20
15/20R-b
16/20R-b
17/20
18/20
19/20R-b
20/20

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v2 thread

Cover letter [RFC PATCH v2 00/20] hw: Mark the device with no migratable fields

Since v1:
- Tried to address Dave and Daniel comments
- Added Peter R-b
- Handle GPEX device

This is a proof-of-concept after chatting with Peter Maydell on IRC last year.

Introduce the vmstate_no_state_to_migrate structure, and a reference to it: vmstate_qdev_no_state_to_migrate. Use this reference in devices with no fields to migrate.

This is useful to catch devices missing vmstate, such:
- ads7846
- mcf-uart
- mcf-fec
- versatile_i2c
- ...

v1: https://www.mail-archive.com/[email protected]/msg719788.html

Philippe Mathieu-Daudé (20):
migration/vmstate: Restrict vmstate_dummy to user-mode hw/core/qdev: Add vmstate_qdev_no_state_to_migrate hw/arm/armv7m: Mark the device with no migratable fields hw/arm/aspeed_soc: Mark the device with no migratable fields hw/arm/bcm283x: Mark devices with no migratable fields hw/arm/msf2-soc: Mark the device with no migratable fields hw/core/split-irq: Mark the device with no migratable fields hw/cpu/a9mpcore: Mark the device with no migratable fields hw/cpu/cluster: Mark the device with no migratable fields hw/usb/hcd-ohci: Mark the device with no migratable fields hw/intc/arm_gicv2m: Mark the device with no migratable fields hw/misc/armsse-cpuid: Mark the device with no migratable fields hw/misc/iotkit-sysinfo: Mark the device with no migratable fields hw/misc/unimp: Mark the device with no migratable fields hw/nubus/mac-nubus-bridge: Mark the device with no migratable fields hw/sparc64/sun4u: Mark devices with no migratable fields hw/pci-host/gpex: Mark device with no migratable fields hw/core/qdev: Display warning for devices missing migration state stubs/vmstate: Add VMSTATE_END_OF_LIST to vmstate_user_mode_cpu_dummy migration/vmstate: Simplify vmstate for user-mode CPU

 configure                    | 10 ++++++++++
 meson.build                  |  1 +
 hw/usb/hcd-ohci.h            |  2 ++
 include/hw/arm/bcm2836.h     |  5 +++--
 include/hw/arm/msf2-soc.h    | 11 ++++++-----
 include/hw/core/cpu.h        |  2 +-
 include/hw/cpu/a9mpcore.h    |  3 ++-
 include/hw/qdev-core.h       |  2 ++
 include/migration/vmstate.h  |  2 +-
 hw/arm/armv7m.c              |  1 +
 hw/arm/aspeed_soc.c          |  1 +
 hw/arm/bcm2835_peripherals.c |  1 +
 hw/arm/bcm2836.c             |  1 +
 hw/arm/msf2-soc.c            |  1 +
 hw/core/qdev.c               |  8 ++++++++
 hw/core/split-irq.c          |  1 +
 hw/cpu/a9mpcore.c            |  1 +
 hw/cpu/cluster.c             |  1 +
 hw/intc/arm_gicv2m.c         |  2 ++
 hw/misc/armsse-cpuid.c       |  1 +
 hw/misc/iotkit-sysinfo.c     |  1 +
 hw/misc/unimp.c              |  1 +
 hw/nubus/mac-nubus-bridge.c  |  1 +
 hw/pci-host/gpex.c           |  1 +
 hw/sparc64/sun4u.c           |  6 +++++-
 hw/usb/hcd-ohci.c            |  1 +
 migration/vmstate.c          |  7 +++++++
 stubs/vmstate.c              |  7 ++++++-
 28 files changed, 70 insertions(+), 12 deletions(-)
Signature · 1 line
2.26.2