Skip to content

net: ipa: fix HOLB timer register use

Alex Elder lkml netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2net: ipa: introduce ipa_clock_rate()drivers/net/ipa/ipa_clock.c drivers/net/ipa/ipa_clock.h+14 -00 replies
2/2net: ipa: fix HOLB timer calculationdrivers/net/ipa/ipa_endpoint.c+43 -350 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH net-next 0/2] net: ipa: fix HOLB timer register use

The function ipa_reg_init_hol_block_timer_val() generates the value to write into the HOL_BLOCK_TIMER endpoint configuration register, to represent a given timeout value (in microseconds). It only supports a timer value of 0 though, in part because that's sufficient, but mainly because there was some confusion about how the register is formatted in newer hardware.

I got clarification about the register format, so this series fixes ipa_reg_init_hol_block_timer_val() to work for any supported delay value.

The delay is based on the IPA core clock, so determining the value to write for a given period requires access to the current core clock rate. So the first patch just creates a new function to provide that.

-Alex

Alex Elder (2):
net: ipa: introduce ipa_clock_rate()
net: ipa: fix HOLB timer calculation

 drivers/net/ipa/ipa_clock.c    |  6 +++
 drivers/net/ipa/ipa_clock.h    |  8 ++++
 drivers/net/ipa/ipa_endpoint.c | 78 +++++++++++++++++++---------------
 3 files changed, 57 insertions(+), 35 deletions(-)
Signature · 1 line
2.25.1