Skip to content

target/xtensa: implement double precision FPU

Max Filippov qemu-devel 4 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest20 of 22 patches 0 repliesNew
  2. v320 of 21 patches 3 repliesSuperseded
  3. v21 of 21 patches 1 replySuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v121 patches20 repliesSuperseded

Changes in v4 from the cover letter

- split DFPU option addition into a separate patch, change DFP unit detection logic
- avoid calling set_use_first_nan on every FPU operation in FPU2000 and single-precision only DFPU configurations

20 of 22 patches are in this archive. The cover letter announces 22.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/22softfloat: make NO_SIGNALING_NANS runtime propertyfpu/softfloat-specialize.inc.c include/fpu/softfloat-helpers.h include/fpu/softfloat-types.h+128 -1130 replies
2/22softfloat: pass float_status pointer to pickNaNfpu/softfloat-specialize.inc.c fpu/softfloat.c include/fpu/softfloat-helpers.h +1 more+31 -70 replies
3/22softfloat: add xtensa specialization for pickNaNMulAddfpu/softfloat-specialize.inc.c+26 -00 replies
4/22target/xtensa: add geometry to xtensa_get_regfile_by_nametarget/xtensa/cpu.h target/xtensa/helper.c target/xtensa/translate.c+31 -100 replies
5/22target/xtensa: support copying registers up to 64 bits widetarget/xtensa/cpu.h target/xtensa/translate.c+22 -50 replies
6/22target/xtensa: rename FPU2000 translators and helperstarget/xtensa/fpu_helper.c target/xtensa/helper.h target/xtensa/translate.c+57 -550 replies
7/22target/xtensa: move FSR/FCR register accessorstarget/xtensa/translate.c+32 -320 replies
8/22target/xtensa: don't access BR regfile directlytarget/xtensa/fpu_helper.c target/xtensa/helper.h target/xtensa/translate.c+42 -340 replies
9/22target/xtensa: add DFPU optiontarget/xtensa/cpu.h target/xtensa/overlay_tool.h+25 -00 replies
10/22target/xtensa: add DFPU registers and opcodestarget/xtensa/cpu.c target/xtensa/cpu.h target/xtensa/fpu_helper.c +3 more+1413 -340 replies
11/22target/xtensa: implement FPU division and square roottarget/xtensa/fpu_helper.c target/xtensa/helper.h target/xtensa/translate.c+132 -00 replies
12/22tests/tcg/xtensa: fix test execution on ISStests/tcg/xtensa/macros.inc+5 -50 replies
13/22tests/tcg/xtensa: update test_fp0_arith for DFPUtests/tcg/xtensa/fpu.h tests/tcg/xtensa/test_fp0_arith.S+223 -970 replies
14/22tests/tcg/xtensa: expand madd teststests/tcg/xtensa/test_fp0_arith.S+104 -00 replies
15/22tests/tcg/xtensa: update test_fp0_conv for DFPUtests/tcg/xtensa/test_fp0_conv.S+155 -1440 replies
16/22tests/tcg/xtensa: update test_fp1 for DFPUtests/tcg/xtensa/test_fp1.S+34 -280 replies
17/22tests/tcg/xtensa: update test_lsc for DFPUtests/tcg/xtensa/test_lsc.S+34 -130 replies
18/22tests/tcg/xtensa: add fp0 div and sqrt teststests/tcg/xtensa/test_fp0_div.S tests/tcg/xtensa/test_fp0_sqrt.S+158 -00 replies
19/22tests/tcg/xtensa: test double precision load/storetests/tcg/xtensa/test_lsc.S+123 -00 replies
20/22tests/tcg/xtensa: add DFP0 arithmetic teststests/tcg/xtensa/test_dfp0_arith.S+162 -00 replies

Reviews trailers per patch

6 of 20 patches have a Reviewed-by or Acked-by.

PatchAlex BennéePhilippe Mathieu-DaudéRichard Henderson
1/22R-b R-b R-b
2/22R-b R-b
3/22R-b
4/22
5/22
6/22R-b
7/22R-b
8/22R-b
9/22
10/22
11/22
12/22
13/22
14/22
15/22
16/22
17/22
18/22
19/22
20/22

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v4 thread

Cover letter [PATCH v4 00/22] target/xtensa: implement double precision FPU

Hello,

this series implements double precision floating point unit option for target/xtensa, updates FPU tests and adds two new CPU cores, one with FPU2000 option and one with DFPU option.

It is tagged xtensa-5.1-dfp-v4 in the qemu-xtensa tree at
git://github.com/OSLL/qemu-xtensa.git

I don't post the last two patches as they are too big for the list, they can be found in the git tree mentioned above.

Changes v3->v4:
- split DFPU option addition into a separate patch, change DFP unit detection logic
- avoid calling set_use_first_nan on every FPU operation in FPU2000 and single-precision only DFPU configurations

Changes v2->v3:
- handle infzero case in pickNaNMulAdd properly and reword commit message
- add more infzero tests for FPU2000 and DFPU
- fix test names in test_dfp0_arith.S
- add licenses to newly imported cores
- rename DE_233L_FPU to de233_fpu to be more consistent with other core names

Changes v1->v2:
- use inline function for no_signaling_nans property to allow for constant folding on architectures that have this property fixed.

Max Filippov (22):
softfloat: make NO_SIGNALING_NANS runtime property
softfloat: pass float_status pointer to pickNaN
softfloat: add xtensa specialization for pickNaNMulAdd target/xtensa: add geometry to xtensa_get_regfile_by_name target/xtensa: support copying registers up to 64 bits wide target/xtensa: rename FPU2000 translators and helpers target/xtensa: move FSR/FCR register accessors target/xtensa: don't access BR regfile directly target/xtensa: add DFPU option
target/xtensa: add DFPU registers and opcodes target/xtensa: implement FPU division and square root tests/tcg/xtensa: fix test execution on ISS tests/tcg/xtensa: update test_fp0_arith for DFPU tests/tcg/xtensa: expand madd tests tests/tcg/xtensa: update test_fp0_conv for DFPU tests/tcg/xtensa: update test_fp1 for DFPU tests/tcg/xtensa: update test_lsc for DFPU tests/tcg/xtensa: add fp0 div and sqrt tests tests/tcg/xtensa: test double precision load/store tests/tcg/xtensa: add DFP0 arithmetic tests target/xtensa: import de233_fpu core target/xtensa: import DSP3400 core

 fpu/softfloat-specialize.inc.c                |    285 +-
 fpu/softfloat.c                               |      2 +-
 include/fpu/softfloat-helpers.h               |     10 +
 include/fpu/softfloat-types.h                 |      8 +-
 target/xtensa/Makefile.objs                   |      2 +
 target/xtensa/core-de233_fpu.c                |     58 +
 target/xtensa/core-de233_fpu/core-isa.h       |    727 +
 target/xtensa/core-de233_fpu/core-matmap.h    |    717 +
 target/xtensa/core-de233_fpu/gdb-config.inc.c |    277 +
 .../core-de233_fpu/xtensa-modules.inc.c       |  20758 ++
 target/xtensa/core-dsp3400.c                  |     58 +
 target/xtensa/core-dsp3400/core-isa.h         |    452 +
 target/xtensa/core-dsp3400/core-matmap.h      |    312 +
 target/xtensa/core-dsp3400/gdb-config.inc.c   |    400 +
 .../xtensa/core-dsp3400/xtensa-modules.inc.c  | 171906 +++++++++++++++
 target/xtensa/cpu.c                           |      5 +
 target/xtensa/cpu.h                           |      8 +-
 target/xtensa/fpu_helper.c                    |    342 +-
 target/xtensa/helper.c                        |      4 +-
 target/xtensa/helper.h                        |     58 +-
 target/xtensa/overlay_tool.h                  |     24 +
 target/xtensa/translate.c                     |   1437 +-
 tests/tcg/xtensa/fpu.h                        |    142 +
 tests/tcg/xtensa/macros.inc                   |     10 +-
 tests/tcg/xtensa/test_dfp0_arith.S            |    162 +
 tests/tcg/xtensa/test_fp0_arith.S             |    282 +-
 tests/tcg/xtensa/test_fp0_conv.S              |    299 +-
 tests/tcg/xtensa/test_fp0_div.S               |     82 +
 tests/tcg/xtensa/test_fp0_sqrt.S              |     76 +
 tests/tcg/xtensa/test_fp1.S                   |     62 +-
 tests/tcg/xtensa/test_lsc.S                   |    170 +-
 31 files changed, 198581 insertions(+), 554 deletions(-)
 create mode 100644 target/xtensa/core-de233_fpu.c
 create mode 100644 target/xtensa/core-de233_fpu/core-isa.h
 create mode 100644 target/xtensa/core-de233_fpu/core-matmap.h
 create mode 100644 target/xtensa/core-de233_fpu/gdb-config.inc.c
 create mode 100644 target/xtensa/core-de233_fpu/xtensa-modules.inc.c
 create mode 100644 target/xtensa/core-dsp3400.c
 create mode 100644 target/xtensa/core-dsp3400/core-isa.h
 create mode 100644 target/xtensa/core-dsp3400/core-matmap.h
 create mode 100644 target/xtensa/core-dsp3400/gdb-config.inc.c
 create mode 100644 target/xtensa/core-dsp3400/xtensa-modules.inc.c
 create mode 100644 tests/tcg/xtensa/fpu.h
 create mode 100644 tests/tcg/xtensa/test_dfp0_arith.S
 create mode 100644 tests/tcg/xtensa/test_fp0_div.S
 create mode 100644 tests/tcg/xtensa/test_fp0_sqrt.S
Signature · 1 line
2.20.1