Skip to content

drm/mgag200: Inline prepare/commit helpers

Thomas Zimmermann dri-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7drm/mgag200: Don't write-protect CRTC 0-7 while in mga_crtc_prepare()drivers/gpu/drm/mgag200/mgag200_drv.h drivers/gpu/drm/mgag200/mgag200_mode.c drivers/gpu/drm/mgag200/mgag200_reg.h+18 -90 replies
2/7drm/mgag200: Move PLL setup out of mode-setting functiondrivers/gpu/drm/mgag200/mgag200_mode.c+2 -30 replies
3/7drm/mgag200: Don't set or clear <scroff> field during modesetdrivers/gpu/drm/mgag200/mgag200_mode.c+3 -390 replies
4/7drm/mgag200: Split DPMS function into helpersdrivers/gpu/drm/mgag200/mgag200_mode.c drivers/gpu/drm/mgag200/mgag200_reg.h+45 -310 replies
5/7drm/mgag200: Set/clear <syncrst> field in display enable/disable helpersdrivers/gpu/drm/mgag200/mgag200_mode.c drivers/gpu/drm/mgag200/mgag200_reg.h+14 -60 replies
6/7drm/mgag200: Rename G200WB prepare/commit functiondrivers/gpu/drm/mgag200/mgag200_mode.c+4 -60 replies
7/7drm/mgag200: Inline mga_crtc_{prepare, commit}() into enable functiondrivers/gpu/drm/mgag200/mgag200_mode.c+7 -320 replies

Reviews trailers per patch

None of the 7 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchLyude Paul
SeriesR-b
1/7
2/7
3/7
4/7
5/7
6/7
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/7] drm/mgag200: Inline prepare/commit helpers

Mgag200's modesetting still utilizes the prepare and commit functions that were part of the non-atomic interface. This patchset integrates them into the simple-display's enable function.

Patch 1 disables CRTC write protection once when initializing the registers. Before, CRTC registers were temporarily write-protected for no apparent reason.

The screen is toggled on and off multiple times while setting a mode. Patch 3 removes any intermediate screen on/off changes.

In patch 4, DPMS functionality is reduced to on an off. The DPMS helper function implemements on, off, suspend and standby. In atomic modesetting, only on and off is required.

Tested on G200SE HW with Xorg, Weston and fbdev.

Thomas Zimmermann (7):
drm/mgag200: Don't write-protect CRTC 0-7 while in mga_crtc_prepare() drm/mgag200: Move PLL setup out of mode-setting function drm/mgag200: Don't set or clear <scroff> field during modeset drm/mgag200: Split DPMS function into helpers
drm/mgag200: Set/clear <syncrst> field in display enable/disable
helpers
drm/mgag200: Rename G200WB prepare/commit function drm/mgag200: Inline mga_crtc_{prepare,commit}() into enable function

 drivers/gpu/drm/mgag200/mgag200_drv.h  |   6 +
 drivers/gpu/drm/mgag200/mgag200_mode.c | 168 +++++++++----------------
 drivers/gpu/drm/mgag200/mgag200_reg.h  |  11 ++
 3 files changed, 76 insertions(+), 109 deletions(-)

--
2.27.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel