Skip to content

virtio: non-legacy device handling

Cornelia Huck qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 10 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2virtio: list legacy-capable deviceshw/virtio/virtio.c include/hw/virtio/virtio.h+27 -00 replies
2/2virtio: verify that legacy support is not accidentally onhw/s390x/virtio-ccw.c hw/virtio/virtio-pci.c+10 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] virtio: non-legacy device handling

As discussed in "virtio-fs: force virtio 1.x usage", it seems like a good idea to make sure that any new virtio device (which does not support legacy virtio) is indeed a non-transitional device, just to catch accidental misconfigurations. We can easily compile a list of virtio devices with legacy support and have transports verify in their plugged callbacks that legacy support is off for any device not in that list.

Most new virtio devices force non-transitional already, so nothing changes for them. vhost-user-fs-pci even does not allow to configure a non-transitional device, so it is fine as well.

One problematic device, however, is virtio-iommu-pci. It currently offers both the transitional and the non-transitional variety of the device, and does not force anything. I'm unsure whether we should consider transitional virtio-iommu unsupported, or if we should add some compat handling. (The support for legacy or not generally may change based upon the bus, IIUC, so I'm unsure how to come up with something generic.)

Cornelia Huck (2):
virtio: list legacy-capable devices
virtio: verify that legacy support is not accidentally on

 hw/s390x/virtio-ccw.c      |  6 ++++++
 hw/virtio/virtio-pci.c     |  4 ++++
 hw/virtio/virtio.c         | 25 +++++++++++++++++++++++++
 include/hw/virtio/virtio.h |  2 ++
 4 files changed, 37 insertions(+)
Signature · 1 line
2.25.4