Skip to content

gpiolib: cdev: pre-uAPI v2 cleanups

Kent Gibson linux-gpio lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest17 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/17gpiolib: move gpiolib-sysfs function declarations into their own headerdrivers/gpio/gpiolib-sysfs.c drivers/gpio/gpiolib-sysfs.h drivers/gpio/gpiolib.c +1 more+26 -180 replies
2/17gpiolib: cdev: sort includesdrivers/gpio/gpiolib-cdev.c+11 -110 replies
3/17gpiolib: cdev: minor indentation fixesdrivers/gpio/gpiolib-cdev.c+14 -140 replies
4/17gpiolib: cdev: refactor gpiohandle_flags_to_desc_flagsdrivers/gpio/gpiolib-cdev.c+19 -410 replies
5/17gpiolib: cdev: rename 'filep' and 'filp' to 'file' to be consistent with other usedrivers/gpio/gpiolib-cdev.c+35 -350 replies
6/17gpiolib: cdev: rename numdescs to num_descsdrivers/gpio/gpiolib-cdev.c+10 -100 replies
7/17gpiolib: cdev: remove pointless decrement of idrivers/gpio/gpiolib-cdev.c+0 -20 replies
8/17gpiolib: cdev: use blocking notifier call chain instead of atomicdrivers/gpio/gpiolib-cdev.c drivers/gpio/gpiolib.c drivers/gpio/gpiolib.h+20 -201 reply
9/17gpiolib: cdev: rename priv to cdevdrivers/gpio/gpiolib-cdev.c+45 -450 replies
10/17gpiolib: cdev: fix minor race in GET_LINEINFO_WATCHdrivers/gpio/gpiolib-cdev.c+5 -50 replies
11/17gpiolib: cdev: remove recalculation of offsetdrivers/gpio/gpiolib-cdev.c+7 -130 replies
12/17gpiolib: cdev: refactor linehandle cleanup into linehandle_freedrivers/gpio/gpiolib-cdev.c+19 -200 replies
13/17gpiolib: cdev: refactor lineevent cleanup into lineevent_freedrivers/gpio/gpiolib-cdev.c+21 -230 replies
14/17gpio: uapi: fix misplaced comment lineinclude/uapi/linux/gpio.h+1 -10 replies
15/17tools: gpio: fix spurious close warning in lsgpiotools/gpio/lsgpio.c+2 -10 replies
16/17tools: gpio: fix spurious close warning in gpio-utilstools/gpio/gpio-utils.c+2 -20 replies
17/17tools: gpio: fix spurious close warning in gpio-event-montools/gpio/gpio-event-mon.c+2 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/17] gpiolib: cdev: pre-uAPI v2 cleanups

This collection of patches provides improvements to or address minor problems in gpiolib-cdev.

The majority of the patches (1-7, 9-11) have been pulled directly from my "gpio: cdev: add uAPI V2" patch set, as they are not related to any uAPI changes.
The remaining patches were either split out of the remaining patches from that set, as they are not directly part of the uAPI changes, or were inspired by fixes for issues in that set, or were only noticed subsequent to that set.

Changes since "gpio: cdev: add uAPI V2":
- rebase onto latest gpio/devel
- fix typo in patch 1 commit description
- replace patch 8 with the blocking notifier call chain patch
- rename priv to cdev instead of gcdev in patch 9
- fix error handling in patch 10
- add patches 12 to 17

Kent Gibson (17):
gpiolib: move gpiolib-sysfs function declarations into their own
header
gpiolib: cdev: sort includes
gpiolib: cdev: minor indentation fixes
gpiolib: cdev: refactor gpiohandle_flags_to_desc_flags
gpiolib: cdev: rename 'filep' and 'filp' to 'file' to be consistent
with other use
gpiolib: cdev: rename numdescs to num_descs
gpiolib: cdev: remove pointless decrement of i
gpiolib: cdev: use blocking notifier call chain instead of atomic
gpiolib: cdev: rename priv to cdev
gpiolib: cdev: fix minor race in GET_LINEINFO_WATCH
gpiolib: cdev: remove recalculation of offset
gpiolib: cdev: refactor linehandle cleanup into linehandle_free
gpiolib: cdev: refactor lineevent cleanup into lineevent_free
gpio: uapi: fix misplaced comment line
tools: gpio: fix spurious close warning in lsgpio
tools: gpio: fix spurious close warning in gpio-utils
tools: gpio: fix spurious close warning in gpio-event-mon

 drivers/gpio/gpiolib-cdev.c  | 385 ++++++++++++++++-------------------
 drivers/gpio/gpiolib-sysfs.c |   1 +
 drivers/gpio/gpiolib-sysfs.h |  24 +++
 drivers/gpio/gpiolib.c       |  15 +-
 drivers/gpio/gpiolib.h       |  20 +-
 include/uapi/linux/gpio.h    |   2 +-
 tools/gpio/gpio-event-mon.c  |   3 +-
 tools/gpio/gpio-utils.c      |   4 +-
 tools/gpio/lsgpio.c          |   3 +-
 9 files changed, 217 insertions(+), 240 deletions(-)
 create mode 100644 drivers/gpio/gpiolib-sysfs.h

base-commit: b239e4454e59bc85d466eb5630da46f6a876df77

Signature · 1 line
2.27.0