Skip to content

drm/ast: Managed MM

Thomas Zimmermann dri-devel stable 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 2 repliesIn review
  2. v16 patches 4 repliesSuperseded

Changes in v2 from the cover letter

* reworked managed VRAM MM; new interface name, returns errno code, improved documentation (Sam)

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6drm/vram-helper: Managed vram helpersdrivers/gpu/drm/drm_gem_vram_helper.c include/drm/drm_gem_vram_helper.h+51 -360 replies
2/6drm/ast: Rename ast_ttm.c to ast_mm.cdrivers/gpu/drm/ast/Makefile drivers/gpu/drm/ast/ast_mm.c+1 -10 replies
3/6drm/ast: Use managed VRAM-helper initializationdrivers/gpu/drm/ast/ast_mm.c+3 -80 replies
4/6drm/ast: Move VRAM size detection to ast_mm.cdrivers/gpu/drm/ast/ast_drv.h drivers/gpu/drm/ast/ast_main.c drivers/gpu/drm/ast/ast_mm.c+46 -380 replies
5/6drm/ast: Initialize DRAM type before posting GPUdrivers/gpu/drm/ast/ast_main.c+3 -30 replies
6/6drm/ast: Use managed MM initializationdrivers/gpu/drm/ast/ast_drv.h drivers/gpu/drm/ast/ast_main.c drivers/gpu/drm/ast/ast_mm.c+12 -130 replies

Reviews trailers per patch

1 of 6 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchBenjamin HerrenschmidtSam Ravnborg
SeriesR-b
1/6
2/6
3/6
4/6
5/6A-b
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/6] drm/ast: Managed MM

This is the second patchset for converting ast to managed DRM interfaces. This one addresses memory management. There will be another, final round of patches for converting DRM device structures as well.

Patch #1 introduces managed initialization for VRAM MM. Other drivers using the VRAM helpers should be converted to this at some point.

Patches #2 to #4 do some preparation that make ast look slightly nicer.

Patch #5 fixes a long-standing bug that I found as part of the rework. Posting the GPU requires information about the installed DRAM. So the DRAM detection has to run before the GPU-posting code. This got reversed by a fix in v4.11. The patch restores the original correct order of these operations. As the GPU is usually posted by the VGA BIOS, the problem might not have shown up in practice.

With all the cleanups in place, patch #6 switches memory management to mnaged interfaces.

Tested on AST2100 HW.

v2:
* reworked managed VRAM MM; new interface name, returns errno code, improved documentation (Sam)

Thomas Zimmermann (6):
drm/vram-helper: Managed vram helpers drm/ast: Rename ast_ttm.c to ast_mm.c drm/ast: Use managed VRAM-helper initialization drm/ast: Move VRAM size detection to ast_mm.c drm/ast: Initialize DRAM type before posting GPU drm/ast: Use managed MM initialization

 drivers/gpu/drm/ast/Makefile                |  2 +-
 drivers/gpu/drm/ast/ast_drv.h               |  2 -
 drivers/gpu/drm/ast/ast_main.c              | 45 ++---------
 drivers/gpu/drm/ast/{ast_ttm.c => ast_mm.c} | 77 ++++++++++++++-----
 drivers/gpu/drm/drm_gem_vram_helper.c       | 84 ++++++++++++---------
 include/drm/drm_gem_vram_helper.h           |  3 +
 6 files changed, 115 insertions(+), 98 deletions(-)
 rename drivers/gpu/drm/ast/{ast_ttm.c => ast_mm.c} (63%)

--
2.27.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel