Skip to content

Improvements for MAX77620 GPIO driver

Dmitry Osipenko linux-gpio linux-tegra lkml 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest6 patches 3 repliesIn review
  2. v36 patches 11 repliesSuperseded
  3. v22 patches 3 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v15 patches13 repliesSuperseded

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6gpio: max77620: Replace 8 with MAX77620_GPIO_NRdrivers/gpio/gpio-max77620.c+3 -30 replies
2/6gpio: max77620: Fix missing release of interruptdrivers/gpio/gpio-max77620.c+3 -20 replies
3/6gpio: max77620: Don't set of_nodedrivers/gpio/gpio-max77620.c+1 -40 replies
4/6gpio: max77620: Don't shadow error code of platform_get_irq()drivers/gpio/gpio-max77620.c+6 -40 replies
5/6gpio: max77620: Use irqchip templatedrivers/gpio/gpio-max77620.c+6 -81 reply
6/6gpio: max77620: Initialize hardware state of interruptsdrivers/gpio/gpio-max77620.c+25 -00 replies

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchAndy ShevchenkoLaxman Dewangan
1/6R-b A-b
2/6R-b A-b
3/6R-b A-b
4/6R-b A-b
5/6R-b A-b
6/6R-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/6] Improvements for MAX77620 GPIO driver

Hello!

This series addresses a problem that I discovered on Nexus 7 device where GPIO interrupts may be left enabled after bootloader and the driver isn't prepared to this. It also makes a small improvements to the code, fixes the non-released interrupt bug and converts driver to use irqchip template.

Changelog:

v4: - Added stable-tag to the patch "Fix missing release of interrupt".

- Added acks and r-bs from Laxman Dewangan and Andy Shevchenko.

v3: - Addressed review comment that were made by Andy Shevchenko to v2:

- Improved the commit message of the "Initialize hardware state of interrupts" patch.

- Added these new patches:

gpio: max77620: Don't set of_node
gpio: max77620: Don't shadow error code of platform_get_irq()
gpio: max77620: Use irqchip template

- Added "Fix missing release of interrupt" patch.

v2: - Addressed review comment that were made by Andy Shevchenko to v1:

- Generic init_hw() callback is used now for resetting interrupts.

- These v1 patches are dropped:

gpio: max77620: Replace interrupt-enable array with bitmap
gpio: max77620: Don't handle disabled interrupts
gpio: max77620: Move variable declaration

Dmitry Osipenko (6):
gpio: max77620: Replace 8 with MAX77620_GPIO_NR
gpio: max77620: Fix missing release of interrupt
gpio: max77620: Don't set of_node
gpio: max77620: Don't shadow error code of platform_get_irq()
gpio: max77620: Use irqchip template
gpio: max77620: Initialize hardware state of interrupts

 drivers/gpio/gpio-max77620.c | 65 ++++++++++++++++++++++++------------
 1 file changed, 44 insertions(+), 21 deletions(-)
Signature · 1 line
2.26.0