Skip to content

net: phy: Uninline PHY ethtool statistics

Florian Fainelli lkml netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2net: phy: Define PHY statistics ethtool_phy_opsdrivers/net/phy/phy_device.c include/linux/ethtool.h+10 -01 reply
2/2net: phy: Uninline PHY ethtool statistics operationsdrivers/net/phy/phy.c include/linux/phy.h net/ethtool/ioctl.c +1 more+74 -571 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchAndrew Lunn
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH net-next 0/2] net: phy: Uninline PHY ethtool statistics

Hi all,

Now that we have introduced ethtool_phy_ops we can uninline those operations and move them back into phy.c where they belong. Since those functions are used by DSA, we need to continue exporting those symbols.

It might be possible to remove ndo_get_ethtool_phy_stats in a subsequent patch since we could have DSA register its own ethtool_phy_ops instance instead of overloading the ethtool_ops.

Florian Fainelli (2):
net: phy: Define PHY statistics ethtool_phy_ops
net: phy: Uninline PHY ethtool statistics operations

 drivers/net/phy/phy.c        | 48 +++++++++++++++++++++++++++++++++++
 drivers/net/phy/phy_device.c |  3 +++
 include/linux/ethtool.h      |  7 ++++++
 include/linux/phy.h          | 49 +++---------------------------------
 net/ethtool/ioctl.c          | 23 +++++++++++------
 net/ethtool/strset.c         | 11 +++++---
 6 files changed, 84 insertions(+), 57 deletions(-)
Signature · 1 line
2.25.1