Skip to content

SUNRPC: Replace dprintk calls with tracepoints

Chuck Lever linux-nfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest22 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/22SUNRPC: Remove trace_xprt_complete_rqst()include/trace/events/sunrpc.h net/sunrpc/xprt.c+0 -30 replies
2/22SUNRPC: Hoist trace_xprtrdma_op_allocate into generic codeinclude/trace/events/rpcrdma.h include/trace/events/sunrpc.h net/sunrpc/clnt.c +2 more+31 -360 replies
3/22SUNRPC: Remove debugging instrumentation from xprt_releaseinclude/trace/events/rpcrdma.h net/sunrpc/sched.c net/sunrpc/xprt.c +1 more+0 -380 replies
4/22SUNRPC: Update debugging instrumentation in xprt_do_reserve()include/trace/events/sunrpc.h net/sunrpc/xprt.c+26 -370 replies
5/22SUNRPC: Replace dprintk() call site in xprt_prepare_transmitinclude/trace/events/sunrpc.h net/sunrpc/xprt.c+3 -20 replies
6/22SUNRPC: Replace dprintk() call site in xs_nospace()include/trace/events/sunrpc.h net/sunrpc/xprtsock.c+29 -40 replies
7/22SUNRPC: Remove the dprint_status() macronet/sunrpc/clnt.c+1 -300 replies
8/22SUNRPC: Remove dprintk call site in call_start()net/sunrpc/clnt.c+0 -40 replies
9/22SUNRPC: Replace connect dprintk call sites with a tracepointinclude/trace/events/sunrpc.h net/sunrpc/clnt.c net/sunrpc/xprt.c+2 -60 replies
10/22SUNRPC: Mitigate cond_resched() in xprt_transmit()net/sunrpc/xprt.c+4 -20 replies
11/22SUNRPC: Add trace_rpc_timeout_status()include/trace/events/sunrpc.h net/sunrpc/clnt.c+2 -10 replies
12/22SUNRPC: Trace call_refresh eventsinclude/trace/events/sunrpc.h net/sunrpc/clnt.c+5 -60 replies
13/22SUNRPC: Remove dprintk call site in call_decodenet/sunrpc/clnt.c+0 -20 replies
14/22SUNRPC: Clean up call_bind_status() observabilityinclude/trace/events/sunrpc.h net/sunrpc/clnt.c+19 -150 replies
15/22SUNRPC: Remove rpcb_getport_async dprintk call sitesinclude/trace/events/sunrpc.h net/sunrpc/rpcb_clnt.c+38 -200 replies
16/22SUNRPC: Hoist trace_xprtrdma_op_setport into generic codeinclude/trace/events/rpcrdma.h include/trace/events/sunrpc.h net/sunrpc/rpcb_clnt.c +1 more+43 -190 replies
17/22SUNRPC: Remove dprintk call sites in rpcbind XDR functionsnet/sunrpc/rpcb_clnt.c+1 -270 replies
18/22SUNRPC: Remove more dprintks in rpcb_clnt.cnet/sunrpc/rpcb_clnt.c+3 -220 replies
19/22SUNRPC: Replace rpcbind dprintk call sites with tracepointsinclude/trace/events/sunrpc.h net/sunrpc/rpcb_clnt.c+90 -200 replies
20/22SUNRPC: Clean up RPC scheduler tracepointsinclude/trace/events/sunrpc.h net/sunrpc/sched.c+5 -120 replies
21/22SUNRPC: Remove dprintk call sites in RPC queuing functionsinclude/trace/events/sunrpc.h net/sunrpc/sched.c+2 -210 replies
22/22SUNRPC: Remove remaining dprintks from sched.cnet/sunrpc/sched.c+0 -100 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH v1 00/22] SUNRPC: Replace dprintk calls with tracepoints

Hi-

This series replaces many client-side RPC dprintk call sites with tracepoints. The goals of this series are:

- Replace chatty dprintk call sites with tracepoints, which can handle a higher event rate, and won't get rate-limited.

- At some later point, expand the 0-64K range of RPC task IDs. Task IDs would be displayed only by tracepoints as 32-bit unsigned integers.

- Eliminate redundant tracepoints in the transport implementations.

---

Chuck Lever (22):
SUNRPC: Remove trace_xprt_complete_rqst()
SUNRPC: Hoist trace_xprtrdma_op_allocate into generic code
SUNRPC: Remove debugging instrumentation from xprt_release
SUNRPC: Update debugging instrumentation in xprt_do_reserve()
SUNRPC: Replace dprintk() call site in xprt_prepare_transmit
SUNRPC: Replace dprintk() call site in xs_nospace()
SUNRPC: Remove the dprint_status() macro
SUNRPC: Remove dprintk call site in call_start()
SUNRPC: Replace connect dprintk call sites with a tracepoint
SUNRPC: Mitigate cond_resched() in xprt_transmit()
SUNRPC: Add trace_rpc_timeout_status()
SUNRPC: Trace call_refresh events
SUNRPC: Remove dprintk call site in call_decode
SUNRPC: Clean up call_bind_status() observability
SUNRPC: Remove rpcb_getport_async dprintk call sites
SUNRPC: Hoist trace_xprtrdma_op_setport into generic code
SUNRPC: Remove dprintk call sites in rpcbind XDR functions
SUNRPC: Remove more dprintks in rpcb_clnt.c
SUNRPC: Replace rpcbind dprintk call sites with tracepoints
SUNRPC: Clean up RPC scheduler tracepoints
SUNRPC: Remove dprintk call sites in RPC queuing functions
SUNRPC: Remove remaining dprintks from sched.c

 include/trace/events/rpcrdma.h  |  63 -------
 include/trace/events/sunrpc.h   | 285 ++++++++++++++++++++++++++++----
 net/sunrpc/clnt.c               |  75 ++-------
 net/sunrpc/rpcb_clnt.c          | 129 +++------------
 net/sunrpc/sched.c              |  52 +-----
 net/sunrpc/xprt.c               |  22 +--
 net/sunrpc/xprtrdma/transport.c |   7 -
 net/sunrpc/xprtsock.c           |   5 +-
 8 files changed, 304 insertions(+), 334 deletions(-)

--
Chuck Lever