Skip to content

multipath-tools series part III: duplicate alias

[email protected] dm-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 of 42 patches 5 repliesIn review
  2. v13 of 42 patches 3 repliesSuperseded

2 of 42 patches are in this archive. The cover letter announces 42.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
40/42libmultipath: free_multipath(): remove mpp referenceslibmultipath/structs.c+15 -02 replies
41/42libmultipath: refuse reloading an existing map with different WWIDlibmultipath/configure.c+15 -43 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchBenjamin Marzinski
40/42R-b R-b
41/42R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/42] multipath-tools series part III: duplicate alias

From: Martin Wilck <[email protected]>

Hi Christophe, hi Ben,

This is part III of a larger patch series for multpath-tools I've been preparing. It contains fixes for a customer issue where the same alias was set for several maps with different WWIDs in the WWIDs file.

Note that this does *not* break the scenario Ben described in his response to v1 of the part of the series. Details in the commit message of patch 41/42.

This part based on the previously submitted part II (which is completely unchanged from the v1 submission and not re-posted).

The full series will also be available here:
https://github.com/mwilck/multipath-tools/tree/ups/submit-2008
This part is tagged "submit-200812-3".

Changes v1 -> v2, as suggested by Ben Marzinski:

* 40/42 "libmultipath: refuse creating map with duplicate alias"
- dropped, as this breaks valid scenarios
* 40/42 "libmultipath: free_multipath(): remove mpp references"
- new patch added, required to avoid segfaults; inserted here to preserve numbering
* 41/42 "libmultipath: refuse reloading an existing map with different WWID"
- unchanged, but not reviewed yet. Commit message improved.

NOTE: part VI and VII of the the series contain patches related to the topic of this part, improving the handling of inconsistent alias settings further:

80/80 "libmultipath: select_action(): don't drop map if alias clashes" 84/84 "libmultipath: add consistency check for alias settings"

Regards,
Martin

Martin Wilck (3):
libmultipath: free_multipath(): remove mpp references
libmultipath: refuse reloading an existing map with different WWID
libmultipath: dm_addmap(): refuse creating map with empty WWID

 libmultipath/configure.c | 19 +++++++++++++++----
 libmultipath/devmapper.c | 26 +++++++++++++++-----------
 libmultipath/structs.c   | 15 +++++++++++++++
 3 files changed, 45 insertions(+), 15 deletions(-)
Signature · 1 line
2.28.0