Skip to content

Enhance rawdev APIs

Bruce Richardson dpdk-dev 3 versions – Applied

Status from this message: Applied, thanks

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest7 patches 1 replyApplied
  2. v27 patches 4 repliesSuperseded
  3. v15 patches 3 repliesSuperseded

Changes in v3 from the cover letter

- fix doxygen error
- add release note update for changes to public APIs

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/7rawdev: add private data length parameter to info fnapp/test/test_rawdev.c doc/guides/rawdevs/ioat.rst doc/guides/rel_notes/release_20_11.rst +13 more+56 -260 replies
2/7rawdev: allow drivers to return error from info functiondoc/guides/rel_notes/release_20_11.rst drivers/raw/ifpga/ifpga_rawdev.c drivers/raw/ioat/ioat_rawdev.c +4 more+32 -190 replies
3/7rawdev: add private data length parameter to config fndoc/guides/rawdevs/ioat.rst doc/guides/rawdevs/octeontx2_dma.rst doc/guides/rawdevs/octeontx2_ep.rst +17 more+50 -290 replies
4/7rawdev: add private data length parameter to queue fnsdoc/guides/rel_notes/release_20_11.rst drivers/raw/ntb/ntb.c drivers/raw/skeleton/skeleton_rawdev.c +5 more+54 -230 replies
5/7rawdev: allow queue config query to return errordoc/guides/rel_notes/release_20_11.rst drivers/raw/ntb/ntb.c drivers/raw/skeleton/skeleton_rawdev.c +2 more+16 -100 replies
6/7rawdev: mark start and stop functions optionallib/librte_rawdev/rte_rawdev.c+11 -70 replies
7/7doc: remove rawdev deprecation noticedoc/guides/rel_notes/deprecation.rst+0 -70 replies

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by.

PatchRosen XuNipun Gupta
1/7R-b A-b A-b
2/7R-b A-b
3/7R-b A-b
4/7A-b
5/7A-b
6/7A-b
7/7A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [dpdk-dev] [PATCH v3 0/7] Enhance rawdev APIs

This patchset proposes some internal and externally-visible changes to the rawdev API, the ABI change of which were previously announced.

The changes are in two main areas:
* For any APIs which take a void * parameter for driver-specific structs, add an additional parameter to provide the struct length. This allows some runtime type-checking, as well as possible ABI-compatibility support in the future as structure change generally involve a change in the size of the structure.
* Ensure all APIs which can return error values have int type, rather than void. Since functions like info_get and queue_default_get can now do some typechecking, they need to be modified to allow them to return error codes on failure.

V3:
- fix doxygen error
- add release note update for changes to public APIs
V2:
- add additional patch to make start/stop functions optional
- remove deprecation notice once changes applied

Bruce Richardson (7):
rawdev: add private data length parameter to info fn
rawdev: allow drivers to return error from info function
rawdev: add private data length parameter to config fn
rawdev: add private data length parameter to queue fns
rawdev: allow queue config query to return error
rawdev: mark start and stop functions optional
doc: remove rawdev deprecation notice

 app/test/test_rawdev.c                      |  2 +-
 doc/guides/rawdevs/ioat.rst                 |  4 +-
 doc/guides/rawdevs/octeontx2_dma.rst        |  2 +-
 doc/guides/rawdevs/octeontx2_ep.rst         |  3 +-
 doc/guides/rel_notes/deprecation.rst        |  7 ---
 doc/guides/rel_notes/release_20_11.rst      |  9 ++++
 doc/guides/sample_app_ug/ioat.rst           |  4 +-
 drivers/bus/ifpga/ifpga_bus.c               |  2 +-
 drivers/raw/ifpga/ifpga_rawdev.c            | 23 +++++-----
 drivers/raw/ioat/ioat_rawdev.c              | 17 ++++---
 drivers/raw/ioat/ioat_rawdev_test.c         |  6 +--
 drivers/raw/ntb/ntb.c                       | 49 ++++++++++++++++-----
 drivers/raw/octeontx2_dma/otx2_dpi_rawdev.c |  7 +--
 drivers/raw/octeontx2_dma/otx2_dpi_test.c   |  3 +-
 drivers/raw/octeontx2_ep/otx2_ep_rawdev.c   |  7 +--
 drivers/raw/octeontx2_ep/otx2_ep_test.c     |  2 +-
 drivers/raw/skeleton/skeleton_rawdev.c      | 36 +++++++++------
 drivers/raw/skeleton/skeleton_rawdev_test.c | 32 ++++++++------
 examples/ioat/ioatfwd.c                     |  4 +-
 examples/ntb/ntb_fwd.c                      |  7 +--
 lib/librte_rawdev/rte_rawdev.c              | 47 +++++++++++++-------
 lib/librte_rawdev/rte_rawdev.h              | 27 ++++++++++--
 lib/librte_rawdev/rte_rawdev_pmd.h          | 22 ++++++---
 23 files changed, 210 insertions(+), 112 deletions(-)
Signature · 1 line
2.25.1