Skip to content

RFC introduce PLDM firmware update library

Jacob Keller netdev oe-kbuild-all 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 RFC Latest6 patches 28 repliesIn review
  2. v1 RFC6 patches 13 repliesSuperseded

Changes in v2 from the cover letter

* Removed the "allow_downgrade_on_flash_update" parameter. Instead, the driver will always attempt to flash the device, even when firmware indicates that it would be a downgrade. A dev_warn is used to indicate when this occurs.
* Removed the "ignore_pending_flash_update". Instead, the driver will always check for and cancel any previous pending update. A devlink flash status message will be sent when this cancellation occurs.
* Removed the "reset_after_flash_update" parameter. This will instead be implemented as part of a devlink reset interface, work left for a future change.
* Replaced the "flash_update_preservation_level" parameter with a new "overwrite" mode attribute on the flash update command. For ice, this mode will select the preservation level. For all other drivers, I modified them to check that the mode is "OVERWRITE_NOTHING", and have Cc'd the maintainers to get their input.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6ice: Add support for unified NVM update flow capabilitydrivers/net/ethernet/intel/ice/ice_adminq_cmd.h drivers/net/ethernet/intel/ice/ice_common.c drivers/net/ethernet/intel/ice/ice_type.h+11 -00 replies
2/6ice: Add AdminQ commands for FW updatedrivers/net/ethernet/intel/ice/ice_adminq_cmd.h drivers/net/ethernet/intel/ice/ice_common.h drivers/net/ethernet/intel/ice/ice_nvm.c +2 more+281 -20 replies
3/6ice: add flags indicating pending update of firmware moduledrivers/net/ethernet/intel/ice/ice_adminq_cmd.h drivers/net/ethernet/intel/ice/ice_common.c drivers/net/ethernet/intel/ice/ice_type.h+24 -00 replies
4/6Add pldmfw library for PLDM firmware updateDocumentation/driver-api/index.rst Documentation/driver-api/pldmfw/driver-ops.rst Documentation/driver-api/pldmfw/file-format.rst +8 more+1630 -00 replies
5/6ice: implement device flash update via devlinkdrivers/net/ethernet/intel/Kconfig drivers/net/ethernet/intel/ice/Makefile drivers/net/ethernet/intel/ice/ice.h +6 more+1014 -11 reply
6/6devlink: add overwrite mode to flash updateDocumentation/networking/devlink/devlink-flash.rst Documentation/networking/devlink/ice.rst drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c +13 more+142 -924 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [RFC PATCH net-next v2 0/6] introduce PLDM firmware update library

This series goal is to enable support for updating the ice hardware flash using the devlink flash command.

The ice firmware update files are distributed using the file format described by the "PLDM for Firmware Update" standard:

https://www.dmtf.org/documents/pmci/pldm-firmware-update-specification-100

Because this file format is standard, this series introduces a new library that handles the generic logic for parsing the PLDM file header. The library uses a design that is very similar to the Mellanox mlxfw module. That is, a simple ops table is setup and device drivers instantiate an instance of the pldmfw library with the device specific operations.

Doing so allows for each device to implement the low level behavior for how to interact with its firmware.

This series includes the library and an implementation for the ice hardware. Additionally, it includes a final patch which introduces a new attribute to the devlink flash command.

Because the PLDM file format is a standard and not something that is specific to the Intel hardware, I opted to place this update library in lib/pldmfw. I should note that while I tried to make the library generic, it does not attempt to mimic the complete "Update Agent" as defined in the standard. This is mostly due to the fact that the actual interfaces exposed to software for the ice hardware would not allow this.

This series is currently based on top of Jeff Kirsher's dev-queue, as it relies on some cleanup of the device capabilities code that was recently published. For non-Intel drivers, this tree matches net-next. Once this series has left RFC status, I will be submitting it via net-next directly.

The Intel Wired LAN dev-queue can be found here:
https://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/next-queue.git/log/?h=dev-queue

Changes since v1 RFC
* Removed the "allow_downgrade_on_flash_update" parameter. Instead, the driver will always attempt to flash the device, even when firmware indicates that it would be a downgrade. A dev_warn is used to indicate when this occurs.
* Removed the "ignore_pending_flash_update". Instead, the driver will always check for and cancel any previous pending update. A devlink flash status message will be sent when this cancellation occurs.
* Removed the "reset_after_flash_update" parameter. This will instead be implemented as part of a devlink reset interface, work left for a future change.
* Replaced the "flash_update_preservation_level" parameter with a new "overwrite" mode attribute on the flash update command. For ice, this mode will select the preservation level. For all other drivers, I modified them to check that the mode is "OVERWRITE_NOTHING", and have Cc'd the maintainers to get their input.

Cc Jiri Pirko <[email protected]>
Cc Jakub Kicinski <[email protected]>
Cc Jonathan Corbet <[email protected]>
Cc Michael Chan <[email protected]>
Cc Bin Luo <[email protected]>
Cc Saeed Mahameed <[email protected]>
Cc Leon Romanovsky <[email protected]>
Cc Ido Schimmel <[email protected]>
Cc Danielle Ratson <[email protected]>

Cudzilo, Szymon T (1):
ice: Add AdminQ commands for FW update

Jacek Naczyk (1):
ice: Add support for unified NVM update flow capability

Jacob Keller (4):
ice: add flags indicating pending update of firmware module Add pldmfw library for PLDM firmware update
ice: implement device flash update via devlink
devlink: add overwrite mode to flash update

 Documentation/driver-api/index.rst            |   1 +
 .../driver-api/pldmfw/driver-ops.rst          |  56 ++
 .../driver-api/pldmfw/file-format.rst         | 203 ++++
 Documentation/driver-api/pldmfw/index.rst     |  72 ++
 .../networking/devlink/devlink-flash.rst      |  31 +
 Documentation/networking/devlink/ice.rst      |  27 +
 MAINTAINERS                                   |   7 +
 .../net/ethernet/broadcom/bnxt/bnxt_devlink.c |   7 +-
 .../net/ethernet/huawei/hinic/hinic_devlink.c |   3 +
 drivers/net/ethernet/intel/Kconfig            |   1 +
 drivers/net/ethernet/intel/ice/Makefile       |   1 +
 drivers/net/ethernet/intel/ice/ice.h          |   9 +
 .../net/ethernet/intel/ice/ice_adminq_cmd.h   |  83 ++
 drivers/net/ethernet/intel/ice/ice_common.c   |  21 +-
 drivers/net/ethernet/intel/ice/ice_common.h   |   4 +-
 drivers/net/ethernet/intel/ice/ice_devlink.c  |  56 ++
 .../net/ethernet/intel/ice/ice_fw_update.c    | 805 ++++++++++++++++
 .../net/ethernet/intel/ice/ice_fw_update.h    |  12 +
 drivers/net/ethernet/intel/ice/ice_main.c     | 154 +++
 drivers/net/ethernet/intel/ice/ice_nvm.c      | 186 ++++
 drivers/net/ethernet/intel/ice/ice_nvm.h      |  16 +
 drivers/net/ethernet/intel/ice/ice_type.h     |  12 +
 .../net/ethernet/mellanox/mlx5/core/devlink.c |   4 +
 drivers/net/ethernet/mellanox/mlxsw/core.c    |   3 +-
 drivers/net/ethernet/mellanox/mlxsw/core.h    |   1 +
 .../net/ethernet/mellanox/mlxsw/spectrum.c    |   4 +
 .../net/ethernet/netronome/nfp/nfp_devlink.c  |   6 +-
 drivers/net/netdevsim/dev.c                   |   1 +
 include/linux/pldmfw.h                        | 165 ++++
 include/net/devlink.h                         |   1 +
 include/uapi/linux/devlink.h                  |  16 +
 lib/Kconfig                                   |   4 +
 lib/Makefile                                  |   3 +
 lib/pldmfw/Makefile                           |   2 +
 lib/pldmfw/pldmfw.c                           | 879 ++++++++++++++++++
 lib/pldmfw/pldmfw_private.h                   | 238 +++++
 net/core/devlink.c                            |  16 +-
 37 files changed, 3101 insertions(+), 9 deletions(-)
 create mode 100644 Documentation/driver-api/pldmfw/driver-ops.rst
 create mode 100644 Documentation/driver-api/pldmfw/file-format.rst
 create mode 100644 Documentation/driver-api/pldmfw/index.rst
 create mode 100644 drivers/net/ethernet/intel/ice/ice_fw_update.c
 create mode 100644 drivers/net/ethernet/intel/ice/ice_fw_update.h
 create mode 100644 include/linux/pldmfw.h
 create mode 100644 lib/pldmfw/Makefile
 create mode 100644 lib/pldmfw/pldmfw.c
 create mode 100644 lib/pldmfw/pldmfw_private.h
Signature · 1 line
2.27.0.353.gb9a2d1a0207f