Skip to content

Add support for ipq8064 tsens

Ansuel Smith linux-arm-msm linux-devicetree linux-pm lkml 15 versions – Applied

Status from this message: The following commit has been merged into the thermal/next branch of thermal:

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v15 Latest9 patches 0 repliesApplied
  2. v149 patches 8 repliesApplied
  3. v139 patches 2 repliesSuperseded
Earlier versions · 12
VersionPostedPatchesRepliesStatus
v129 patches1 replySuperseded
v119 patches7 repliesSuperseded
v108 patches11 repliesSuperseded
v98 patches2 repliesSuperseded
v88 patches1 replySuperseded
v78 patches1 replySuperseded
v6 RFC8 patches7 repliesSuperseded
v5 RFC7 patches5 repliesSuperseded
v47 patches11 repliesApplied
v37 patches0 repliesSuperseded
v26 patches0 repliesSuperseded
v16 patches4 repliesSuperseded

Changes in v15 from the cover letter

* Fix bisect error reported by bot (add feat define in the VER_0 patch)
* Fix static slope table (offset -350 instead of -200 to have a more accurate temp) v14:
* Fix warning reported by Dan Carpenter

Patches in v15 Applied

#Subject and filesSizeRepliesApplied
1/9drivers: thermal: tsens: Don't hardcode sensor slopedrivers/thermal/qcom/tsens.c+2 -10 replies
2/9drivers: thermal: tsens: Convert msm8960 to reg_fielddrivers/thermal/qcom/tsens-8960.c+71 -20 replies
3/9drivers: thermal: tsens: Add VER_0 tsens versiondrivers/thermal/qcom/tsens-8960.c drivers/thermal/qcom/tsens.c drivers/thermal/qcom/tsens.h+133 -300 replies
4/9drivers: thermal: tsens: Use init_common for msm8960drivers/thermal/qcom/tsens-8960.c+1 -510 replies
5/9drivers: thermal: tsens: Fix bug in sensor enable for msm8960drivers/thermal/qcom/tsens-8960.c+20 -30 replies
6/9drivers: thermal: tsens: Replace custom 8960 apis with generic apisdrivers/thermal/qcom/tsens-8960.c+15 -410 replies
7/9drivers: thermal: tsens: Drop unused define for msm8960drivers/thermal/qcom/tsens-8960.c+1 -230 replies
8/9drivers: thermal: tsens: Add support for ipq8064-tsensdrivers/thermal/qcom/tsens.c+3 -00 replies
9/9dt-bindings: thermal: tsens: Document ipq8064 bindingsDocumentation/devicetree/bindings/thermal/qcom-tsens.yaml+48 -80 replies

Reviews trailers per patch

All 9 patches have a Reviewed-by or Acked-by.

PatchThara GopinathRob Herring
1/9R-b
2/9A-b
3/9R-b
4/9R-b
5/9A-b
6/9A-b
7/9R-b
8/9R-b
9/9R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v15 thread

Cover letter [thermal PATCH v15 0/9] Add support for ipq8064 tsens

This patchset convert msm8960 to reg_filed, use int_common instead of a custom function and fix wrong tsens get_temp function for msm8960. Ipq8064 SoCs tsens driver is based on 8960 tsens driver. Ipq8064 needs to be registered as a gcc child as the tsens regs on this platform are shared with the controller.
This is based on work and code here
https://git.linaro.org/people/amit.kucheria/kernel.git/log/?h=wrk3/tsens-8960-breakage

This series has already been approved but the "kernel test robot" reported some bisect error.

v15:
* Fix bisect error reported by bot (add feat define in the VER_0 patch)
* Fix static slope table (offset -350 instead of -200 to have a more accurate temp) v14:
* Fix warning reported by Dan Carpenter
v13:
* Simple reword
v12:
* Even more fix reported by Thara
v11:
* Address comments from Thara (thx)
v10:
* Fix wrong tsens init for ver_0 (crit_trips needs to be set in tsens_register) v9:
* Fix warning from Documentation bot
v8:
* Drop MIN and MAX THRESH and use CRIT_THRESH instead
* Fix broken documentation patch
v7:
* Rework calibrate function to use get_temp_common
* Fix wrong required in the Documentation for ipq8064
* Fix hardware bug in sensor enable function
v6:
* Fix spelling error (can't find the problem with variable misallignment)
* Rework big if-else
* Remove extra comments
* Add description about different interrupts
v5:
* Conver driver to use reg_fiedl
* Use init_common
* Drop custom set_trip and set_interrupt
* Use common set_trip and set_interrupt
* Fix bad get_temp function
* Add missing hardcoded slope
v4:
* Fix compilation error and warning reported by the bot
v3:
* Change driver to register as child instead of use phandle
v2:
* Fix dt-bindings problems

Ansuel Smith (9):
drivers: thermal: tsens: Don't hardcode sensor slope
drivers: thermal: tsens: Convert msm8960 to reg_field
drivers: thermal: tsens: Add VER_0 tsens version
drivers: thermal: tsens: Use init_common for msm8960
drivers: thermal: tsens: Fix bug in sensor enable for msm8960
drivers: thermal: tsens: Replace custom 8960 apis with generic apis
drivers: thermal: tsens: Drop unused define for msm8960
drivers: thermal: tsens: Add support for ipq8064-tsens
dt-bindings: thermal: tsens: Document ipq8064 bindings

 .../bindings/thermal/qcom-tsens.yaml          |  56 ++++-
 drivers/thermal/qcom/tsens-8960.c             | 235 +++++++++---------
 drivers/thermal/qcom/tsens.c                  | 156 +++++++++---
 drivers/thermal/qcom/tsens.h                  |   4 +-
 4 files changed, 293 insertions(+), 158 deletions(-)
Signature · 1 line
2.30.2