Skip to content

virtio: config space endian-ness cleanup

Michael S. Tsirkin dri-devel kvm linux-crypto linux-fsdevel linux-iommu linux-nvdimm linux-scsi lkml netdev nvdimm platform-driver-x86 virtualization 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest38 patches 9 repliesIn review
  2. v224 patches 44 repliesSuperseded
  3. v11 patch 2 repliesSuperseded

Changes in v3 from the cover letter

- convert a couple of missing devices
- add APIs for accessing config space as LE, use that in modern devices and in balloon.
- code comments in vdpa_sim explaining use of transitional APIs

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/38virtio_balloon: fix sparse warningdrivers/virtio/virtio_balloon.c+1 -10 replies
2/38virtio_ring: sparse warning fixupinclude/linux/virtio_ring.h+9 -100 replies
3/38virtio: allow __virtioXX, __leXX in config spaceinclude/linux/virtio_config.h+48 -20 replies
4/38virtio_9p: correct tags for config space fieldsinclude/uapi/linux/virtio_9p.h+2 -20 replies
5/38virtio_balloon: correct tags for config space fieldsinclude/uapi/linux/virtio_balloon.h+5 -50 replies
6/38virtio_blk: correct tags for config space fieldsinclude/uapi/linux/virtio_blk.h+13 -131 reply
7/38virtio_console: correct tags for config space fieldsinclude/uapi/linux/virtio_console.h+4 -40 replies
8/38virtio_crypto: correct tags for config space fieldsinclude/uapi/linux/virtio_crypto.h+13 -130 replies
9/38virtio_fs: correct tags for config space fieldsinclude/uapi/linux/virtio_fs.h+1 -10 replies
10/38virtio_gpu: correct tags for config space fieldsinclude/uapi/linux/virtio_gpu.h+4 -41 reply
11/38virtio_input: correct tags for config space fieldsinclude/uapi/linux/virtio_input.h+9 -90 replies
12/38virtio_iommu: correct tags for config space fieldsinclude/uapi/linux/virtio_iommu.h+6 -60 replies
13/38virtio_mem: correct tags for config space fieldsinclude/uapi/linux/virtio_mem.h+7 -70 replies
14/38virtio_net: correct tags for config space fieldsinclude/uapi/linux/virtio_net.h+4 -40 replies
15/38virtio_pmem: correct tags for config space fieldsinclude/uapi/linux/virtio_pmem.h+2 -20 replies
16/38virtio_scsi: correct tags for config space fieldsdrivers/scsi/virtio_scsi.c include/uapi/linux/virtio_scsi.h+12 -120 replies
17/38virtio_config: disallow native type fieldsinclude/linux/virtio_config.h+2 -30 replies
18/38mlxbf-tmfifo: sparse tags for config accessdrivers/platform/mellanox/mlxbf-tmfifo.c+10 -31 reply
19/38vdpa: make sure set_features is invoked for legacydrivers/vdpa/vdpa.c include/linux/vdpa.h+35 -00 replies
20/38vhost/vdpa: switch to new helpersdrivers/vhost/vdpa.c+3 -50 replies
21/38virtio_vdpa: legacy features handlingdrivers/virtio/virtio_vdpa.c+3 -60 replies
22/38vdpa_sim: fix endian-ness of config spacedrivers/vdpa/vdpa_sim/vdpa_sim.c+28 -50 replies
23/38virtio_config: cread/write cleanupinclude/linux/virtio_config.h+19 -120 replies
24/38virtio_config: rewrite using _Genericinclude/linux/virtio_config.h+77 -860 replies
25/38virtio_config: disallow native type fields (again)include/linux/virtio_config.h+2 -140 replies
26/38virtio_config: LE config space accessorsinclude/linux/virtio_config.h+65 -00 replies
27/38virtio_caif: correct tags for config space fieldsinclude/linux/virtio_caif.h+3 -30 replies
28/38virtio_config: add virtio_cread_le_featureinclude/linux/virtio_config.h+10 -00 replies
29/38virtio_balloon: use LE config space accessesdrivers/virtio/virtio_balloon.c+9 -170 replies
30/38virtio_input: convert to LE accessorsdrivers/virtio/virtio_input.c+16 -161 reply
31/38virtio_fs: convert to LE accessorsfs/fuse/virtio_fs.c+2 -21 reply
32/38virtio_crypto: convert to LE accessorsdrivers/crypto/virtio/virtio_crypto_core.c+23 -230 replies
33/38virtio_pmem: convert to LE accessorsdrivers/nvdimm/virtio_pmem.c+2 -21 reply
34/38drm/virtio: convert to LE accessorsdrivers/gpu/drm/virtio/virtgpu_kms.c+8 -81 reply
35/38virtio_mem: convert to LE accessorsdrivers/virtio/virtio_mem.c+15 -151 reply
36/38virtio-iommu: convert to LE accessorsdrivers/iommu/virtio-iommu.c+17 -170 replies
37/38virtio_config: drop LE option from config spaceinclude/linux/virtio_config.h+2 -260 replies
38/38virtio_net: use LE accessors for speed/duplexdrivers/net/virtio_net.c include/uapi/linux/virtio_net.h+6 -51 reply

Reviews trailers per patch

22 of 38 patches have a Reviewed-by or Acked-by.

PatchCornelia HuckDavid HildenbrandVivek GoyalGerd HoffmannJean-Philippe BruckerStefano GarzarellaAndy ShevchenkoIra Weiny
1/38R-b R-b A-b
2/38A-b
3/38A-b
4/38R-b
5/38R-b A-b
6/38R-b R-b
7/38R-b
8/38R-b
9/38R-b A-b A-b
10/38R-b R-b
11/38R-b R-b R-b
12/38R-b R-b R-b
13/38R-b A-b
14/38
15/38R-b
16/38R-b
17/38
18/38A-b A-b
19/38
20/38
21/38
22/38
23/38
24/38
25/38
26/38
27/38
28/38
29/38
30/38R-b
31/38A-b
32/38
33/38A-b
34/38R-b
35/38A-b
36/38
37/38
38/38R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 8 reviewers.

Read the v3 thread

Cover letter [PATCH v3 00/38] virtio: config space endian-ness cleanup

Config space endian-ness is currently a mess: fields are not tagged with the correct endian-ness so it's easy to make mistakes like instanciating config space in native endian-ness.

Further, LE-only devices (e.g. modern-style) add unnecessary overhead by using generic transitional-style config space accesses.

The following patches adding sparse tagging and then using that to correctly access config space as either transitional or LE are my tree.
Lightly tested.

I also start with a version using gcc extensions, then switch to _Generic. This is helpful for backports to older kernels/older
distros: _Generic patch can just be skipped there.

changes from v2:
- convert a couple of missing devices
- add APIs for accessing config space as LE, use that in modern devices and in balloon.
- code comments in vdpa_sim explaining use of transitional APIs

Michael S. Tsirkin (38):
virtio_balloon: fix sparse warning
virtio_ring: sparse warning fixup
virtio: allow __virtioXX, __leXX in config space
virtio_9p: correct tags for config space fields
virtio_balloon: correct tags for config space fields
virtio_blk: correct tags for config space fields
virtio_console: correct tags for config space fields
virtio_crypto: correct tags for config space fields
virtio_fs: correct tags for config space fields
virtio_gpu: correct tags for config space fields
virtio_input: correct tags for config space fields
virtio_iommu: correct tags for config space fields
virtio_mem: correct tags for config space fields
virtio_net: correct tags for config space fields
virtio_pmem: correct tags for config space fields
virtio_scsi: correct tags for config space fields
virtio_config: disallow native type fields
mlxbf-tmfifo: sparse tags for config access
vdpa: make sure set_features is invoked for legacy vhost/vdpa: switch to new helpers
virtio_vdpa: legacy features handling
vdpa_sim: fix endian-ness of config space
virtio_config: cread/write cleanup
virtio_config: rewrite using _Generic
virtio_config: disallow native type fields (again)
virtio_config: LE config space accessors
virtio_caif: correct tags for config space fields
virtio_config: add virtio_cread_le_feature
virtio_balloon: use LE config space accesses
virtio_input: convert to LE accessors
virtio_fs: convert to LE accessors
virtio_crypto: convert to LE accessors
virtio_pmem: convert to LE accessors drm/virtio: convert to LE accessors
virtio_mem: convert to LE accessors
virtio-iommu: convert to LE accessors
virtio_config: drop LE option from config space
virtio_net: use LE accessors for speed/duplex

 drivers/crypto/virtio/virtio_crypto_core.c |  46 ++---
 drivers/gpu/drm/virtio/virtgpu_kms.c       |  16 +-
 drivers/iommu/virtio-iommu.c               |  34 ++--
 drivers/net/virtio_net.c                   |   9 +-
 drivers/nvdimm/virtio_pmem.c               |   4 +-
 drivers/platform/mellanox/mlxbf-tmfifo.c   |  13 +-
 drivers/scsi/virtio_scsi.c                 |   4 +-
 drivers/vdpa/vdpa.c                        |   1 +
 drivers/vdpa/vdpa_sim/vdpa_sim.c           |  33 +++-
 drivers/vhost/vdpa.c                       |   8 +-
 drivers/virtio/virtio_balloon.c            |  28 ++--
 drivers/virtio/virtio_input.c              |  32 ++--
 drivers/virtio/virtio_mem.c                |  30 ++--
 drivers/virtio/virtio_vdpa.c               |   9 +-
 fs/fuse/virtio_fs.c                        |   4 +-
 include/linux/vdpa.h                       |  34 ++++
 include/linux/virtio_caif.h                |   6 +-
 include/linux/virtio_config.h              | 186 +++++++++++++++------
 include/linux/virtio_ring.h                |  19 +--
 include/uapi/linux/virtio_9p.h             |   4 +-
 include/uapi/linux/virtio_balloon.h        |  10 +-
 include/uapi/linux/virtio_blk.h            |  26 +--
 include/uapi/linux/virtio_console.h        |   8 +-
 include/uapi/linux/virtio_crypto.h         |  26 +--
 include/uapi/linux/virtio_fs.h             |   2 +-
 include/uapi/linux/virtio_gpu.h            |   8 +-
 include/uapi/linux/virtio_input.h          |  18 +-
 include/uapi/linux/virtio_iommu.h          |  12 +-
 include/uapi/linux/virtio_mem.h            |  14 +-
 include/uapi/linux/virtio_net.h            |   8 +-
 include/uapi/linux/virtio_pmem.h           |   4 +-
 include/uapi/linux/virtio_scsi.h           |  20 +--
 32 files changed, 405 insertions(+), 271 deletions(-)
Signature · 1 line
MST