Skip to content

Hirschmann Hellcreek DSA driver

Kurt Kanzenbach linux-devicetree netdev 8 versions – Applied

Status from this message: Applied, thanks everyone!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v8 Latest8 patches 2 repliesApplied
  2. v78 patches 6 repliesSuperseded
  3. v67 patches 43 repliesSuperseded
Earlier versions · 5
VersionPostedPatchesRepliesStatus
v57 patches7 repliesSuperseded
v47 patches10 repliesSuperseded
v38 patches35 repliesSuperseded
v28 patches5 repliesSuperseded
v18 patches22 repliesSuperseded

Changes in v8 from the cover letter

* Simplify tagging code (rebase to net-next)
* Pass info instead of ptr (Florian Fainelli)
* Fix yamllint warnings (Rob Herring)

Patches in v8 Applied

#Subject and filesSizeRepliesApplied
1/8net: dsa: Add tag handling for Hirschmann Hellcreek switchesinclude/net/dsa.h net/dsa/Kconfig net/dsa/Makefile +1 more+75 -01 reply
2/8net: dsa: Give drivers the chance to veto certain upper devicesinclude/net/dsa.h net/dsa/slave.c+18 -00 replies
3/8net: dsa: Add DSA driver for Hirschmann Hellcreek switchesdrivers/net/dsa/Kconfig drivers/net/dsa/Makefile drivers/net/dsa/hirschmann/Kconfig +4 more+1538 -00 replies
4/8net: dsa: hellcreek: Add PTP clock supportdrivers/net/dsa/hirschmann/Kconfig drivers/net/dsa/hirschmann/Makefile drivers/net/dsa/hirschmann/hellcreek.c +3 more+435 -10 replies
5/8net: dsa: hellcreek: Add support for hardware timestampingdrivers/net/dsa/hirschmann/Makefile drivers/net/dsa/hirschmann/hellcreek.c drivers/net/dsa/hirschmann/hellcreek.h +4 more+616 -140 replies
6/8net: dsa: hellcreek: Add PTP status LEDsdrivers/net/dsa/hirschmann/hellcreek.h drivers/net/dsa/hirschmann/hellcreek_ptp.c drivers/net/dsa/hirschmann/hellcreek_ptp.h+156 -00 replies
7/8dt-bindings: Add vendor prefix for HirschmannDocumentation/devicetree/bindings/vendor-prefixes.yaml+2 -00 replies
8/8dt-bindings: net: dsa: Add documentation for Hellcreek switchesDocumentation/devicetree/bindings/net/dsa/hirschmann,hellcreek.yaml+127 -00 replies

Reviews trailers per patch

All 8 patches have a Reviewed-by or Acked-by.

PatchFlorian FainelliVladimir OlteanRob HerringRichard CochranAndrew Lunn
1/8R-b
2/8R-b
3/8R-b R-b
4/8A-b
5/8A-b
6/8R-b R-b
7/8R-b A-b
8/8R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v8 thread

Cover letter [PATCH net-next v8 0/8] Hirschmann Hellcreek DSA driver

Hi,

this series adds a DSA driver for the Hirschmann Hellcreek TSN switch IP. Characteristics of that IP:

* Full duplex Ethernet interface at 100/1000 Mbps on three ports
* IEEE 802.1Q-compliant Ethernet Switch
* IEEE 802.1Qbv Time-Aware scheduling support
* IEEE 1588 and IEEE 802.1AS support

That IP is used e.g. in

https://www.arrow.com/en/campaigns/arrow-kairos

Due to the hardware setup the switch driver is implemented using DSA. A special tagging protocol is leveraged. Furthermore, this driver supports PTP and hardware timestamping.

This work is part of the AccessTSN project: https://www.accesstsn.com/

The previous versions can be found here:

* https://lkml.kernel.org/netdev/[email protected]/
* https://lkml.kernel.org/netdev/[email protected]/
* https://lkml.kernel.org/netdev/[email protected]/
* https://lkml.kernel.org/netdev/[email protected]/
* https://lkml.kernel.org/netdev/[email protected]/
* https://lkml.kernel.org/netdev/[email protected]/
* https://lkml.kernel.org/netdev/[email protected]/
* https://lkml.kernel.org/netdev/[email protected]/

Changes since v7:

* Simplify tagging code (rebase to net-next)
* Pass info instead of ptr (Florian Fainelli)
* Fix yamllint warnings (Rob Herring)

Changes since v6:

* Add .tail_tag = true (Vladimir Oltean)
* Fix vlan_filtering=0 bridges (Vladimir Oltean)
* Enforce restrictions (Vladimir Oltean)
* Sort stuff alphabetically (Vladimir Oltean)
* Rename hellcreek.yaml to hirschmann,hellcreek.yaml
* Typo fixes

Changes since v5:

* Implement configure_vlan_while_not_filtering behavior (Vladimir Oltean)
* Minor cleanups

Changes since v4:

* Fix W=1 compiler warnings (kernel test robot)
* Add tags

Changes since v3:

* Drop TAPRIO support (David Miller)
=> Switch to mutexes due to the lack of hrtimers
* Use more specific compatible strings and add platform data (Andrew Lunn)
* Fix Kconfig ordering (Andrew Lunn)

Changes since v2:

* Make it compile by getting all requirements merged first (Jakub Kicinski, David Miller)
* Use "tsn" for TSN register set (Rob Herring)
* Fix DT binding issues (Rob Herring)

Changes since v1:

* Code simplifications (Florian Fainelli, Vladimir Oltean)
* Fix issues with hellcreek.yaml bindings (Florian Fainelli)
* Clear reserved field in ptp v2 event messages (Richard Cochran)
* Make use of generic ptp parsing function (Richard Cochran, Vladimir Oltean)
* Fix Kconfig (Florian Fainelli)
* Add tags (Florian Fainelli, Rob Herring, Richard Cochran)

Changes since RFC ordered by reviewers:

* Andrew Lunn
* Use dev_dbg for debug messages
* Get rid of __ function names where possible
* Use reverse xmas tree variable ordering
* Remove redundant/useless checks
* Improve comments e.g. for PTP
* Fix Kconfig ordering
* Make LED handling more generic and provide info via DT
* Setup advertisement of PHYs according to hardware
* Drop debugfs patch
* Jakub Kicinski
* Fix compiler warnings
* Florian Fainelli
* Switch to YAML DT bindings
* Richard Cochran
* Fix typo
* Add missing NULL checks

Kamil Alkhouri (2):
net: dsa: hellcreek: Add PTP clock support
net: dsa: hellcreek: Add support for hardware timestamping

Kurt Kanzenbach (5):
net: dsa: Add tag handling for Hirschmann Hellcreek switches
net: dsa: Add DSA driver for Hirschmann Hellcreek switches
net: dsa: hellcreek: Add PTP status LEDs
dt-bindings: Add vendor prefix for Hirschmann
dt-bindings: net: dsa: Add documentation for Hellcreek switches

Vladimir Oltean (1):
net: dsa: Give drivers the chance to veto certain upper devices

 .../net/dsa/hirschmann,hellcreek.yaml         |  127 ++
 .../devicetree/bindings/vendor-prefixes.yaml  |    2 +
 drivers/net/dsa/Kconfig                       |    2 +
 drivers/net/dsa/Makefile                      |    1 +
 drivers/net/dsa/hirschmann/Kconfig            |    9 +
 drivers/net/dsa/hirschmann/Makefile           |    5 +
 drivers/net/dsa/hirschmann/hellcreek.c        | 1339 +++++++++++++++++
 drivers/net/dsa/hirschmann/hellcreek.h        |  286 ++++
 .../net/dsa/hirschmann/hellcreek_hwtstamp.c   |  479 ++++++
 .../net/dsa/hirschmann/hellcreek_hwtstamp.h   |   58 +
 drivers/net/dsa/hirschmann/hellcreek_ptp.c    |  452 ++++++
 drivers/net/dsa/hirschmann/hellcreek_ptp.h    |   76 +
 .../platform_data/hirschmann-hellcreek.h      |   23 +
 include/net/dsa.h                             |    8 +
 net/dsa/Kconfig                               |    6 +
 net/dsa/Makefile                              |    1 +
 net/dsa/slave.c                               |   12 +
 net/dsa/tag_hellcreek.c                       |   66 +
 18 files changed, 2952 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/net/dsa/hirschmann,hellcreek.yaml
 create mode 100644 drivers/net/dsa/hirschmann/Kconfig
 create mode 100644 drivers/net/dsa/hirschmann/Makefile
 create mode 100644 drivers/net/dsa/hirschmann/hellcreek.c
 create mode 100644 drivers/net/dsa/hirschmann/hellcreek.h
 create mode 100644 drivers/net/dsa/hirschmann/hellcreek_hwtstamp.c
 create mode 100644 drivers/net/dsa/hirschmann/hellcreek_hwtstamp.h
 create mode 100644 drivers/net/dsa/hirschmann/hellcreek_ptp.c
 create mode 100644 drivers/net/dsa/hirschmann/hellcreek_ptp.h
 create mode 100644 include/linux/platform_data/hirschmann-hellcreek.h
 create mode 100644 net/dsa/tag_hellcreek.c
Signature · 1 line
2.20.1