Skip to content

RFC DG1 LMEM enabling

Matthew Auld intel-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest60 patches 22 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/60drm/i915: Add has_master_unit_irq flagdrivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/intel_device_info.h+3 -00 replies
2/60drm/i915/dg1: add initial DG-1 definitionsdrivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/i915_pci.c drivers/gpu/drm/i915/intel_device_info.c +1 more+21 -00 replies
3/60drm/i915/dg1: Add DG1 PCI IDsdrivers/gpu/drm/i915/i915_pci.c include/drm/i915_pciids.h+5 -10 replies
4/60drm/i915/dg1: add support for the master unit interruptdrivers/gpu/drm/i915/i915_debugfs.c drivers/gpu/drm/i915/i915_irq.c drivers/gpu/drm/i915/i915_reg.h+61 -30 replies
5/60drm/i915/dg1: Remove SHPD_FILTER_CNT register programmingdrivers/gpu/drm/i915/i915_irq.c+2 -10 replies
6/60drm/i915/dg1: Add fake PCHdrivers/gpu/drm/i915/intel_pch.c drivers/gpu/drm/i915/intel_pch.h+10 -00 replies
7/60drm/i915/dg1: Initialize RAWCLK properlydrivers/gpu/drm/i915/display/intel_cdclk.c+15 -10 replies
8/60drm/i915/dg1: Define MOCS table for DG1drivers/gpu/drm/i915/gt/intel_mocs.c+38 -10 replies
9/60drm/i915/dg1: Add DG1 power wellsdrivers/gpu/drm/i915/display/intel_display_power.c+200 -10 replies
10/60drm/i915/dg1: Increase mmio size to 4MBdrivers/gpu/drm/i915/intel_uncore.c+4 -00 replies
11/60drm/i915/dg1: Wait for pcode/uncore handshake at startupdrivers/gpu/drm/i915/i915_drv.c drivers/gpu/drm/i915/i915_reg.h drivers/gpu/drm/i915/intel_sideband.c +1 more+23 -00 replies
12/60drm/i915/dg1: Add DPLL macros for DG1drivers/gpu/drm/i915/display/intel_dpll_mgr.h drivers/gpu/drm/i915/i915_reg.h+33 -10 replies
13/60drm/i915/dg1: Add and setup DPLLs for DG1drivers/gpu/drm/i915/display/intel_dpll_mgr.c+37 -40 replies
14/60drm/i915/dg1: Enable DPLL for DG1drivers/gpu/drm/i915/display/intel_dpll_mgr.c drivers/gpu/drm/i915/i915_reg.h+24 -100 replies
15/60drm/i915/dg1: add hpd interrupt handlingdrivers/gpu/drm/i915/display/intel_hotplug.c drivers/gpu/drm/i915/i915_irq.c drivers/gpu/drm/i915/i915_reg.h+61 -70 replies
16/60drm/i915/dg1: invert HPD pinsdrivers/gpu/drm/i915/i915_irq.c drivers/gpu/drm/i915/i915_reg.h+8 -00 replies
17/60drm/i915/dg1: gmbus pin mappingdrivers/gpu/drm/i915/display/intel_bios.c drivers/gpu/drm/i915/display/intel_gmbus.c drivers/gpu/drm/i915/display/intel_hdmi.c+24 -40 replies
18/60drm/i915/dg1: Enable first 2 ports for DG1drivers/gpu/drm/i915/display/intel_display.c+11 -40 replies
19/60drm/i915/dg1: Don't program PHY_MISC for PHY-C and PHY-Ddrivers/gpu/drm/i915/display/intel_combo_phy.c+2 -10 replies
20/60drm/i915/dg1: Update comp master/slave relationships for PHYsdrivers/gpu/drm/i915/display/intel_combo_phy.c+2 -20 replies
21/60drm/i915/dg1: Update voltage swing tables for DPdrivers/gpu/drm/i915/display/intel_ddi.c+34 -00 replies
22/60drm/i915/dg1: provide port/phy mapping for vbtdrivers/gpu/drm/i915/display/intel_bios.c+5 -30 replies
23/60drm/i915/dg1: map/unmap pll clocksdrivers/gpu/drm/i915/display/intel_ddi.c drivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/i915_reg.h+128 -40 replies
24/60drm/i915/dg1: enable PORT C/D aka D/Edrivers/gpu/drm/i915/display/intel_display.c+12 -60 replies
25/60drm/i915/dg1: Load DMCdrivers/gpu/drm/i915/display/intel_csr.c+13 -60 replies
26/60drm/i915/rkl: Add initial workaroundsdrivers/gpu/drm/i915/display/intel_sprite.c drivers/gpu/drm/i915/gt/intel_workarounds.c+59 -340 replies
27/60drm/i915/dg1: Add initial DG1 workaroundsdrivers/gpu/drm/i915/display/intel_display_power.c drivers/gpu/drm/i915/display/intel_sprite.c drivers/gpu/drm/i915/gt/intel_workarounds.c +3 more+108 -210 replies
28/60drm/i915/dg1: DG1 does not support DC6drivers/gpu/drm/i915/display/intel_display_power.c+4 -10 replies
29/60drm/i915/lmem: Limit block size to 4Gdrivers/gpu/drm/i915/intel_memory_region.c+13 -10 replies
30/60drm/i915/lmem: Do not check r->sgt.pfn for NULLdrivers/gpu/drm/i915/i915_mm.c+1 -10 replies
31/60drm/i915/dgfx: define llc and snooping behaviourdrivers/gpu/drm/i915/i915_pci.c+2 -00 replies
32/60drm/i915/lmem: support preaddrivers/gpu/drm/i915/gem/i915_gem_lmem.c drivers/gpu/drm/i915/gem/i915_gem_lmem.h drivers/gpu/drm/i915/gem/i915_gem_object_types.h +1 more+126 -02 replies
33/60drm/i915/lmem: support pwritedrivers/gpu/drm/i915/gem/i915_gem_lmem.c+86 -08 replies
34/60drm/i915: introduce kernel blitter_contextdrivers/gpu/drm/i915/gt/intel_engine_cs.c drivers/gpu/drm/i915/gt/intel_engine_types.h+27 -42 replies
35/60drm/i915/query: Expose memory regions through the query uAPIdrivers/gpu/drm/i915/gem/i915_gem_stolen.c drivers/gpu/drm/i915/gem/i915_gem_stolen.h drivers/gpu/drm/i915/i915_drv.c +5 more+172 -371 reply
36/60drm/i915/uapi: introduce drm_i915_gem_create_extdrivers/gpu/drm/i915/Makefile drivers/gpu/drm/i915/gem/i915_gem_create.c drivers/gpu/drm/i915/gem/i915_gem_object.c +7 more+481 -1030 replies
37/60drm/i915/lmem: allocate cmd ring in lmemdrivers/gpu/drm/i915/gt/intel_ring.c+11 -40 replies
38/60drm/i915/dg1: Introduce dmabuf mmap to LMEMdrivers/gpu/drm/i915/gem/i915_gem_dmabuf.c drivers/gpu/drm/i915/gem/i915_gem_mman.c drivers/gpu/drm/i915/gem/i915_gem_mman.h +1 more+119 -620 replies
39/60drm/i915: setup the LMEM regiondrivers/gpu/drm/i915/i915_reg.h drivers/gpu/drm/i915/intel_memory_region.c drivers/gpu/drm/i915/intel_region_lmem.c +1 more+53 -10 replies
40/60drm/i915: drop fake LMEMdrivers/gpu/drm/i915/i915_drv.c drivers/gpu/drm/i915/i915_params.c drivers/gpu/drm/i915/i915_params.h +3 more+1 -1320 replies
41/60drm/i915: Distinction of memory regionsdrivers/gpu/drm/i915/intel_memory_region.c+4 -00 replies
42/60drm/i915: PPGTT supportdrivers/gpu/drm/i915/gt/gen6_ppgtt.c drivers/gpu/drm/i915/gt/gen8_ppgtt.c drivers/gpu/drm/i915/gt/intel_gtt.c +3 more+155 -260 replies
43/60drm/i915: support GGTT LMEM entriesdrivers/gpu/drm/i915/gt/intel_ggtt.c drivers/gpu/drm/i915/gt/intel_gtt.h+20 -70 replies
44/60drm/i915: allocate context from LMEMdrivers/gpu/drm/i915/gt/intel_lrc.c+30 -10 replies
45/60drm/i915: move engine scratch to LMEMdrivers/gpu/drm/i915/gt/intel_gt.c+11 -30 replies
46/60drm/i915: Provide a way to disable PCIe relaxed write orderingdrivers/gpu/drm/i915/Kconfig.debug drivers/gpu/drm/i915/intel_memory_region.c+23 -00 replies
47/60drm/i915: setup GPU device lmem regiondrivers/gpu/drm/i915/i915_reg.h drivers/gpu/drm/i915/intel_region_lmem.c+9 -40 replies
48/60drm/i915: Fix object page offset within a regiondrivers/gpu/drm/i915/i915_gpu_error.c+3 -10 replies
49/60drm/i915: add i915_gem_object_is_devmem() functiondrivers/gpu/drm/i915/gem/i915_gem_lmem.c drivers/gpu/drm/i915/gem/i915_gem_lmem.h drivers/gpu/drm/i915/gt/intel_ggtt.c +3 more+17 -30 replies
50/60drm/i915: finish memory region support for stolen objects.drivers/gpu/drm/i915/display/intel_fbc.c drivers/gpu/drm/i915/gem/i915_gem_stolen.c drivers/gpu/drm/i915/gem/i915_gem_stolen.h +2 more+108 -1010 replies
51/60drm/i915/lmem: support optional CPU clearing for special internal usedrivers/gpu/drm/i915/gem/i915_gem_object_types.h drivers/gpu/drm/i915/gem/i915_gem_region.c drivers/gpu/drm/i915/selftests/intel_memory_region.c+108 -30 replies
52/60drm/i915/guc: put all guc objects in lmem when availabledrivers/gpu/drm/i915/gem/i915_gem_lmem.c drivers/gpu/drm/i915/gem/i915_gem_lmem.h drivers/gpu/drm/i915/gt/uc/intel_guc.c +3 more+107 -110 replies
53/60drm/i915: Create stolen memory region from local memorydrivers/gpu/drm/i915/gem/i915_gem_lmem.c drivers/gpu/drm/i915/gem/i915_gem_lmem.h drivers/gpu/drm/i915/gem/i915_gem_stolen.c +4 more+75 -107 replies
54/60drm/i915/lmem: Bypass aperture when lmem is availabledrivers/gpu/drm/i915/display/intel_fbdev.c drivers/gpu/drm/i915/i915_vma.c+29 -130 replies
55/60drm/i915/lmem: reset the lmem buffer created by fbdevdrivers/gpu/drm/i915/display/intel_fbdev.c+1 -10 replies
56/60drm/i915/dsb: Enable lmem for dsbdrivers/gpu/drm/i915/display/intel_dsb.c+6 -10 replies
57/60drm/i915: Reintroduce mem->reserveddrivers/gpu/drm/i915/intel_memory_region.c drivers/gpu/drm/i915/intel_memory_region.h drivers/gpu/drm/i915/selftests/intel_memory_region.c+93 -00 replies
58/60drm/i915/dg1: Reserve first 1MB of local memorydrivers/gpu/drm/i915/intel_region_lmem.c+52 -00 replies
59/60drm/i915: defer pd lmem block put to workerdrivers/gpu/drm/i915/i915_buddy.h drivers/gpu/drm/i915/intel_memory_region.c drivers/gpu/drm/i915/intel_memory_region.h +1 more+41 -50 replies
60/60drm/i915/lmem: allocate HWSP in lmemdrivers/gpu/drm/i915/gem/i915_gem_pages.c drivers/gpu/drm/i915/gt/intel_engine_cs.c drivers/gpu/drm/i915/gt/intel_timeline.c+28 -40 replies

Reviews trailers per patch

6 of 60 patches have a Reviewed-by or Acked-by.

PatchJosé Roberto de Souza
1/60R-b
2/60R-b
3/60R-b
4/60R-b
5/60R-b
6/60
7/60
8/60
9/60
10/60
11/60
12/60
13/60
14/60
15/60
16/60
17/60
18/60
19/60
20/60
21/60
22/60
23/60
24/60
25/60
26/60R-b
27/60
28/60
29/60
30/60
31/60
32/60
33/60
34/60
35/60
36/60
37/60
38/60
39/60
40/60
41/60
42/60
43/60
44/60
45/60
46/60
47/60
48/60
49/60
50/60
51/60
52/60
53/60
54/60
55/60
56/60
57/60
58/60
59/60
60/60

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Intel-gfx] [RFC 00/60] DG1 LMEM enabling

This is Lucas' DG1 enabling series[1], plus some of the DG1 specific enablers for supporting LMEM on top, including some bits of new uAPI.

Posting this series as RFC to get feedback while we continue to work on adapting the code to use DMA reservation incrementally. This is currently WIP[2][3].

In terms of new uAPI we have gem_create_ext, which offers extensions support for gem_create, this includes giving userspace the ability to optionally provide a priority list of potential placements for the object. The other bit of new uAPI is the query interface for memory regions, which describes the supported memory regions for the device. What this reports can then be fed into gem_create_ext to specify where an object might reside, like device local memory.

[1] https://patchwork.freedesktop.org/series/77496/
[2] https://patchwork.freedesktop.org/series/79091/
[3] https://patchwork.freedesktop.org/series/79129/

Abdiel Janulgue (5):
drm/i915/dg1: add initial DG-1 definitions drm/i915/dg1: Add DG1 PCI IDs
drm/i915/query: Expose memory regions through the query uAPI drm/i915: Provide a way to disable PCIe relaxed write ordering drm/i915: Reintroduce mem->reserved

Aditya Swarup (4):
drm/i915/dg1: Add DPLL macros for DG1
drm/i915/dg1: Add and setup DPLLs for DG1
drm/i915/dg1: Enable DPLL for DG1
drm/i915/dg1: Enable first 2 ports for DG1

Animesh Manna (2):
drm/i915/lmem: reset the lmem buffer created by fbdev drm/i915/dsb: Enable lmem for dsb

Anshuman Gupta (1):
drm/i915/dg1: DG1 does not support DC6

Anusha Srivatsa (2):
drm/i915/dg1: Remove SHPD_FILTER_CNT register programming drm/i915/lmem: Bypass aperture when lmem is available

CQ Tang (5):
drm/i915: setup GPU device lmem region
drm/i915: Fix object page offset within a region drm/i915: add i915_gem_object_is_devmem() function drm/i915: finish memory region support for stolen objects. drm/i915: Create stolen memory region from local memory

Clinton A Taylor (1):
drm/i915/dg1: invert HPD pins

Daniele Ceraolo Spurio (2):
drm/i915/guc: put all guc objects in lmem when available drm/i915: defer pd lmem block put to worker

Imre Deak (1):
drm/i915/dg1: Reserve first 1MB of local memory

Lucas De Marchi (7):
drm/i915/dg1: add support for the master unit interrupt drm/i915/dg1: Add fake PCH
drm/i915/dg1: Define MOCS table for DG1 drm/i915/dg1: add hpd interrupt handling drm/i915/dg1: gmbus pin mapping
drm/i915/dg1: map/unmap pll clocks drm/i915/dg1: enable PORT C/D aka D/E

Matt Atwood (1):
drm/i915/dg1: Load DMC

Matt Roper (7):
drm/i915/dg1: Initialize RAWCLK properly drm/i915/dg1: Wait for pcode/uncore handshake at startup drm/i915/dg1: Don't program PHY_MISC for PHY-C and PHY-D drm/i915/dg1: Update comp master/slave relationships for PHYs drm/i915/dg1: Update voltage swing tables for DP drm/i915/dg1: provide port/phy mapping for vbt drm/i915/rkl: Add initial workarounds

Matthew Auld (11):
drm/i915/lmem: support pread
drm/i915/lmem: support pwrite
drm/i915: introduce kernel blitter_context
drm/i915/uapi: introduce drm_i915_gem_create_ext
drm/i915: setup the LMEM region
drm/i915: drop fake LMEM
drm/i915: PPGTT support
drm/i915: support GGTT LMEM entries
drm/i915: allocate context from LMEM
drm/i915: move engine scratch to LMEM
drm/i915/lmem: support optional CPU clearing for special internal use

Michael J. Ruhl (1):
drm/i915/dg1: Introduce dmabuf mmap to LMEM

Michel Thierry (3):
drm/i915/dgfx: define llc and snooping behaviour drm/i915/lmem: allocate cmd ring in lmem drm/i915/lmem: allocate HWSP in lmem

Stuart Summers (2):
drm/i915: Add has_master_unit_irq flag
drm/i915/dg1: Add initial DG1 workarounds

Uma Shankar (1):
drm/i915/dg1: Add DG1 power wells

Venkata Sandeep Dhanalakota (2):
drm/i915/dg1: Increase mmio size to 4MB
drm/i915/lmem: Limit block size to 4G

Wen, Kui (1):
drm/i915/lmem: Do not check r->sgt.pfn for NULL

Zbigniew Kempczyński (1):
drm/i915: Distinction of memory regions

 drivers/gpu/drm/i915/Kconfig.debug            |  11 +
 drivers/gpu/drm/i915/Makefile                 |   1 +
 drivers/gpu/drm/i915/display/intel_bios.c     |  12 +-
 drivers/gpu/drm/i915/display/intel_cdclk.c    |  16 +-
 .../gpu/drm/i915/display/intel_combo_phy.c    |   7 +-
 drivers/gpu/drm/i915/display/intel_csr.c      |  19 +-
 drivers/gpu/drm/i915/display/intel_ddi.c      | 126 +++++-
 drivers/gpu/drm/i915/display/intel_display.c  |  50 ++-
 .../drm/i915/display/intel_display_power.c    | 211 +++++++++-
 drivers/gpu/drm/i915/display/intel_dpll_mgr.c |  71 +++-
 drivers/gpu/drm/i915/display/intel_dpll_mgr.h |  17 +
 drivers/gpu/drm/i915/display/intel_dsb.c      |   7 +-
 drivers/gpu/drm/i915/display/intel_fbc.c      |  20 +-
 drivers/gpu/drm/i915/display/intel_fbdev.c    |  25 +-
 drivers/gpu/drm/i915/display/intel_gmbus.c    |  15 +-
 drivers/gpu/drm/i915/display/intel_hdmi.c     |   9 +-
 drivers/gpu/drm/i915/display/intel_hotplug.c  |   3 +-
 drivers/gpu/drm/i915/display/intel_sprite.c   |   5 +-
 drivers/gpu/drm/i915/gem/i915_gem_create.c    | 379 ++++++++++++++++++
 drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c    |  58 ++-
 drivers/gpu/drm/i915/gem/i915_gem_lmem.c      | 250 +++++++++++-
 drivers/gpu/drm/i915/gem/i915_gem_lmem.h      |  22 +
 drivers/gpu/drm/i915/gem/i915_gem_mman.c      | 103 ++---
 drivers/gpu/drm/i915/gem/i915_gem_mman.h      |   8 +
 drivers/gpu/drm/i915/gem/i915_gem_object.c    |   2 +
 .../gpu/drm/i915/gem/i915_gem_object_types.h  |  19 +-
 drivers/gpu/drm/i915/gem/i915_gem_pages.c     |  14 +-
 drivers/gpu/drm/i915/gem/i915_gem_region.c    |  24 ++
 drivers/gpu/drm/i915/gem/i915_gem_stolen.c    | 241 +++++++----
 drivers/gpu/drm/i915/gem/i915_gem_stolen.h    |  10 +-
 .../drm/i915/gem/selftests/i915_gem_mman.c    |  12 +-
 drivers/gpu/drm/i915/gt/gen6_ppgtt.c          |   2 +
 drivers/gpu/drm/i915/gt/gen8_ppgtt.c          |  83 +++-
 drivers/gpu/drm/i915/gt/intel_engine_cs.c     |  40 +-
 drivers/gpu/drm/i915/gt/intel_engine_types.h  |   1 +
 drivers/gpu/drm/i915/gt/intel_ggtt.c          |  24 +-
 drivers/gpu/drm/i915/gt/intel_gt.c            |  14 +-
 drivers/gpu/drm/i915/gt/intel_gtt.c           |  74 +++-
 drivers/gpu/drm/i915/gt/intel_gtt.h           |  11 +-
 drivers/gpu/drm/i915/gt/intel_lrc.c           |  31 +-
 drivers/gpu/drm/i915/gt/intel_mocs.c          |  39 +-
 drivers/gpu/drm/i915/gt/intel_ppgtt.c         |  10 +-
 drivers/gpu/drm/i915/gt/intel_ring.c          |  15 +-
 drivers/gpu/drm/i915/gt/intel_timeline.c      |   8 +-
 drivers/gpu/drm/i915/gt/intel_workarounds.c   | 159 ++++++--
 drivers/gpu/drm/i915/gt/uc/intel_guc.c        |   9 +-
 drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c     |  11 +-
 drivers/gpu/drm/i915/gt/uc/intel_huc.c        |  14 +-
 drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c      |  35 +-
 drivers/gpu/drm/i915/i915_buddy.h             |  10 +
 drivers/gpu/drm/i915/i915_debugfs.c           |   4 +
 drivers/gpu/drm/i915/i915_drv.c               |  22 +-
 drivers/gpu/drm/i915/i915_drv.h               |  15 +-
 drivers/gpu/drm/i915/i915_gem.c               | 109 +----
 drivers/gpu/drm/i915/i915_gem_gtt.c           |   2 +
 drivers/gpu/drm/i915/i915_gpu_error.c         |   4 +-
 drivers/gpu/drm/i915/i915_irq.c               | 120 +++++-
 drivers/gpu/drm/i915/i915_mm.c                |   2 +-
 drivers/gpu/drm/i915/i915_params.c            |   5 -
 drivers/gpu/drm/i915/i915_params.h            |   1 -
 drivers/gpu/drm/i915/i915_pci.c               |  18 +-
 drivers/gpu/drm/i915/i915_query.c             |  62 +++
 drivers/gpu/drm/i915/i915_reg.h               |  71 +++-
 drivers/gpu/drm/i915/i915_vma.c               |  19 +-
 drivers/gpu/drm/i915/intel_device_info.c      |   1 +
 drivers/gpu/drm/i915/intel_device_info.h      |   2 +
 drivers/gpu/drm/i915/intel_memory_region.c    | 119 +++++-
 drivers/gpu/drm/i915/intel_memory_region.h    |  55 ++-
 drivers/gpu/drm/i915/intel_pch.c              |   6 +
 drivers/gpu/drm/i915/intel_pch.h              |   4 +
 drivers/gpu/drm/i915/intel_pm.c               |  17 +-
 drivers/gpu/drm/i915/intel_region_lmem.c      | 164 ++++----
 drivers/gpu/drm/i915/intel_region_lmem.h      |   3 +-
 drivers/gpu/drm/i915/intel_sideband.c         |  15 +
 drivers/gpu/drm/i915/intel_sideband.h         |   2 +
 drivers/gpu/drm/i915/intel_uncore.c           |   4 +
 .../drm/i915/selftests/intel_memory_region.c  | 172 ++++++++
 .../gpu/drm/i915/selftests/mock_gem_device.c  |   3 +-
 include/drm/i915_pciids.h                     |   4 +
 include/uapi/drm/i915_drm.h                   | 118 ++++++
 80 files changed, 2902 insertions(+), 598 deletions(-)
 create mode 100644 drivers/gpu/drm/i915/gem/i915_gem_create.c
Signature · 6 lines
2.26.2

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx