Skip to content

qemu-img convert: Fix abort with unaligned image size

Kevin Wolf qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 4 repliesIn review
  2. v12 patches 16 repliesSuperseded

Changes in v2 from the cover letter

- Don't fail opening unaligned images, but requesting WRITE permission without RESIZE. This keeps qcow2 images with unaligned metadata at EOF working. [Max]

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2block: Require aligned image size to avoid assertion failureblock.c+16 -03 replies
2/2file-posix: Allow byte-aligned O_DIRECT with NFSblock/file-posix.c+25 -11 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchEric BlakeMax Reitz
1/2R-b
2/2R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH for-5.1 v2 0/2] qemu-img convert: Fix abort with unaligned image size

Patch 1 fixes the assertion failure by failing gracefully when opening an image whose size isn't aligned to the required request alignment.

Patch 2 relaxes the restrictions for NFS, which actually supports byte alignment, but incorrectly gets a 4k request alignment in the file-posix block driver.

v2:
- Don't fail opening unaligned images, but requesting WRITE permission without RESIZE. This keeps qcow2 images with unaligned metadata at EOF working. [Max]

Kevin Wolf (2):
block: Require aligned image size to avoid assertion failure
file-posix: Allow byte-aligned O_DIRECT with NFS

 block.c            | 16 ++++++++++++++++
 block/file-posix.c | 26 +++++++++++++++++++++++++-
 2 files changed, 41 insertions(+), 1 deletion(-)
Signature · 1 line
2.25.4