qemu-img convert: Fix abort with unaligned image size
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest2 patches 4 repliesIn review
- v12 patches 16 repliesSuperseded
Changes in v2 from the cover letter
- Don't fail opening unaligned images, but requesting WRITE permission without RESIZE. This keeps qcow2 images with unaligned metadata at EOF working. [Max]
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | block: Require aligned image size to avoid assertion failureblock.c | +16 | 3 replies | |
| 2/2 | file-posix: Allow byte-aligned O_DIRECT with NFSblock/ | +25 | 1 reply |
Reviews trailers per patch
All 2 patches have a Reviewed-by or Acked-by.
| Patch | Eric Blake | Max Reitz |
|---|---|---|
| 1/2 | R-b | |
| 2/2 | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH for-5.1 v2 0/2] qemu-img convert: Fix abort with unaligned image size
Patch 1 fixes the assertion failure by failing gracefully when opening an image whose size isn't aligned to the required request alignment.
Patch 2 relaxes the restrictions for NFS, which actually supports byte alignment, but incorrectly gets a 4k request alignment in the file-posix block driver.
v2:
- Don't fail opening unaligned images, but requesting WRITE permission without RESIZE. This keeps qcow2 images with unaligned metadata at EOF working. [Max]
Kevin Wolf (2):
block: Require aligned image size to avoid assertion failure
file-posix: Allow byte-aligned O_DIRECT with NFS
block.c | 16 ++++++++++++++++ block/file-posix.c | 26 +++++++++++++++++++++++++- 2 files changed, 41 insertions(+), 1 deletion(-)
Signature · 1 line
2.25.4