Skip to content

block: add logging facility for long standing IO requests

Denis V. Lunev qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest posting 2/23 patches 8 repliesIn review
  2. v2 posting 1/23 patches 2 repliesSuperseded
  3. v12 patches 8 repliesSuperseded

Changes in v2 from the cover letter

- fixed conversions using macros suggested by Stefan
- fixed option declaration
- enabled by default with patch 3

Patches in v2 posting 2/2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3block/block-backend: add converter from BlockAcctStats to BlockBackendblock/block-backend.c include/sysemu/block-backend.h+6 -01 reply
2/3block: add logging facility for long standing IO requestsblock/accounting.c blockdev.c include/block/accounting.h+68 -34 replies
3/3block: enable long IO requests report by defaultblockdev.c+6 -11 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchVladimir Sementsov-OgievskiyStefan HajnocziMax Reitz
SeriesR-b
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCH v2 for 5.2 0/3] block: add logging facility for long standing IO requests

There are severe delays with IO requests processing if QEMU is running in virtual machine or over software defined storage. Such delays potentially results in unpredictable guest behavior. For example, guests over IDE or SATA drive could remount filesystem read-only if write is performed longer than 10 seconds.

Such reports are very complex to process. Some good starting point for this seems quite reasonable. This patch provides one. It adds logging of such potentially dangerous long IO operations.

Changed from v2:
- removed accidentally added slirp subproject ID
- added comment describing timeout selection to patch 3

Changes from v1:
- fixed conversions using macros suggested by Stefan
- fixed option declaration
- enabled by default with patch 3

CC Vladimir Sementsov-Ogievskiy <[email protected]>
CC Kevin Wolf <[email protected]>
CC Max Reitz <[email protected]>
CC Stefan Hajnoczi <[email protected]>